Re: [PATCH 0/5] Fix notmuch_database_get_directory API

diff --git a/d3/b6e0ecda0d0df42232ea28ccafe7c021172375 b/d3/b6e0ecda0d0df42232ea28ccafe7c021172375
new file mode 100644 (file)
index 0000000..446e988
--- /dev/null
+++ b/d3/b6e0ecda0d0df42232ea28ccafe7c021172375
@@ -0,0 +1,71 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 9D8AF431FB6\r
+       for <notmuch@notmuchmail.org>; Sun, 13 May 2012 13:50:05 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id AIDiZhBnf9Rp for <notmuch@notmuchmail.org>;\r
+       Sun, 13 May 2012 13:50:04 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66])\r
+       by olra.theworths.org (Postfix) with ESMTP id 9F6AD431FAE\r
+       for <notmuch@notmuchmail.org>; Sun, 13 May 2012 13:50:04 -0700 (PDT)\r
+Received: by guru.guru-group.fi (Postfix, from userid 501)\r
+       id F3F4868021; Sun, 13 May 2012 23:49:58 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 0/5] Fix notmuch_database_get_directory API\r
+In-Reply-To: <1336939029-13969-1-git-send-email-amdragon@mit.edu>\r
+References: <1336939029-13969-1-git-send-email-amdragon@mit.edu>\r
+User-Agent: Notmuch/0.13~rc1+15~ge68de87 (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Sun, 13 May 2012 23:49:58 +0300\r
+Message-ID: <m2txzjlsax.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 13 May 2012 20:50:05 -0000\r
+\r
+On Sun, May 13 2012, Austin Clements <amdragon@MIT.EDU> wrote:\r
+\r
+> This is a proposed last-minute change for 0.13.  It fixes the\r
+> notmuch_database_get_directory API in the same way we're fixing\r
+> notmuch_database_open, etc in this release.  Since this is a\r
+> backwards-incompatible change, it would be nice to lump it with the\r
+> other API-breaking changes.\r
+>\r
+> To keep the patch simple, this does not change the behavior of\r
+> notmuch_database_get_directory, but it puts us in a good position to\r
+> fix it in the future.\r
+\r
+Looks good to me (and applied in my current environment). The c/c++ \r
+changes were easy to understand and the python/go/ruby binding\r
+changes looks like the old changes -- but those who understand more\r
+(and actually uses those bindings) could do better review.\r
+\r
+It would be nice to get those in so that we may have chance not\r
+updating SONAME for notmuch 0.14.\r
+\r
+\r
+Tomi\r