Re: [PATCH 0/7] Various fixes for the Go bindings

diff --git a/85/46058fc1b3a8645c2ac503f85bdb795f3c56a5 b/85/46058fc1b3a8645c2ac503f85bdb795f3c56a5
new file mode 100644 (file)
index 0000000..af2639a
--- /dev/null
+++ b/85/46058fc1b3a8645c2ac503f85bdb795f3c56a5
@@ -0,0 +1,78 @@
+Return-Path: <adrien@bustany.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id C9701431FC0\r
+       for <notmuch@notmuchmail.org>; Thu, 19 Jul 2012 11:29:48 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id XdEK0FUv2JvM for <notmuch@notmuchmail.org>;\r
+       Thu, 19 Jul 2012 11:29:48 -0700 (PDT)\r
+Received: from mail.bustany.org (bustany.org [176.31.244.208])\r
+       by olra.theworths.org (Postfix) with ESMTP id 40F7F431FAE\r
+       for <notmuch@notmuchmail.org>; Thu, 19 Jul 2012 11:29:48 -0700 (PDT)\r
+Received: from [192.168.1.147] (91-158-2-79.elisa-laajakaista.fi\r
+ [91.158.2.79])        by mail.bustany.org (Postfix) with ESMTPSA id 0D040140090;\r
+       Thu, 19 Jul 2012 20:32:16 +0200 (CEST)\r
+Message-ID: <50085219.1090403@bustany.org>\r
+Date: Thu, 19 Jul 2012 21:29:45 +0300\r
+From: Adrien Bustany <adrien@bustany.org>\r
+User-Agent: Mozilla/5.0 (X11; Linux x86_64;\r
+       rv:13.0) Gecko/20120615 Thunderbird/13.0.1\r
+MIME-Version: 1.0\r
+To: Austin Clements <amdragon@MIT.EDU>\r
+Subject: Re: [PATCH 0/7] Various fixes for the Go bindings\r
+References: <1342636475-16057-1-git-send-email-adrien@bustany.org>\r
+       <20120718205140.GW31670@mit.edu>\r
+In-Reply-To: <20120718205140.GW31670@mit.edu>\r
+Content-Type: text/plain; charset=ISO-8859-1; format=flowed\r
+Content-Transfer-Encoding: 8bit\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 19 Jul 2012 18:29:48 -0000\r
+\r
+Well, thanks for the quick review :)\r
+\r
+I have updated all the patches to take your fixes into account, there is \r
+still the discussion left about the GC integration. Once we get that \r
+sorted out, I'll send the updated version.\r
+\r
+Le 18/07/2012 23:51, Austin Clements a écrit :\r
+> This series looks good to me other than the few things I commented on.\r
+> It's nice to see the Go bindings get a bit of love!\r
+>\r
+> Quoth Adrien Bustany on Jul 18 at  9:34 pm:\r
+>> The following patches fix some serious memory management issues with\r
+>> the Go bindings, and add some missing functions as well.\r
+>>\r
+>> Adrien Bustany (7):\r
+>>    go: Use iota in enum bindings\r
+>>    go: Add missing MESSAGE_FLAG_EXCLUDED in Flag enum\r
+>>    go: Allow notmuch objects to be garbage collected\r
+>>    go: Make Destroy functions safe to call several times\r
+>>    go: Partially bind notmuch_database_upgrade\r
+>>    go: Bind notmuch_database_find_message_by_filename\r
+>>    go: Bind notmuch_thread_t functions\r
+>>\r
+>>   bindings/go/src/notmuch/notmuch.go |  471 ++++++++++++++++++++++++++++++++++--\r
+>>   1 files changed, 447 insertions(+), 24 deletions(-)\r
+>>\r
+\r
+\r