From: Adrien Bustany Date: Thu, 19 Jul 2012 18:29:45 +0000 (+0300) Subject: Re: [PATCH 0/7] Various fixes for the Go bindings X-Git-Url: http://git.tremily.us/?p=notmuch-archives.git;a=commitdiff_plain;h=4fc8d332192537fa40fca523f98aa8a85edf305c Re: [PATCH 0/7] Various fixes for the Go bindings --- diff --git a/85/46058fc1b3a8645c2ac503f85bdb795f3c56a5 b/85/46058fc1b3a8645c2ac503f85bdb795f3c56a5 new file mode 100644 index 000000000..af2639ae9 --- /dev/null +++ b/85/46058fc1b3a8645c2ac503f85bdb795f3c56a5 @@ -0,0 +1,78 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id C9701431FC0 + for ; Thu, 19 Jul 2012 11:29:48 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id XdEK0FUv2JvM for ; + Thu, 19 Jul 2012 11:29:48 -0700 (PDT) +Received: from mail.bustany.org (bustany.org [176.31.244.208]) + by olra.theworths.org (Postfix) with ESMTP id 40F7F431FAE + for ; Thu, 19 Jul 2012 11:29:48 -0700 (PDT) +Received: from [192.168.1.147] (91-158-2-79.elisa-laajakaista.fi + [91.158.2.79]) by mail.bustany.org (Postfix) with ESMTPSA id 0D040140090; + Thu, 19 Jul 2012 20:32:16 +0200 (CEST) +Message-ID: <50085219.1090403@bustany.org> +Date: Thu, 19 Jul 2012 21:29:45 +0300 +From: Adrien Bustany +User-Agent: Mozilla/5.0 (X11; Linux x86_64; + rv:13.0) Gecko/20120615 Thunderbird/13.0.1 +MIME-Version: 1.0 +To: Austin Clements +Subject: Re: [PATCH 0/7] Various fixes for the Go bindings +References: <1342636475-16057-1-git-send-email-adrien@bustany.org> + <20120718205140.GW31670@mit.edu> +In-Reply-To: <20120718205140.GW31670@mit.edu> +Content-Type: text/plain; charset=ISO-8859-1; format=flowed +Content-Transfer-Encoding: 8bit +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 19 Jul 2012 18:29:48 -0000 + +Well, thanks for the quick review :) + +I have updated all the patches to take your fixes into account, there is +still the discussion left about the GC integration. Once we get that +sorted out, I'll send the updated version. + +Le 18/07/2012 23:51, Austin Clements a écrit : +> This series looks good to me other than the few things I commented on. +> It's nice to see the Go bindings get a bit of love! +> +> Quoth Adrien Bustany on Jul 18 at 9:34 pm: +>> The following patches fix some serious memory management issues with +>> the Go bindings, and add some missing functions as well. +>> +>> Adrien Bustany (7): +>> go: Use iota in enum bindings +>> go: Add missing MESSAGE_FLAG_EXCLUDED in Flag enum +>> go: Allow notmuch objects to be garbage collected +>> go: Make Destroy functions safe to call several times +>> go: Partially bind notmuch_database_upgrade +>> go: Bind notmuch_database_find_message_by_filename +>> go: Bind notmuch_thread_t functions +>> +>> bindings/go/src/notmuch/notmuch.go | 471 ++++++++++++++++++++++++++++++++++-- +>> 1 files changed, 447 insertions(+), 24 deletions(-) +>> + +