Re: [PATCH 06/11] emacs: Remove broken `notmuch-get-bodypart-content' API

diff --git a/8d/abd781f5725d9611b359bf5d4b0849619a7a0d b/8d/abd781f5725d9611b359bf5d4b0849619a7a0d
new file mode 100644 (file)
index 0000000..d173d14
--- /dev/null
+++ b/8d/abd781f5725d9611b359bf5d4b0849619a7a0d
@@ -0,0 +1,115 @@
+Return-Path: <aclements@csail.mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 98AD7431FCB\r
+       for <notmuch@notmuchmail.org>; Sat, 24 Jan 2015 09:10:36 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.138\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.138 tagged_above=-999 required=5\r
+       tests=[DNS_FROM_AHBL_RHSBL=2.438, RCVD_IN_DNSWL_MED=-2.3]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id AgJvQKKZugG9 for <notmuch@notmuchmail.org>;\r
+       Sat, 24 Jan 2015 09:10:32 -0800 (PST)\r
+Received: from outgoing.csail.mit.edu (outgoing.csail.mit.edu [128.30.2.149])\r
+       by olra.theworths.org (Postfix) with ESMTP id CB218431FAE\r
+       for <notmuch@notmuchmail.org>; Sat, 24 Jan 2015 09:10:32 -0800 (PST)\r
+Received: from [104.131.20.129] (helo=awakeningjr)\r
+       by outgoing.csail.mit.edu with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16)\r
+       (Exim 4.72) (envelope-from <aclements@csail.mit.edu>)\r
+       id 1YF4EA-00045v-PF; Sat, 24 Jan 2015 12:10:30 -0500\r
+Received: from amthrax by awakeningjr with local (Exim 4.84)\r
+       (envelope-from <aclements@csail.mit.edu>)\r
+       id 1YF4EA-0003V9-0W; Sat, 24 Jan 2015 12:10:30 -0500\r
+From: Austin Clements <amdragon@mit.edu>\r
+To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 06/11] emacs: Remove broken `notmuch-get-bodypart-content'\r
+       API\r
+In-Reply-To: <8738e8p13v.fsf@maritornes.cs.unb.ca>\r
+References: <1398105468-14317-1-git-send-email-amdragon@mit.edu>\r
+       <1398105468-14317-7-git-send-email-amdragon@mit.edu>\r
+       <8738e8p13v.fsf@maritornes.cs.unb.ca>\r
+User-Agent: Notmuch/0.18.1+86~gef5e66a (http://notmuchmail.org) Emacs/24.4.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sat, 24 Jan 2015 12:10:29 -0500\r
+Message-ID: <874mrgumt6.fsf@csail.mit.edu>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 24 Jan 2015 17:10:36 -0000\r
+\r
+On Fri, 11 Jul 2014, David Bremner <david@tethera.net> wrote:\r
+> Austin Clements <amdragon@MIT.EDU> writes:\r
+>\r
+>> +This returns the content of the given part as a multibyte Lisp\r
+>\r
+> What does "multibyte" mean here? utf8? current encoding?\r
+\r
+Elisp has two kinds of stings: "unibyte strings" and "multibyte\r
+strings".\r
+\r
+  https://www.gnu.org/software/emacs/manual/html_node/elisp/Non_002dASCII-in-Strings.html\r
+\r
+You can think of unibyte strings as binary data; they're just vectors of\r
+bytes without any particular encoding semantics (though when you use a\r
+unibyte string you can endow it with encoding).  Multibyte strings,\r
+however, are text; they're vectors of Unicode code points.\r
+\r
+>> +string after performing content transfer decoding and any\r
+>> +necessary charset decoding.  It is an error to use this for\r
+>> +non-text/* parts."\r
+>> +  (let ((content (plist-get part :content)))\r
+>> +    (when (not content)\r
+>> +      ;; Use show --format=sexp to fetch decoded content\r
+>> +      (let* ((args `("show" "--format=sexp" "--include-html"\r
+>> +                ,(format "--part=%s" (plist-get part :id))\r
+>> +                ,@(when process-crypto '("--decrypt"))\r
+>> +                ,(notmuch-id-to-query (plist-get msg :id))))\r
+>> +        (npart (apply #'notmuch-call-notmuch-sexp args)))\r
+>> +   (setq content (plist-get npart :content))\r
+>> +   (when (not content)\r
+>> +     (error "Internal error: No :content from %S" args))))\r
+>> +    content))\r
+>\r
+> I'm a bit curious at the lack of setting "coding-system-for-read" here.\r
+> Are we assuming the user has their environment set up correctly? Not so\r
+> much a criticism as being nervous about everything coding-system\r
+> related.\r
+\r
+That is interesting.  coding-system-for-read should really go in\r
+notmuch-call-notmuch-sexp, but I worry that, while *almost* all strings\r
+the CLI outputs are UTF-8, not quite all of them are.  For example, we\r
+output filenames exactly at the OS reports the bytes to us (which is\r
+necessary, in a sense, because POSIX enforces no particular encoding on\r
+file names, but still really unfortunate).\r
+\r
+We could set coding-system-for-read, but a full solution needs more\r
+cooperation from the CLI.  Possibly the right answer, at least for the\r
+sexp format, is to do our own UTF-8 to "\uXXXX" escapes for strings that\r
+are known to be UTF-8 and leave the raw bytes for the few that aren't.\r
+Then we would set the coding-system-for-read to 'no-conversion and I\r
+think everything would Just Work.\r
+\r
+That doesn't help for JSON, which is supposed to be all UTF-8 all the\r
+time.  I can think of solutions there, but they're all ugly and involve\r
+things like encoding filenames as base64 when they aren't valid UTF-8.\r
+\r
+So...  I don't think I'm going to do anything about this at this moment.\r
+\r
+> I didn't see anything else to object to in this patch or the previous\r
+> one.\r