Re: [PATCH 2/3] notmuch-mutt: support for messages that lack Message-ID headers

diff --git a/20/792fc85c946b08d8c0c4a7433530d07d0e3127 b/20/792fc85c946b08d8c0c4a7433530d07d0e3127
new file mode 100644 (file)
index 0000000..e6df4f1
--- /dev/null
+++ b/20/792fc85c946b08d8c0c4a7433530d07d0e3127
@@ -0,0 +1,103 @@
+Return-Path: <jan.n.klug@rub.de>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 7877C431FCB\r
+       for <notmuch@notmuchmail.org>; Sat, 24 Jan 2015 09:04:01 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.138\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.138 tagged_above=-999 required=5\r
+       tests=[DNS_FROM_AHBL_RHSBL=2.438, RCVD_IN_DNSWL_MED=-2.3]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id DevVVvE22vgC for <notmuch@notmuchmail.org>;\r
+       Sat, 24 Jan 2015 09:03:58 -0800 (PST)\r
+X-Greylist: delayed 401 seconds by postgrey-1.32 at olra;\r
+       Sat, 24 Jan 2015 09:03:57 PST\r
+Received: from mx6.rz.ruhr-uni-bochum.de (mi.ruhr-uni-bochum.de\r
+       [134.147.64.30])\r
+       by olra.theworths.org (Postfix) with SMTP id EB83A431FAE\r
+       for <notmuch@notmuchmail.org>; Sat, 24 Jan 2015 09:03:57 -0800 (PST)\r
+X-Queued: (qmail 3693 invoked by alias); 24 Jan 2015 16:57:16 -0000\r
+X-RUB-Notes: Internal\r
+X-Queued: (qmail 3615 invoked by uid 108); 24 Jan 2015 16:57:15 -0000\r
+X-Qmailscanner: from 134.147.42.227 by mx6.rz.ruhr-uni-bochum.de\r
+       (envelope-from <jan.n.klug@rub.de>,\r
+       uid 102) with qmail-scanner-2.01 (clamdscan: 0.98.1/18526.  \r
+       Clear:RC:1(134.147.42.227):. \r
+       Processed in 0.076136 secs); 24 Jan 2015 16:57:15 -0000\r
+Received: from mail1.mail.ruhr-uni-bochum.de (134.147.42.227)\r
+       by mx6.rz.ruhr-uni-bochum.de with SMTP; 24 Jan 2015 16:57:15 -0000\r
+Received: from localhost (mobil-13.rubion.ruhr-uni-bochum.de [134.147.65.233])\r
+       by mail1.mail.ruhr-uni-bochum.de (Postfix) with ESMTPSA id A5C37200E2\r
+       for <notmuch@notmuchmail.org>; Sat, 24 Jan 2015 17:57:14 +0100 (CET)\r
+Date: Sat, 24 Jan 2015 17:56:39 +0100\r
+From: "Jan N. Klug" <jan.n.klug@rub.de>\r
+To: notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 2/3] notmuch-mutt: support for messages that lack\r
+       Message-ID      headers\r
+Message-ID: <20150124165639.GA1316@mobil-13.rubion.rub.de>\r
+References: <1422090701-19385-1-git-send-email-zack@upsilon.cc>\r
+       <1422090701-19385-3-git-send-email-zack@upsilon.cc>\r
+       <871tmkql6j.fsf@nikula.org> <20150124152106.GA23037@upsilon.cc>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <20150124152106.GA23037@upsilon.cc>\r
+User-Agent: Mutt/1.5.23 (2014-03-12)\r
+X-Virus-Scanned: clamav-milter 0.98.5 at mail1.mail.ruhr-uni-bochum.de\r
+X-Virus-Status: Clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 24 Jan 2015 17:04:01 -0000\r
+\r
+On Sat, Jan 24, 2015 at 04:21:06PM +0100, Stefano Zacchiroli wrote:\r
+> On Sat, Jan 24, 2015 at 04:59:16PM +0200, Jani Nikula wrote:\r
+> > On Sat, 24 Jan 2015, Stefano Zacchiroli <zack@upsilon.cc> wrote:\r
+> > > To do the above, rewrite get_message_id() to scan the current message\r
+> > > line by line, incrementally computing a SHA1. As a consequence, drop\r
+> > > the dependency on Mail::Internet.\r
+> > \r
+> > I am not so sure this is a good idea however, see below.\r
+> [...]\r
+> But I didn't think of header folding, and you're absolutely correct in\r
+> saying that might be a problem.\r
+\r
+I disagree. I do not think that header folding is a problem here. RFC\r
+5322 and RFC 2822 state that FWS in the message-id are not allowed (as\r
+opposed to In-Reply: and other headers, where FWS may occur between, but\r
+not inside message-ids).\r
+\r
+Folded lines that start with "Message-Id:" might occur, the\r
+regex-pattern used in the patch will not match those lines. \r
+\r
+As far as I have looked in the Mail::Internet sources, further checking of the\r
+correctness of the message-id does not occur, so I do not see any\r
+advantage over the proposed solution. \r
+\r
+> Jan: do you agree with using Mail::Header->new and fall back to\r
+> line-by-line hasing only in case Message-ID is not found? If so, having\r
+> an updated patch based on the one I've posted here would be awesome! If\r
+> you cannot do that just let me know and I'll get to it, eventually :).\r
+\r
+I can look into that, but I cannot promise to have it ready in the next\r
+days.\r
+\r
+Regards,\r
+\r
+Jan\r
+--\r
+Jan N. Klug, Gelsenkirchen\r