Re: [PATCH 25/25] Fix stdout stream grabbing in format_part_content_text

diff --git a/c2/094e4d6269a808e24d7f3116df9001fd8c6493 b/c2/094e4d6269a808e24d7f3116df9001fd8c6493
new file mode 100644 (file)
index 0000000..a4e3485
--- /dev/null
+++ b/c2/094e4d6269a808e24d7f3116df9001fd8c6493
@@ -0,0 +1,130 @@
+Return-Path: <cworth@cworth.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id B7834431FD0\r
+       for <notmuch@notmuchmail.org>; Fri,  3 Jun 2011 12:56:57 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id mOmNjfiB63Gn for <notmuch@notmuchmail.org>;\r
+       Fri,  3 Jun 2011 12:56:57 -0700 (PDT)\r
+Received: from arlo.cworth.org (arlo.cworth.org [50.43.72.2])\r
+       by olra.theworths.org (Postfix) with ESMTP id 0A0B4431FB6\r
+       for <notmuch@notmuchmail.org>; Fri,  3 Jun 2011 12:56:57 -0700 (PDT)\r
+Received: from yoom.home.cworth.org (localhost [127.0.0.1])\r
+       by arlo.cworth.org (Postfix) with ESMTP id EA13D29A047;\r
+       Fri,  3 Jun 2011 12:56:55 -0700 (PDT)\r
+Received: by yoom.home.cworth.org (Postfix, from userid 1000)\r
+       id D96DB54C02C; Fri,  3 Jun 2011 12:56:55 -0700 (PDT)\r
+From: Carl Worth <cworth@cworth.org>\r
+To: Jameson Graef Rollins <jrollins@finestructure.net>,\r
+       Notmuch Mail <notmuch@notmuchmail.org>\r
+Subject: Re: [PATCH 25/25] Fix stdout stream grabbing in\r
+       format_part_content_text\r
+In-Reply-To: <1306619520-25730-26-git-send-email-jrollins@finestructure.net>\r
+References: <1306619520-25730-1-git-send-email-jrollins@finestructure.net>\r
+       <1306619520-25730-2-git-send-email-jrollins@finestructure.net>\r
+       <1306619520-25730-3-git-send-email-jrollins@finestructure.net>\r
+       <1306619520-25730-4-git-send-email-jrollins@finestructure.net>\r
+       <1306619520-25730-5-git-send-email-jrollins@finestructure.net>\r
+       <1306619520-25730-6-git-send-email-jrollins@finestructure.net>\r
+       <1306619520-25730-7-git-send-email-jrollins@finestructure.net>\r
+       <1306619520-25730-8-git-send-email-jrollins@finestructure.net>\r
+       <1306619520-25730-9-git-send-email-jrollins@finestructure.net>\r
+       <1306619520-25730-10-git-send-email-jrollins@finestructure.net>\r
+       <1306619520-25730-11-git-send-email-jrollins@finestructure.net>\r
+       <1306619520-25730-12-git-send-email-jrollins@finestructure.net>\r
+       <1306619520-25730-13-git-send-email-jrollins@finestructure.net>\r
+       <1306619520-25730-14-git-send-email-jrollins@finestructure.net>\r
+       <1306619520-25730-15-git-send-email-jrollins@finestructure.net>\r
+       <1306619520-25730-16-git-se nd-email-jrollins@finestructure.net>\r
+       <1306619520-25730-17-git-send-email-jrollins@finestructure.net>\r
+       <1306619520-25730-18-git-send-email-jrollins@finestructure.net>\r
+       <1306619520-25730-19-git-send-email-jrollins@finestructure.net>\r
+       <1306619520-25730-20-git-send-email-jrollins@finestructure.net>\r
+       <1306619520-25730-21-git-send-email-jrollins@finestructure.net>\r
+       <1306619520-25730-22-git-send-email-jrollins@finestructure.net>\r
+       <1306619520-25730-23-git-send-email-jrollins@finestructure.net>\r
+       <1306619520-25730-24-git-send-email-jrollins@finestructure.net>\r
+       <1306619520-25730-25-git-send-email-jrollins@finestructure.net>\r
+       <1306619520-25730-26-git-send-email-jrollins@finestructure.net>\r
+User-Agent: Notmuch/0.5 (http://notmuchmail.org) Emacs/23.3.1\r
+       (i486-pc-linux-gnu)\r
+Date: Fri, 03 Jun 2011 12:56:50 -0700\r
+Message-ID: <87r57almd9.fsf@yoom.home.cworth.org>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha1; protocol="application/pgp-signature"\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 03 Jun 2011 19:56:57 -0000\r
+\r
+--=-=-=\r
+Content-Type: text/plain; charset=utf-8\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+On Sat, 28 May 2011 14:52:00 -0700, Jameson Graef Rollins <jrollins@finestr=\r
+ucture.net> wrote:\r
+> The declaration of the GMimeStream pointer to stdout in\r
+> format_part_content_text was somehow preventing subsequent printf\r
+> calls from outputting to stdout if the output was redirected to a\r
+> file.  Scoping the declaration to the actual use of the stream pointer\r
+> works around this problem.\r
+\r
+This commit message sounds like we don't actually understand the problem\r
+being fixed here.\r
+\r
+I'd like to investigate this more. Perhaps with a test case?\r
+\r
+Otherwise, the patches up to this point in the thread have all either\r
+been pushed or I've asked for some additional information (perhaps\r
+that's just this patch and the "old style fcc dirs" patch?).\r
+\r
+I'll continue to work through my patch queue as contained in email\r
+messages. I'm finding it easier to do that (and just piping the patches\r
+I like to "git am") as opposed to working through a release-candidate\r
+branch in git, (and having to keep rebasing/postponing it after I reject\r
+some patch in the series).\r
+\r
+I'm actually a bit surprised to see myself preferring patches in\r
+email. When Linus first wrote git, I couldn't understand why the Linux\r
+community kept to such a consistent culture of sending patches via\r
+email. It seemed so backwards to do these awkward machinations (git\r
+format-patch, git send-email, SMTP, MUA, git am), and risk all the\r
+problems of email clients corrupting patches, etc.=E2=80=94especially when =\r
+git\r
+has such clean mechanisms for reliably moving patches around (git push,\r
+git pull).\r
+\r
+Call me converted. Email really is the right way to do collaborative\r
+code development.\r
+\r
+=2DCarl\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.11 (GNU/Linux)\r
+\r
+iEYEARECAAYFAk3pPIIACgkQ6JDdNq8qSWhPawCePe9T2KBadwP2rhfaY0aPqOVx\r
+OZQAn3b4zv8JccIp37uxcOOyEsPHS/xE\r
+=aA8X\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r