fe/6391deb1bb1eb4239b6ed2386f781560772194

   1 Return-Path: <amdragon@mit.edu>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id E6128431FD0\r
   6         for <notmuch@notmuchmail.org>; Thu, 10 Nov 2011 11:26:13 -0800 (PST)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.7\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
  12         tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
  13 Received: from olra.theworths.org ([127.0.0.1])\r
  14         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  15         with ESMTP id aaBu+ueT3PSk for <notmuch@notmuchmail.org>;\r
  16         Thu, 10 Nov 2011 11:26:13 -0800 (PST)\r
  17 Received: from dmz-mailsec-scanner-1.mit.edu (DMZ-MAILSEC-SCANNER-1.MIT.EDU\r
  18         [18.9.25.12])\r
  19         by olra.theworths.org (Postfix) with ESMTP id 65AD6431FB6\r
  20         for <notmuch@notmuchmail.org>; Thu, 10 Nov 2011 11:26:13 -0800 (PST)\r
  21 X-AuditID: 1209190c-b7f806d0000008d6-29-4ebc25526a4d\r
  22 Received: from mailhub-auth-3.mit.edu ( [18.9.21.43])\r
  23         by dmz-mailsec-scanner-1.mit.edu (Symantec Messaging Gateway) with SMTP\r
  24         id 1D.AD.02262.2552CBE4; Thu, 10 Nov 2011 14:26:10 -0500 (EST)\r
  25 Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
  26         by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id pAAJQ9G5030155; \r
  27         Thu, 10 Nov 2011 14:26:10 -0500\r
  28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
  29         (authenticated bits=0)\r
  30         (User authenticated as amdragon@ATHENA.MIT.EDU)\r
  31         by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id pAAJQ7B6021503\r
  32         (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
  33         Thu, 10 Nov 2011 14:26:08 -0500 (EST)\r
  34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
  35         (envelope-from <amdragon@mit.edu>)\r
  36         id 1ROaIe-0001h7-9K; Thu, 10 Nov 2011 14:28:36 -0500\r
  37 Date: Thu, 10 Nov 2011 14:28:36 -0500\r
  38 From: Austin Clements <amdragon@MIT.EDU>\r
  39 To: Jameson Graef Rollins <jrollins@finestructure.net>\r
  40 Subject: Re: [PATCH] test: Use env to set TMPDIR when running emacs in screen.\r
  41 Message-ID: <20111110192836.GN2658@mit.edu>\r
  42 References: <id:878vnomntf.fsf@servo.finestructure.net>\r
  43         <1320944375-29843-1-git-send-email-jrollins@finestructure.net>\r
  44 MIME-Version: 1.0\r
  45 Content-Type: text/plain; charset=us-ascii\r
  46 Content-Disposition: inline\r
  47 In-Reply-To: <1320944375-29843-1-git-send-email-jrollins@finestructure.net>\r
  48 User-Agent: Mutt/1.5.21 (2010-09-15)\r
  49 X-Brightmail-Tracker:\r
  50  H4sIAAAAAAAAA+NgFvrPIsWRmVeSWpSXmKPExsUixCmqrRukusfP4OBdGYs9+7wsrt+cyezA\r
  51         5HH3NJfHs1W3mAOYorhsUlJzMstSi/TtErgyJszcxVJwg7Pix+aZ7A2MZ9m7GDk5JARMJB5M\r
  52         O8UCYYtJXLi3ng3EFhLYxyjx4p1UFyMXkL2BUWLllDZ2iMRJJolpu4QgEksYJZafWcEMkmAR\r
  53         UJU48Gk1mM0moCGxbf9yRhBbRMBMoufLHzCbWUBLYuvGD2C2sICfxLxLc4C2cXDwCmhLHJgh\r
  54         BDG/QmLek3VgR/AKCEqcnPmEBab1xr+XTCDlzALSEsv/cYCEOQW8JQ707AQrFxVQkZhychvb\r
  55         BEahWUi6ZyHpnoXQvYCReRWjbEpulW5uYmZOcWqybnFyYl5eapGuoV5uZoleakrpJkZwOEvy\r
  56         7GB8c1DpEKMAB6MSDy/Xn91+QqyJZcWVuYcYJTmYlER5i5T2+AnxJeWnVGYkFmfEF5XmpBYf\r
  57         YpTgYFYS4eUWAcrxpiRWVqUW5cOkpDlYlMR5D+5w8BMSSE8sSc1OTS1ILYLJynBwKEnwTlAB\r
  58         ahQsSk1PrUjLzClBSDNxcIIM5wEavhekhre4IDG3ODMdIn+KUVFKnHcGSEIAJJFRmgfXC0s3\r
  59         rxjFgV4R5j0GUsUDTFVw3a+ABjMBDd7svhtkcEkiQkqqgdFa8oZfW5JNKMfJ5hkV0unNMbvb\r
  60         Cx7GLD/Dwpj2dF1GkTjT0/j/TFxmR+eIvJ6ax504M3j3V74PD03ZZe8UPjd99W6Ly6I/LtLJ\r
  61         JQs/78q9xyrk5yAiLDxhzfygtlf9JbyPjOTE95mYi984rN8kblanvXtphLSmjvd+G71l/zrK\r
  62         Ltv4l38XV2Ipzkg01GIuKk4EAEScCSoSAwAA\r
  63 Cc: Notmuch Mail <notmuch@notmuchmail.org>\r
  64 X-BeenThere: notmuch@notmuchmail.org\r
  65 X-Mailman-Version: 2.1.13\r
  66 Precedence: list\r
  67 List-Id: "Use and development of the notmuch mail system."\r
  68         <notmuch.notmuchmail.org>\r
  69 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  70         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  71 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  72 List-Post: <mailto:notmuch@notmuchmail.org>\r
  73 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  74 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  75         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  76 X-List-Received-Date: Thu, 10 Nov 2011 19:26:14 -0000\r
  77 \r
  78 This looks good to me, though it would be good to add a comment\r
  79 explaining why this dance is necessary.  Perhaps something along the\r
  80 lines of\r
  81 \r
  82 # The emacs server places its socket in TMPDIR, but ld.so unsets\r
  83 # TMPDIR when loading setgid binaries like screen, so we must\r
  84 # explicitly pass TMPDIR through to emacs.\r
  85 \r
  86 Quoth Jameson Graef Rollins on Nov 10 at  8:59 am:\r
  87 > This is to get around a bug where screen unsets TMPDIR.  This causes\r
  88 > problems for users who set TMPDIR to something other than it's default\r
  89 > (/tmp).\r
  90 > ---\r
  91 >  test/test-lib.sh |    4 +++-\r
  92 >  1 files changed, 3 insertions(+), 1 deletions(-)\r
  93 > \r
  94 > diff --git a/test/test-lib.sh b/test/test-lib.sh\r
  95 > index ff5183f..108537e 100755\r
  96 > --- a/test/test-lib.sh\r
  97 > +++ b/test/test-lib.sh\r
  98 > @@ -842,7 +842,9 @@ test_emacs () {\r
  99 >       if [ -z "$EMACS_SERVER" ]; then\r
 100 >               EMACS_SERVER="notmuch-test-suite-$$"\r
 101 >               # start a detached screen session with an emacs server\r
 102 > -             screen -S "$EMACS_SERVER" -d -m "$TMP_DIRECTORY/run_emacs" \\r
 103 > +             screen -S "$EMACS_SERVER" -d -m \\r
 104 > +                 env TMPDIR="$TMPDIR" \\r
 105 > +                 "$TMP_DIRECTORY/run_emacs" \\r
 106 >                       --no-window-system \\r
 107 >                       --eval "(setq server-name \"$EMACS_SERVER\")" \\r
 108 >                       --eval '(server-start)' \\r