1 Return-Path: <polatel@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 57EED429E21
\r
6 for <notmuch@notmuchmail.org>; Mon, 3 Oct 2011 22:00:57 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id ObkvdijT4pP8 for <notmuch@notmuchmail.org>;
\r
17 Mon, 3 Oct 2011 22:00:55 -0700 (PDT)
\r
18 Received: from mail-bw0-f53.google.com (mail-bw0-f53.google.com
\r
19 [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 44DDF431FB6
\r
22 for <notmuch@notmuchmail.org>; Mon, 3 Oct 2011 22:00:55 -0700 (PDT)
\r
23 Received: by bkbzt12 with SMTP id zt12so219887bkb.26
\r
24 for <notmuch@notmuchmail.org>; Mon, 03 Oct 2011 22:00:52 -0700 (PDT)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
\r
26 h=date:from:to:cc:subject:message-id:mail-followup-to:references
\r
27 :mime-version:content-type:content-disposition:in-reply-to
\r
28 :organization:user-agent;
\r
29 bh=Ar2oebMp8BGgQJh0R+0EHLbZRtU/g1EFG+n287Ciolg=;
\r
30 b=wrLrRiQlfuJx5IX8E7J+h8Y+qynpgYqZO6tmgXSeuRjG3l5r+asQ6O/kORFP/vFpjr
\r
31 wRXB2A+N93E081hVA+pOT9vIs9itnKqPbGpcD7cdSJ7hlMIgsEdPYtRf8FYDBaABYNxT
\r
32 M/1mSfrb3Oc7N94gUKgih+p1A8ilmjpgxh6E4=
\r
33 Received: by 10.223.56.67 with SMTP id x3mr1110418fag.64.1317704452312;
\r
34 Mon, 03 Oct 2011 22:00:52 -0700 (PDT)
\r
35 Received: from localhost ([88.236.39.101])
\r
36 by mx.google.com with ESMTPS id m26sm23996273fac.6.2011.10.03.22.00.50
\r
37 (version=TLSv1/SSLv3 cipher=OTHER);
\r
38 Mon, 03 Oct 2011 22:00:51 -0700 (PDT)
\r
39 Date: Tue, 4 Oct 2011 08:00:46 +0300
\r
40 From: Ali Polatel <polatel@gmail.com>
\r
41 To: David Bremner <david@tethera.net>
\r
42 Subject: Re: [PATCH] lib: make find_message{,by_filename) report errors
\r
43 Message-ID: <20111004050046.GA6048@hayalet>
\r
44 Mail-Followup-To: David Bremner <david@tethera.net>,
\r
45 Austin Clements <amdragon@MIT.EDU>,
\r
46 Notmuch Mailing List <notmuch@notmuchmail.org>
\r
47 References: <20110930064712.GA30012@hayalet>
\r
48 <cover.1317456435.git.alip@exherbo.org>
\r
49 <8739f9muhp.fsf@zancas.localnet>
\r
51 Content-Type: multipart/signed; micalg=pgp-sha1;
\r
52 protocol="application/pgp-signature"; boundary="opJtzjQTFsWo+cga"
\r
53 Content-Disposition: inline
\r
54 In-Reply-To: <8739f9muhp.fsf@zancas.localnet>
\r
55 Organization: Pink Floyd
\r
56 User-Agent: Mutt/1.5.21 (2010-09-15)
\r
57 Cc: Notmuch Mailing List <notmuch@notmuchmail.org>,
\r
58 Austin Clements <amdragon@MIT.EDU>
\r
59 X-BeenThere: notmuch@notmuchmail.org
\r
60 X-Mailman-Version: 2.1.13
\r
62 List-Id: "Use and development of the notmuch mail system."
\r
63 <notmuch.notmuchmail.org>
\r
64 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
65 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
66 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
67 List-Post: <mailto:notmuch@notmuchmail.org>
\r
68 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
69 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
70 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
71 X-List-Received-Date: Tue, 04 Oct 2011 05:00:57 -0000
\r
75 Content-Type: text/plain; charset=utf-8; format=flowed
\r
76 Content-Disposition: inline
\r
77 Content-Transfer-Encoding: quoted-printable
\r
79 David Bremner yazm=C4=B1=C5=9F:
\r
80 >On Sat, 1 Oct 2011 11:12:23 +0300, Ali Polatel <polatel@gmail.com> wrote:
\r
81 >> From: Ali Polatel <alip@exherbo.org>
\r
83 >> Looks like the patch did not make it correctly the first time.
\r
84 >> Resending using git-send-email=E2=84=A2
\r
86 >> You may also find the commit in my notmuch repository:
\r
87 >> git://github.com/alip/notmuch.git branch: find_message
\r
92 >Thanks for reworking this patch. I looked at branch find_message-v2
\r
93 >in your repo. I have a few comments.
\r
95 Thanks for going over the patch, expect a new set of patches soon!
\r
97 >- In the comments for _resolve_message_id_to_thread_id I guess thread_id
\r
98 > should be thread_id_ret?
\r
102 >- in notmuch_database_find_message_by_file_name, I'm not sure why you
\r
103 > set status to NOTMUCH_STATUS_OUT_OF_MEMORY in the catch block. Is this
\r
106 Looks like a copy & paste error. I must have blindly copied the error
\r
107 =66rom the previous block. Fixed.
\r
109 >- after the DONE: label of the same routine, how is *message_ret destroyed?
\r
110 > does it need to wait until the talloc context "notmuch" is freed?
\r
112 Yes, I have modified it to call notmuch_message_destroy() in case
\r
113 '*message_ret' is non-NULL after the DONE:
\r
115 >- I don't really get the change of user to caller around notmuch.h:286
\r
116 > It is not a big deal, but I guess we should try to be consistent.
\r
118 I don't get what you mean by consistency here but this hunk is unrelated
\r
119 to the problem which the patch is trying to address.
\r
129 Content-Type: application/pgp-signature
\r
131 -----BEGIN PGP SIGNATURE-----
\r
132 Version: GnuPG v2.0.18 (GNU/Linux)
\r
134 iEYEARECAAYFAk6Kkv4ACgkQQU4yORhF8iBInwCgpop38ePUu3GYNOvodxl1vXZ6
\r
135 u7EAn0lJf4uTgDGLVa0oi0R/003RSm21
\r
137 -----END PGP SIGNATURE-----
\r
139 --opJtzjQTFsWo+cga--
\r