1 Return-Path: <jani@nikula.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 4A0E4431FB6
\r
6 for <notmuch@notmuchmail.org>; Tue, 4 Sep 2012 13:30:47 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id 2fXUbiyCPCS4 for <notmuch@notmuchmail.org>;
\r
16 Tue, 4 Sep 2012 13:30:46 -0700 (PDT)
\r
17 Received: from mail-lb0-f181.google.com (mail-lb0-f181.google.com
\r
18 [209.85.217.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 6072F431FAF
\r
21 for <notmuch@notmuchmail.org>; Tue, 4 Sep 2012 13:30:46 -0700 (PDT)
\r
22 Received: by lbbgk1 with SMTP id gk1so3816391lbb.26
\r
23 for <notmuch@notmuchmail.org>; Tue, 04 Sep 2012 13:30:43 -0700 (PDT)
\r
24 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
\r
25 d=google.com; s=20120113;
\r
26 h=from:to:subject:in-reply-to:references:user-agent:date:message-id
\r
27 :mime-version:content-type:x-gm-message-state;
\r
28 bh=H41GEVVL4O1BCFuH6Lp91oDzRfECEuPIs7im2Xs1YyY=;
\r
29 b=d/7BEJSMxnHZgZ2D7RJXXzKLAZLfbZ2CuztKH0I46+f9v8H+awjLNseFqibUSTLVLk
\r
30 72ijYDA+A2gESxjsmeEXqqd7TcRyU3w7EseBARPWl0fDyMCowJEiURR9CwFCGvYt/n0n
\r
31 sGHsZjH95KHOSpCVmW9oH4422IhS/4EUy0q2Iqr9BCpLUy7bmDZZu2tMLi46YeRZpML1
\r
32 n5RfJoCJ/JLbNVxm/BuyzqPkW3EmwCKL1C+oC6YEQjlDUEi2Bs9/BfOYP0gvw1i6h+ou
\r
33 XVBjhhosa43STF1FHw1U2Lh//Gzs5iWz9VY6PBq4i2MefSREqhrymtNpg7f5Kd9X54oG
\r
35 Received: by 10.112.88.6 with SMTP id bc6mr6984061lbb.131.1346790643517;
\r
36 Tue, 04 Sep 2012 13:30:43 -0700 (PDT)
\r
37 Received: from localhost (dsl-hkibrasgw4-fe51df00-27.dhcp.inet.fi.
\r
39 by mx.google.com with ESMTPS id nf5sm17475806lab.3.2012.09.04.13.30.41
\r
40 (version=SSLv3 cipher=OTHER); Tue, 04 Sep 2012 13:30:42 -0700 (PDT)
\r
41 From: Jani Nikula <jani@nikula.org>
\r
42 To: Michal Sojka <sojkam1@fel.cvut.cz>, notmuch@notmuchmail.org
\r
43 Subject: Re: [PATCH v2 0/5] emacs: notmuch-hello status message refresh hook,
\r
45 In-Reply-To: <87vcftbtmw.fsf@steelpick.2x.cz>
\r
46 References: <cover.1346596156.git.jani@nikula.org>
\r
47 <87vcftbtmw.fsf@steelpick.2x.cz>
\r
48 User-Agent: Notmuch/0.14+41~g76f353e (http://notmuchmail.org) Emacs/23.3.1
\r
50 Date: Tue, 04 Sep 2012 23:30:39 +0300
\r
51 Message-ID: <877gs9msy8.fsf@nikula.org>
\r
53 Content-Type: text/plain; charset=us-ascii
\r
55 ALoCoQkrQlqE0LmaBrNH/JXO8uDI1MIoBuK9UHX8kbmhYuhahBnt8vxrSutpsNIAJMwIJqsVZu53
\r
56 X-BeenThere: notmuch@notmuchmail.org
\r
57 X-Mailman-Version: 2.1.13
\r
59 List-Id: "Use and development of the notmuch mail system."
\r
60 <notmuch.notmuchmail.org>
\r
61 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
62 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
63 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
64 List-Post: <mailto:notmuch@notmuchmail.org>
\r
65 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
66 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
67 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
68 X-List-Received-Date: Tue, 04 Sep 2012 20:30:47 -0000
\r
70 On Tue, 04 Sep 2012, Michal Sojka <sojkam1@fel.cvut.cz> wrote:
\r
71 > On Sun, Sep 02 2012, Jani Nikula wrote:
\r
72 >> Hi all, v2 of [1] addressing review comments: added NEWS, improved
\r
73 >> documentation, made the query customizable.
\r
76 >> id:"37899e28dbf67e4620a53279a869be3174c02d6f.1339775602.git.jani@nikula.org"
\r
80 > if I understand correctly, the goal of this patchset is to display the
\r
81 > message with the difference in the number of messages before and after
\r
82 > refresh of notmuch-hello.
\r
84 Difference between two refreshes of notmuch-hello to be specific.
\r
86 > I think the current implementation is unnecessarily complicated. It
\r
87 > would be sufficient to implement this directly in `notmuch-hello'
\r
88 > without any hook. If `notmuch-hello-refresh-status-query' is nil
\r
89 > (default) no message would be shown. If it is configured to something
\r
90 > else, the message would be shown provided that no-display is nil. This
\r
91 > way you don't have to break existing user's hooks and achieve the same
\r
92 > behavior, don't you?
\r
94 I think it would be useful to pass no-display to hooks anyway,
\r
95 regardless of the use here. I don't see that as a big reason to do this
\r
96 one way or the other. Having this implemented directly in notmuch-hello
\r
97 does not make this less complicated either. The only difference would be
\r
98 having an if clause within notmuch-hello rather than an option in
\r
99 notmuch-hello-refresh-hook.
\r
101 This leaves us the matter of style. Tomi also expressed preference for
\r
102 having this built-in to notmuch-hello rather than as a hook. I like
\r
103 having it as a hook for a number of reasons:
\r
105 * I think it provides a nice abstract interface without messing with the
\r
106 rest of notmuch-hello.
\r
108 * I think toggling hooks on and off in the customization interface is
\r
109 nice (see e.g. notmuch-show-insert-text/plain-hook under
\r
110 notmuch-show). No need to add more and more customizations for things
\r
111 that can be options.
\r
113 * If the user doesn't like the messages, it's easy to copy-paste the
\r
114 code to .emacs, modify, and add-hook.
\r
116 * It serves as an example of what can be done in the notmuch-hello
\r
119 If you and Tomi still insist on not having this as a hook, changing it
\r
120 is not a big deal (faster than writing this email *sigh*). But even then
\r
121 I'd propose merging patches 1-3 as those allow the user to write the
\r
122 kind of hook he chooses.
\r