1 Return-Path: <blakej@foo.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 714EE431FAF
\r
6 for <notmuch@notmuchmail.org>; Sun, 4 Nov 2012 07:40:53 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id BJ6begFmNFiN for <notmuch@notmuchmail.org>;
\r
16 Sun, 4 Nov 2012 07:40:53 -0800 (PST)
\r
17 Received: from foo.net (70-36-235-136.dsl.static.sonic.net [70.36.235.136])
\r
18 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id D9553431FAE
\r
21 for <notmuch@notmuchmail.org>; Sun, 4 Nov 2012 07:40:52 -0800 (PST)
\r
22 Received: from foo.net (localhost [127.0.0.1])
\r
23 by foo.net (8.14.5+Sun/8.14.5) with ESMTP id qA4FeonJ012350;
\r
24 Sun, 4 Nov 2012 07:40:50 -0800 (PST)
\r
25 To: Jani Nikula <jani@nikula.org>
\r
26 Subject: Re: [PATCH 10/10] timegm: add portable implementation (Solaris
\r
28 In-Reply-To: Your message of "Sun, 04 Nov 2012 12:21:01 +0200."
\r
29 <CAB+hUn-HBMnbrxQtn4E1RkKJa-wUEvm2HbdvtDxJGrv3jmtQdw@mail.gmail.com>
\r
30 Date: Sun, 04 Nov 2012 07:40:50 -0800
\r
31 Message-ID: <12349.1352043650@foo.net>
\r
32 From: Blake Jones <blakej@foo.net>
\r
33 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0.2
\r
34 (foo.net [127.0.0.1]); Sun, 04 Nov 2012 07:40:50 -0800 (PST)
\r
35 X-Mailman-Approved-At: Sun, 04 Nov 2012 13:36:08 -0800
\r
36 Cc: notmuch@notmuchmail.org
\r
37 X-BeenThere: notmuch@notmuchmail.org
\r
38 X-Mailman-Version: 2.1.13
\r
40 List-Id: "Use and development of the notmuch mail system."
\r
41 <notmuch.notmuchmail.org>
\r
42 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
43 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
44 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
45 List-Post: <mailto:notmuch@notmuchmail.org>
\r
46 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
47 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
48 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
49 X-List-Received-Date: Sun, 04 Nov 2012 15:40:53 -0000
\r
53 > I'd prefer to use timegm() where available, and the suggested
\r
54 > alternative [1] elsewhere.
\r
56 > [1] http://www.kernel.org/doc/man-pages/online/pages/man3/timegm.3.html
\r
58 I considered this alternative, but decided against it because it's
\r
59 completely MT-unsafe. I don't know whether libnotmuch itself is
\r
60 MT-safe, but a process which called this routine in one thread would
\r
61 temporarily throw off any timezone-related work that any other threads
\r
62 were doing, even if they weren't using libnotmuch.
\r
64 > I'll look into the compat build issues when I have a moment.
\r
66 If you do, here's a boiled-down version of the problem that I came up
\r
67 with while investigating it:
\r
69 $ echo 'int main() { extern int foo1(); return foo1(); }' > main.c
\r
70 $ echo 'int foo1() { extern int bar(); return bar(); }' > foo1.c
\r
71 $ echo 'int bar() { extern int foo2(); return foo2(); }' > bar.c
\r
72 $ echo 'int foo2() { return 0; }' > foo2.c
\r
73 $ gcc -c main.c foo1.c bar.c foo2.c
\r
74 $ ar rcs libfoo.a foo1.o foo2.o
\r
75 $ ar rcs libbar.a bar.o
\r
76 $ gcc -o main main.o libfoo.a libbar.a
\r
78 $ gcc -o main main.o libbar.a libfoo.a
\r
81 Another alternative would be to just include parse-time-string.o in
\r
82 libnotmuch.a directly; I think that would solve the problem.
\r