1 Return-Path: <jani@nikula.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id BBF08431FBC
\r
6 for <notmuch@notmuchmail.org>; Thu, 17 Oct 2013 07:10:54 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id ZBYKJx5tbolU for <notmuch@notmuchmail.org>;
\r
16 Thu, 17 Oct 2013 07:10:50 -0700 (PDT)
\r
17 Received: from mail-ee0-f43.google.com (mail-ee0-f43.google.com
\r
18 [74.125.83.43]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client
\r
19 certificate requested) by olra.theworths.org (Postfix) with ESMTPS id
\r
20 303FA431FAE for <notmuch@notmuchmail.org>; Thu, 17 Oct 2013 07:10:50 -0700
\r
22 Received: by mail-ee0-f43.google.com with SMTP id e52so1091194eek.2
\r
23 for <notmuch@notmuchmail.org>; Thu, 17 Oct 2013 07:10:48 -0700 (PDT)
\r
24 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
\r
25 d=1e100.net; s=20130820;
\r
26 h=x-gm-message-state:from:to:subject:in-reply-to:references
\r
27 :user-agent:date:message-id:mime-version:content-type;
\r
28 bh=IEd07YvC21rUK0zF1Ybv7Rw0CPN9UjKb4AQ4vsQ1Gco=;
\r
29 b=BlGh7tEaTJophZiUtoJTDqE2TQail3U1v1eUjA5t4MKAUeKD8uv6j06uXdQI3TWHau
\r
30 l0FxJGTZsry1bMp8IyoWbs4nlV7jqK840Iz7renJVW4EUqooqjyMWuJjlO8ffC76ydrH
\r
31 Eaco+B5nwaI/xkCyjsMSh/dg/i8LsDrgv0n78IdqOy262XX3366BXIJefQAqmHdzMqDa
\r
32 mW4BPqctzjBpERrLvu6nLUTyC5YLfnt7WEgT/2zvViJJIUfIKsmUg24vLuEQmnIVPaeT
\r
33 kutjhK3fLLjb0mizCtkF0bqj5lH65qVNKuaoUDqkblPmDPJFeiNgc8kOjdSklv3+1Y/+
\r
36 ALoCoQkibq6HsyeQr3JbiffPQYfA7L4xksl7blcZ1HLdfLfTDBKFvu++F8TH2FO/pa2/m3aGc5Rx
\r
37 X-Received: by 10.15.22.2 with SMTP id e2mr2128781eeu.89.1382018595820;
\r
38 Thu, 17 Oct 2013 07:03:15 -0700 (PDT)
\r
39 Received: from localhost (dsl-hkibrasgw2-58c36f-91.dhcp.inet.fi.
\r
40 [88.195.111.91]) by mx.google.com with ESMTPSA id
\r
41 r48sm193385379eev.14.1969.12.31.16.00.00
\r
42 (version=TLSv1.2 cipher=RC4-SHA bits=128/128);
\r
43 Thu, 17 Oct 2013 07:03:14 -0700 (PDT)
\r
44 From: Jani Nikula <jani@nikula.org>
\r
45 To: Moritz Wilhelmy <mw+notmuch@barfooze.de>, notmuch@notmuchmail.org
\r
46 Subject: Re: [PATCH 3/6] cli: make the hacky from guessing more liberal
\r
47 In-Reply-To: <20131017135804.GH49348@barfooze.de>
\r
48 References: <cover.1381948853.git.jani@nikula.org>
\r
49 <7dd03cd9c1677be8c5937d11b376d4cbd26c64f5.1381948853.git.jani@nikula.org>
\r
50 <20131017135804.GH49348@barfooze.de>
\r
51 User-Agent: Notmuch/0.16+97~g6878b0b (http://notmuchmail.org) Emacs/24.3.1
\r
52 (x86_64-pc-linux-gnu)
\r
53 Date: Thu, 17 Oct 2013 17:03:14 +0300
\r
54 Message-ID: <87eh7kuh99.fsf@nikula.org>
\r
56 Content-Type: text/plain
\r
57 X-BeenThere: notmuch@notmuchmail.org
\r
58 X-Mailman-Version: 2.1.13
\r
60 List-Id: "Use and development of the notmuch mail system."
\r
61 <notmuch.notmuchmail.org>
\r
62 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
63 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
64 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
65 List-Post: <mailto:notmuch@notmuchmail.org>
\r
66 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
67 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
68 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
69 X-List-Received-Date: Thu, 17 Oct 2013 14:10:54 -0000
\r
71 On Thu, 17 Oct 2013, Moritz Wilhelmy <mw+notmuch@barfooze.de> wrote:
\r
74 > On Wed, Oct 16, 2013 at 22:00:10 +0300, Jani Nikula wrote:
\r
75 >> This is in preparation of switching to gmime header parsing. Accept
\r
76 >> "for" and "by" preceded by tabs in the received header. This is a bit
\r
77 >> flaky, but so is the whole guessing code.
\r
79 >> notmuch-reply.c | 4 ++--
\r
80 >> 1 file changed, 2 insertions(+), 2 deletions(-)
\r
82 >> diff --git a/notmuch-reply.c b/notmuch-reply.c
\r
83 >> index 9d6f843..4b67e66 100644
\r
84 >> --- a/notmuch-reply.c
\r
85 >> +++ b/notmuch-reply.c
\r
86 >> @@ -423,7 +423,7 @@ guess_from_received_header (notmuch_config_t *config, notmuch_message_t *message
\r
87 >> /* First we look for a " for <email@add.res>" in the received
\r
90 >> - ptr = strstr (received, " for ");
\r
91 >> + ptr = strstr (received, "for ");
\r
93 >> /* Note: ptr potentially contains a list of email addresses. */
\r
94 >> addr = user_address_in_string (ptr, config);
\r
95 >> @@ -440,7 +440,7 @@ guess_from_received_header (notmuch_config_t *config, notmuch_message_t *message
\r
96 >> * system in this step of the receive chain
\r
99 >> - while((by = strstr (by, " by ")) != NULL) {
\r
100 >> + while((by = strstr (by, "by ")) != NULL) {
\r
103 > FWIW, I didn't read the rest of the code, but shouldn't the last line
\r
104 > be changed to "by += 3" when you're dropping a space from the strstr?
\r
106 Absolutely, same in the "for" case. Thanks.
\r
116 > _______________________________________________
\r
117 > notmuch mailing list
\r
118 > notmuch@notmuchmail.org
\r
119 > http://notmuchmail.org/mailman/listinfo/notmuch
\r