1 Return-Path: <jani@nikula.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 26E43431FBC
\r
6 for <notmuch@notmuchmail.org>; Tue, 14 Feb 2012 08:56:15 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id jTw2o3Ggiwno for <notmuch@notmuchmail.org>;
\r
16 Tue, 14 Feb 2012 08:56:11 -0800 (PST)
\r
17 Received: from mail-lpp01m010-f53.google.com (mail-lpp01m010-f53.google.com
\r
18 [209.85.215.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 1E0E1431FAF
\r
21 for <notmuch@notmuchmail.org>; Tue, 14 Feb 2012 08:56:10 -0800 (PST)
\r
22 Received: by lahd3 with SMTP id d3so162656lah.26
\r
23 for <notmuch@notmuchmail.org>; Tue, 14 Feb 2012 08:56:08 -0800 (PST)
\r
24 Received: by 10.112.103.228 with SMTP id fz4mr4257616lbb.99.1329238567995;
\r
25 Tue, 14 Feb 2012 08:56:07 -0800 (PST)
\r
26 Received: from localhost (dsl-hkibrasgw4-fe50f800-253.dhcp.inet.fi.
\r
28 by mx.google.com with ESMTPS id mc3sm16688007lab.12.2012.02.14.08.56.05
\r
29 (version=SSLv3 cipher=OTHER); Tue, 14 Feb 2012 08:56:06 -0800 (PST)
\r
30 From: Jani Nikula <jani@nikula.org>
\r
31 To: Michal Sojka <sojka@os.inf.tu-dresden.de>, notmuch@notmuchmail.org
\r
32 Subject: Re: [PATCH] emacs: Fix display of highlighted line in notmuch-show
\r
33 In-Reply-To: <1329215056-25753-1-git-send-email-sojka@os.inf.tu-dresden.de>
\r
34 References: <1329215056-25753-1-git-send-email-sojka@os.inf.tu-dresden.de>
\r
35 User-Agent: Notmuch/0.11.1+182~g79d6dde (http://notmuchmail.org) Emacs/23.3.1
\r
37 Date: Tue, 14 Feb 2012 18:56:03 +0200
\r
38 Message-ID: <87mx8lpd5o.fsf@nikula.org>
\r
40 Content-Type: text/plain; charset=us-ascii
\r
42 ALoCoQlUcOECeeQzDYQu4vUhSEUQvF/uju548FODJyaFxFn3iK7bzWiOfnFTcilgR8Cp4ZlDNvIV
\r
43 Cc: Michal Sojka <sojka@os.inf.tu-dresden.de>
\r
44 X-BeenThere: notmuch@notmuchmail.org
\r
45 X-Mailman-Version: 2.1.13
\r
47 List-Id: "Use and development of the notmuch mail system."
\r
48 <notmuch.notmuchmail.org>
\r
49 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
50 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
51 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
52 List-Post: <mailto:notmuch@notmuchmail.org>
\r
53 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
54 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
55 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
56 X-List-Received-Date: Tue, 14 Feb 2012 16:56:15 -0000
\r
58 On Tue, 14 Feb 2012 11:24:16 +0100, Michal Sojka <sojka@os.inf.tu-dresden.de> wrote:
\r
59 > When notmuch-search-line-faces is used to set background color in search
\r
60 > results, the highlight of the current line is not always displayed
\r
61 > correctly. This patch fixes that by increasing the priority property of
\r
62 > the highlight overlay.
\r
64 One nitpick: The subject line refers to notmuch-show.
\r
70 > emacs/notmuch.el | 15 +++++++++++----
\r
71 > 1 files changed, 11 insertions(+), 4 deletions(-)
\r
73 > diff --git a/emacs/notmuch.el b/emacs/notmuch.el
\r
74 > index 5b4f1c5..f851c6f 100644
\r
75 > --- a/emacs/notmuch.el
\r
76 > +++ b/emacs/notmuch.el
\r
77 > @@ -249,10 +249,17 @@ For a mouse binding, return nil."
\r
78 > (set-buffer-modified-p nil)
\r
79 > (view-buffer (current-buffer) 'kill-buffer-if-not-modified))))
\r
81 > -(defcustom notmuch-search-hook '(hl-line-mode)
\r
82 > +(require 'hl-line)
\r
84 > +(defun notmuch-hl-line-mode ()
\r
85 > + (prog1 (hl-line-mode)
\r
86 > + (when hl-line-overlay
\r
87 > + (overlay-put hl-line-overlay 'priority 1))))
\r
89 > +(defcustom notmuch-search-hook '(notmuch-hl-line-mode)
\r
90 > "List of functions to call when notmuch displays the search results."
\r
92 > - :options '(hl-line-mode)
\r
93 > + :options '(notmuch-hl-line-mode)
\r
94 > :group 'notmuch-search
\r
95 > :group 'notmuch-hooks)
\r
97 > @@ -567,7 +574,7 @@ a list of strings of the form \"+TAG\" or \"-TAG\".
\r
98 > the messages that are about to be tagged"
\r
101 > - :options '(hl-line-mode)
\r
102 > + :options '(notmuch-hl-line-mode)
\r
103 > :group 'notmuch-hooks)
\r
105 > (defcustom notmuch-after-tag-hook nil
\r
106 > @@ -578,7 +585,7 @@ a list of strings of the form \"+TAG\" or \"-TAG\".
\r
107 > 'query' will be a string containing the search query that determines
\r
108 > the messages that were tagged"
\r
110 > - :options '(hl-line-mode)
\r
111 > + :options '(notmuch-hl-line-mode)
\r
112 > :group 'notmuch-hooks)
\r
114 > (defun notmuch-search-set-tags (tags)
\r
118 > _______________________________________________
\r
119 > notmuch mailing list
\r
120 > notmuch@notmuchmail.org
\r
121 > http://notmuchmail.org/mailman/listinfo/notmuch
\r