1 Return-Path: <tomi.ollila@nixu.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 82CC1429E35
\r
6 for <notmuch@notmuchmail.org>; Tue, 17 Jan 2012 04:48:39 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id 7z-9RlAimlUy for <notmuch@notmuchmail.org>;
\r
16 Tue, 17 Jan 2012 04:48:37 -0800 (PST)
\r
17 Received: from mail-gw3.nixu.fi (mail-gw3.nixu.fi [193.209.237.7])
\r
18 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 6FB3B429E2F
\r
21 for <notmuch@notmuchmail.org>; Tue, 17 Jan 2012 04:48:37 -0800 (PST)
\r
22 Received: from pps.filterd (mail-gw3 [127.0.0.1])
\r
23 by mail-gw3.nixu.fi (8.14.4/8.14.4) with SMTP id q0HCljvM012427;
\r
24 Tue, 17 Jan 2012 14:48:35 +0200
\r
25 Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31])
\r
26 by mail-gw3.nixu.fi with ESMTP id 114cs17tdf-1
\r
27 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);
\r
28 Tue, 17 Jan 2012 14:48:35 +0200
\r
29 Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31])
\r
30 by taco2.nixu.fi (8.14.3/8.14.3/Debian-5+lenny1) with ESMTP id
\r
31 q0HCmY9n001667; Tue, 17 Jan 2012 14:48:35 +0200
\r
32 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
33 To: Thomas Jost <schnouki@schnouki.net>, notmuch@notmuchmail.org
\r
34 Subject: Re: [PATCH v2 2/2] Add pseudo-compatibility with gmime 2.6
\r
35 In-Reply-To: <1326797453-9405-2-git-send-email-schnouki@schnouki.net>
\r
36 References: <8739bea9lc.fsf@thor.loria.fr>
\r
37 <1326797453-9405-1-git-send-email-schnouki@schnouki.net>
\r
38 <1326797453-9405-2-git-send-email-schnouki@schnouki.net>
\r
39 User-Agent: Notmuch/0.11+64~g42e8f66 (http://notmuchmail.org) Emacs/23.3.1
\r
41 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
42 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
43 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
44 Date: Tue, 17 Jan 2012 14:48:34 +0200
\r
45 Message-ID: <yf6lip65wbh.fsf@taco2.nixu.fi>
\r
47 Content-Type: text/plain; charset=us-ascii
\r
48 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.5.7110,
\r
49 1.0.211, 0.0.0000 definitions=2012-01-17_02:2012-01-17, 2012-01-17,
\r
50 1970-01-01 signatures=0
\r
51 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0
\r
52 ipscore=0 suspectscore=3
\r
53 phishscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0
\r
55 scancount=1 engine=6.0.2-1012030000 definitions=main-1201170076
\r
56 X-BeenThere: notmuch@notmuchmail.org
\r
57 X-Mailman-Version: 2.1.13
\r
59 List-Id: "Use and development of the notmuch mail system."
\r
60 <notmuch.notmuchmail.org>
\r
61 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
62 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
63 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
64 List-Post: <mailto:notmuch@notmuchmail.org>
\r
65 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
66 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
67 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
68 X-List-Received-Date: Tue, 17 Jan 2012 12:48:39 -0000
\r
70 On Tue, 17 Jan 2012 11:50:53 +0100, Thomas Jost <schnouki@schnouki.net> wrote:
\r
71 > There are lots of API changes in gmime 2.6 crypto handling. By adding
\r
72 > preprocessor directives, it is however possible to add gmime 2.6 compatibility
\r
73 > while preserving compatibility with gmime 2.4 too.
\r
75 > This is mostly based on id:"8762i8hrb9.fsf@bookbinder.fernseed.info".
\r
77 > This was tested against both gmime 2.6.4 and 2.4.31. With gmime 2.4.31, the
\r
78 > crypto tests all work fine (as expected). With gmime 2.6.4, one crypto test
\r
79 > fails (signature verification with signer key unavailable) but this will be hard
\r
80 > to fix since the new API does not report the reason why a signature verification
\r
81 > fails (other than the human-readable error message).
\r
84 LGTM. Some whitespace things but most of those were there already;
\r
85 I'd have one uncrustify round to be applied to the source and after
\r
86 that be more strict about those...
\r
88 actually gmime 2.4 has GMIME_CHECK_VERSION defined as
\r
89 g_mime_check_version (major, minor, micro) so the comment about it
\r
90 is not entirely accurate (it is unusable in our context, though)
\r