1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 177C8431FBC
\r
6 for <notmuch@notmuchmail.org>; Mon, 18 Aug 2014 10:25:00 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id 3lz49LhVpfnW for <notmuch@notmuchmail.org>;
\r
16 Mon, 18 Aug 2014 10:24:52 -0700 (PDT)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 9499F431FAE
\r
19 for <notmuch@notmuchmail.org>; Mon, 18 Aug 2014 10:24:52 -0700 (PDT)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id A01B61000C1;
\r
22 Mon, 18 Aug 2014 20:24:33 +0300 (EEST)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
\r
25 Subject: Re: [PATCH] completion: fail silently if _init_completion is not
\r
27 In-Reply-To: <1408379601-31994-1-git-send-email-jani@nikula.org>
\r
28 References: <1408379601-31994-1-git-send-email-jani@nikula.org>
\r
29 User-Agent: Notmuch/0.18.1+76~g581776d (http://notmuchmail.org) Emacs/24.3.1
\r
30 (x86_64-unknown-linux-gnu)
\r
31 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
32 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
33 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
34 Date: Mon, 18 Aug 2014 20:24:33 +0300
\r
35 Message-ID: <m27g25r9ri.fsf@guru.guru-group.fi>
\r
37 Content-Type: text/plain
\r
38 X-BeenThere: notmuch@notmuchmail.org
\r
39 X-Mailman-Version: 2.1.13
\r
41 List-Id: "Use and development of the notmuch mail system."
\r
42 <notmuch.notmuchmail.org>
\r
43 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
44 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
45 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
46 List-Post: <mailto:notmuch@notmuchmail.org>
\r
47 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
48 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
49 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
50 X-List-Received-Date: Mon, 18 Aug 2014 17:25:00 -0000
\r
52 On Mon, Aug 18 2014, Jani Nikula <jani@nikula.org> wrote:
\r
54 > The completion script depends on bash-completion 1.90 or later, with
\r
55 > _init_completion function. If that's not present, for some reason, the
\r
56 > completion currently fails with an ugly message, messing up user's
\r
59 > $ notmuch -bash: _init_completion: command not found
\r
61 > It's better to just not complete
\r
71 > This is probably unnecessary since
\r
73 > commit aff5af582ecbacb4004ad306c6ef463d61f1ed3a
\r
74 > Author: Jani Nikula <jani@nikula.org>
\r
75 > Date: Sun Feb 2 18:47:57 2014 +0200
\r
77 > configure: only install bash completion if supported
\r
79 > but should not do harm.
\r
81 > completion/notmuch-completion.bash | 4 ++++
\r
82 > 1 file changed, 4 insertions(+)
\r
84 > diff --git a/completion/notmuch-completion.bash b/completion/notmuch-completion.bash
\r
85 > index d88c5e7d965e..0571dc9da8e3 100644
\r
86 > --- a/completion/notmuch-completion.bash
\r
87 > +++ b/completion/notmuch-completion.bash
\r
88 > @@ -395,6 +395,10 @@ _notmuch()
\r
90 > local _notmuch_commands="compact config count dump help insert new reply restore search setup show tag"
\r
91 > local arg cur prev words cword split
\r
93 > + # require bash-completion with _init_completion
\r
94 > + type -t _init_completion >/dev/null 2>&1 || return
\r
96 > _init_completion || return
\r
102 > _______________________________________________
\r
103 > notmuch mailing list
\r
104 > notmuch@notmuchmail.org
\r
105 > http://notmuchmail.org/mailman/listinfo/notmuch
\r