1 Return-Path: <sojka@os.inf.tu-dresden.de>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 0DB1C431FD0
\r
6 for <notmuch@notmuchmail.org>; Thu, 24 Nov 2011 07:43:50 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id rOpzhdVyLaWb for <notmuch@notmuchmail.org>;
\r
16 Thu, 24 Nov 2011 07:43:49 -0800 (PST)
\r
17 Received: from max.feld.cvut.cz (max.feld.cvut.cz [147.32.192.36])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 2E02C431FB6
\r
19 for <notmuch@notmuchmail.org>; Thu, 24 Nov 2011 07:43:49 -0800 (PST)
\r
20 Received: from localhost (unknown [192.168.200.4])
\r
21 by max.feld.cvut.cz (Postfix) with ESMTP id 7A6CA3CFE73;
\r
22 Thu, 24 Nov 2011 16:43:48 +0100 (CET)
\r
23 X-Virus-Scanned: IMAP AMAVIS
\r
24 Received: from max.feld.cvut.cz ([192.168.200.1])
\r
25 by localhost (styx.feld.cvut.cz [192.168.200.4]) (amavisd-new,
\r
27 with ESMTP id 04nX+2nSBiBP; Thu, 24 Nov 2011 16:43:47 +0100 (CET)
\r
28 Received: from imap.feld.cvut.cz (imap.feld.cvut.cz [147.32.192.34])
\r
29 by max.feld.cvut.cz (Postfix) with ESMTP id 7B75F3CFE71;
\r
30 Thu, 24 Nov 2011 16:43:47 +0100 (CET)
\r
31 Received: from steelpick.2x.cz (unknown [141.76.49.23])
\r
32 (Authenticated sender: sojkam1)
\r
33 by imap.feld.cvut.cz (Postfix) with ESMTPSA id 1A47F660965;
\r
34 Thu, 24 Nov 2011 16:43:47 +0100 (CET)
\r
35 Received: from wsh by steelpick.2x.cz with local (Exim 4.76)
\r
36 (envelope-from <sojka@os.inf.tu-dresden.de>)
\r
37 id 1RTbSk-0006pL-SR; Thu, 24 Nov 2011 16:43:46 +0100
\r
38 From: Michal Sojka <sojkam1@fel.cvut.cz>
\r
39 To: Daniel Schoepe <daniel@schoepe.org>, David Bremner <david@tethera.net>,
\r
40 notmuch@notmuchmail.org
\r
41 Subject: Re: [PATCH v6 1/2] emacs: User-defined sections in notmuch-hello
\r
42 In-Reply-To: <8762i9aaci.fsf@schoepe.localhost>
\r
43 References: <87ippzysmv.fsf@steelpick.2x.cz>
\r
44 <1318253982-23588-1-git-send-email-daniel@schoepe.org>
\r
45 <1318253982-23588-2-git-send-email-daniel@schoepe.org>
\r
46 <87aa7l8w2d.fsf@zancas.localnet> <8762i9aaci.fsf@schoepe.localhost>
\r
47 User-Agent: Notmuch/0.8-40-g6eb7026 (http://notmuchmail.org) Emacs/23.3.1
\r
48 (x86_64-pc-linux-gnu)
\r
49 Date: Thu, 24 Nov 2011 16:43:46 +0100
\r
50 Message-ID: <87aa7lle4t.fsf@steelpick.2x.cz>
\r
52 Content-Type: text/plain; charset=us-ascii
\r
53 X-BeenThere: notmuch@notmuchmail.org
\r
54 X-Mailman-Version: 2.1.13
\r
56 List-Id: "Use and development of the notmuch mail system."
\r
57 <notmuch.notmuchmail.org>
\r
58 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
59 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
60 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
61 List-Post: <mailto:notmuch@notmuchmail.org>
\r
62 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
63 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
64 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
65 X-List-Received-Date: Thu, 24 Nov 2011 15:43:50 -0000
\r
67 On Thu, 24 Nov 2011, Daniel Schoepe wrote:
\r
68 > On Thu, 24 Nov 2011 09:54:50 -0400, David Bremner <david@tethera.net> wrote:
\r
69 > > On Mon, 10 Oct 2011 15:39:41 +0200, Daniel Schoepe <daniel@schoepe.org> wrote:
\r
70 > > > From: Daniel Schoepe <daniel.schoepe@googlemail.com>
\r
72 > > > This patch makes the notmuch-hello screen fully customizable
\r
73 > > > by allowing the user to add and remove arbitrary sections. It
\r
74 > > > also provides some convenience functions for constructing sections,
\r
75 > > > e.g. showing the unread message count for each tag.
\r
78 > > Yow, that is a big patch, I think it needs some more review.
\r
80 I use this patch on a daily basis. There is probably some space for
\r
81 improvements, especially in the coding style, but I'd like to see a more
\r
82 experience elisp hacker than me looking at it.
\r
84 > Yes; Unfortunately I didn't manage to come up with good partitioning
\r
85 > into smaller patches, because the changes are quite interconnected.
\r
87 > Is there something I can do to help with the review?
\r
89 > I think there's also one performance improvement written by Michal
\r
90 > Sojka, that isn't included in this version yet,
\r
92 Yes, that's true. I'm aware of one bug in this improvement. I usually
\r
95 emacsclient -c -a '' -e "(notmuch)"
\r
97 and the bug is that sometimes the emacs window disappear immediately
\r
98 after appearing. This did not happen without this improvement and I
\r
99 guess it is caused by some unexpected return value, perhaps in the code
\r
100 which determines the initial position of the point.
\r