1 Return-Path: <jani@nikula.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id EEF71431FB6
\r
6 for <notmuch@notmuchmail.org>; Sun, 13 Jan 2013 06:41:30 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.699 tagged_above=-999 required=5
\r
12 tests=[HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id UiS8Z6APGodf for <notmuch@notmuchmail.org>;
\r
16 Sun, 13 Jan 2013 06:41:30 -0800 (PST)
\r
17 Received: from mail-vb0-f49.google.com (mail-vb0-f49.google.com
\r
18 [209.85.212.49]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 598F9431FAF
\r
21 for <notmuch@notmuchmail.org>; Sun, 13 Jan 2013 06:41:30 -0800 (PST)
\r
22 Received: by mail-vb0-f49.google.com with SMTP id s24so2305779vbi.8
\r
23 for <notmuch@notmuchmail.org>; Sun, 13 Jan 2013 06:41:28 -0800 (PST)
\r
24 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
\r
25 d=google.com; s=20120113;
\r
26 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
\r
27 :cc:content-type:x-gm-message-state;
\r
28 bh=8ntwEpF+ROVGgBq/UFcsTVfA6kMnU9QR/qGZ+1TifLs=;
\r
29 b=N/axl9Cpwk7rWgnYvL868mVosLsHJygeTxUpkGqdNCGbp8OGwDJOYEQv9LxWFib18L
\r
30 PdnuXQ+KwxsN0vuafBCFeXzdnInltg3l2L7z8/GGJQSIgeOviiBrsuWHaPIozJG08Tzg
\r
31 XH8HjoT7O3pnrZ4WcFIBaXEkerZ6Rzr2AEyRWujKoUFxeSgHoTORAUa7ZWya5WcHWe9o
\r
32 N4pd86r3/LX+xM7UQB8BVRIQ9m+mCtojYdXMNclVa1qQA54nYvNq2hTpsF/1tMuv4smw
\r
33 XJwgcUNXcsQKFjNPZRI6eQHlrUCg8Tmo+4hOa7vas+xy3k6NOEp1RsDjrourk6/iIrW6
\r
36 Received: by 10.52.16.17 with SMTP id b17mr86696289vdd.86.1358088088610; Sun,
\r
37 13 Jan 2013 06:41:28 -0800 (PST)
\r
38 Received: by 10.58.248.132 with HTTP; Sun, 13 Jan 2013 06:41:28 -0800 (PST)
\r
39 Received: by 10.58.248.132 with HTTP; Sun, 13 Jan 2013 06:41:28 -0800 (PST)
\r
40 In-Reply-To: <87fw25cfnw.fsf@zancas.localnet>
\r
41 References: <1357976414-7468-1-git-send-email-tomi.ollila@iki.fi>
\r
42 <87fw25cfnw.fsf@zancas.localnet>
\r
43 Date: Sun, 13 Jan 2013 16:41:28 +0200
\r
45 <CAB+hUn9rAbZt04R46WjQJqY29-X-WAi6qyTLmGWx=H6TNjwwHA@mail.gmail.com>
\r
46 Subject: Re: [PATCH 1/1] cli: propagate batch tagging warnings to exit value
\r
47 From: Jani Nikula <jani@nikula.org>
\r
48 To: David Bremner <david@tethera.net>
\r
49 Content-Type: multipart/alternative; boundary=bcaec50408e818663b04d32c8672
\r
51 ALoCoQlkQN3EjMqaaZmAaeEnAlB6TpgBFljsz+byI7lX0o6zglqS0zwrSS+8uv0mm8l9R8AyOoD+
\r
52 Cc: Tomi Ollila <tomi.ollila@iki.fi>, Notmuch Mail <notmuch@notmuchmail.org>
\r
53 X-BeenThere: notmuch@notmuchmail.org
\r
54 X-Mailman-Version: 2.1.13
\r
56 List-Id: "Use and development of the notmuch mail system."
\r
57 <notmuch.notmuchmail.org>
\r
58 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
59 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
60 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
61 List-Post: <mailto:notmuch@notmuchmail.org>
\r
62 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
63 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
64 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
65 X-List-Received-Date: Sun, 13 Jan 2013 14:41:31 -0000
\r
67 --bcaec50408e818663b04d32c8672
\r
68 Content-Type: text/plain; charset=UTF-8
\r
70 On Jan 13, 2013 4:37 PM, "David Bremner" <david@tethera.net> wrote:
\r
72 > Tomi Ollila <tomi.ollila@iki.fi> writes:
\r
74 > > In case last input for batch tagging was either invalid or skippable
\r
75 > > line, notmuch command exited with non-zero value.
\r
76 > > After this change if there is at least one invalid line, notmuch
\r
77 > > command will exit with non-zero value. Additionally, skipped lines
\r
78 > > (last or other) doesn't cause non-zero value to be returned.
\r
80 > This looks OK. In a perfect world we'd have a test for return values.
\r
82 And distinct codes for warnings and errors... but can't have everything at
\r
88 > _______________________________________________
\r
89 > notmuch mailing list
\r
90 > notmuch@notmuchmail.org
\r
91 > http://notmuchmail.org/mailman/listinfo/notmuch
\r
93 --bcaec50408e818663b04d32c8672
\r
94 Content-Type: text/html; charset=UTF-8
\r
97 On Jan 13, 2013 4:37 PM, "David Bremner" <<a href="mailto:david@tethera.net">david@tethera.net</a>> wrote:<br>
\r
99 > Tomi Ollila <<a href="mailto:tomi.ollila@iki.fi">tomi.ollila@iki.fi</a>> writes:<br>
\r
101 > > In case last input for batch tagging was either invalid or skippable<br>
\r
102 > > line, notmuch command exited with non-zero value.<br>
\r
103 > > After this change if there is at least one invalid line, notmuch<br>
\r
104 > > command will exit with non-zero value. Additionally, skipped lines<br>
\r
105 > > (last or other) doesn't cause non-zero value to be returned.<br>
\r
107 > This looks OK. In a perfect world we'd have a test for return values.</p>
\r
108 <p>And distinct codes for warnings and errors... but can't have everything at once...</p>
\r
111 > _______________________________________________<br>
\r
112 > notmuch mailing list<br>
\r
113 > <a href="mailto:notmuch@notmuchmail.org">notmuch@notmuchmail.org</a><br>
\r
114 > <a href="http://notmuchmail.org/mailman/listinfo/notmuch">http://notmuchmail.org/mailman/listinfo/notmuch</a><br>
\r
117 --bcaec50408e818663b04d32c8672--
\r