1 Return-Path: <m.walters@qmul.ac.uk>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 6CE56431FC2
\r
6 for <notmuch@notmuchmail.org>; Sun, 21 Jul 2013 01:36:48 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=1.401 tagged_above=-999 required=5
\r
12 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,
\r
13 FREEMAIL_REPLY=2.499, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3]
\r
15 Received: from olra.theworths.org ([127.0.0.1])
\r
16 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
17 with ESMTP id Yy6I6E2970gC for <notmuch@notmuchmail.org>;
\r
18 Sun, 21 Jul 2013 01:36:41 -0700 (PDT)
\r
19 Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])
\r
20 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
21 (No client certificate requested)
\r
22 by olra.theworths.org (Postfix) with ESMTPS id 0CBB5431FB6
\r
23 for <notmuch@notmuchmail.org>; Sun, 21 Jul 2013 01:36:41 -0700 (PDT)
\r
24 Received: from smtp.qmul.ac.uk ([138.37.6.40])
\r
25 by mail2.qmul.ac.uk with esmtp (Exim 4.71)
\r
26 (envelope-from <m.walters@qmul.ac.uk>)
\r
27 id 1V0p8B-0006BQ-6j; Sun, 21 Jul 2013 09:36:39 +0100
\r
28 Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)
\r
29 by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)
\r
30 (envelope-from <m.walters@qmul.ac.uk>)
\r
31 id 1V0p8A-0002hH-Sg; Sun, 21 Jul 2013 09:36:39 +0100
\r
32 From: Mark Walters <markwalters1009@gmail.com>
\r
33 To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
\r
34 Subject: Re: [PATCH 00/11] contrib: pick: keybindings
\r
35 In-Reply-To: <m2ppuwt7db.fsf@guru.guru-group.fi>
\r
36 References: <1373047878-20822-1-git-send-email-markwalters1009@gmail.com>
\r
37 <m2ppuwt7db.fsf@guru.guru-group.fi>
\r
38 User-Agent: Notmuch/0.15.2+192~g8222af3 (http://notmuchmail.org) Emacs/23.4.1
\r
40 Date: Sun, 21 Jul 2013 09:36:38 +0100
\r
41 Message-ID: <87ehas8g2x.fsf@qmul.ac.uk>
\r
43 Content-Type: text/plain; charset=us-ascii
\r
44 X-Sender-Host-Address: 93.97.24.31
\r
45 X-QM-SPAM-Info: Sender has good ham record. :)
\r
46 X-QM-Body-MD5: 6ad08e95498472513f982c37411e7c70 (of first 20000 bytes)
\r
47 X-SpamAssassin-Score: 0.6
\r
48 X-SpamAssassin-SpamBar: /
\r
49 X-SpamAssassin-Report: The QM spam filters have analysed this message to
\r
51 spam. We require at least 5.0 points to mark a message as spam.
\r
52 This message scored 0.6 points. Summary of the scoring:
\r
53 * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
\r
54 provider * (markwalters1009[at]gmail.com)
\r
55 * 1.0 FREEMAIL_REPLY From and body contain different freemails
\r
56 * -0.4 AWL AWL: From: address is in the auto white-list
\r
57 X-QM-Scan-Virus: ClamAV says the message is clean
\r
58 X-BeenThere: notmuch@notmuchmail.org
\r
59 X-Mailman-Version: 2.1.13
\r
61 List-Id: "Use and development of the notmuch mail system."
\r
62 <notmuch.notmuchmail.org>
\r
63 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
64 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
65 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
66 List-Post: <mailto:notmuch@notmuchmail.org>
\r
67 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
68 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
69 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
70 X-List-Received-Date: Sun, 21 Jul 2013 08:36:48 -0000
\r
72 Tomi Ollila <tomi.ollila@iki.fi> writes:
\r
74 > On Fri, Jul 05 2013, Mark Walters <markwalters1009@gmail.com> wrote:
\r
76 >> This series adds lots of keybindings and funtionality to pick: in
\r
77 >> particular it adds the stash keymap, the ability to tab between and
\r
78 >> activate buttons in the message pane, and it reduces a lot of code
\r
79 >> duplication between pick and show.
\r
81 >> It is a large series: but most of it is a lot of small changes. These
\r
82 >> small changes are mostly logically independent but as they add
\r
83 >> keybindings their contexts all clash. I have made most of the
\r
84 >> keybindings as single separate patches to make discussion of them
\r
85 >> individually easier.
\r
87 >> The key patches for review/discussion (apart from bike-shedding on
\r
88 >> key-bindings!) are patches 1, 5 and 8.
\r
92 Thanks for the review.
\r
94 > Now that you "asked", I'd ask what was used as a reason to decide "/"
\r
95 > as keybinding for notmuch-pick-button-activate -- something common
\r
96 > or as a convenience. In US/UK keyboard "/" is left to Right Shift,
\r
97 > but for example in my keyboard it is Shift-7...
\r
99 That is just my not knowing (and I regret to say even thinking of) other
\r
100 keyboard layouts. I agree that makes it a silly key. What about 'e'
\r
101 (Enter as the mnemonic)?
\r
103 >> Patch 1 is the most "controversial": it over-rides
\r
104 >> notmuch-show-get-prop so that whether it uses
\r
105 >> notmuch-show-get-message-properties or
\r
106 >> notmuch-pick-get-message-properties depends on the major-mode (ie
\r
107 >> whether it is called from pick or show).
\r
109 > At the moment the code comments could have something like XXX to
\r
110 > emphasize the situation. IMHO it is ok to have this in contrib
\r
111 > code -- when this is going to be "official" part of emacs MUA
\r
112 > then this code needs to be ... well, at least moved to other place :D
\r
114 Yes that is a good point. I will add this in the next version.
\r
121 > Apart from these code LGTM.
\r
126 >> This means that functions from show which just use message properties
\r
127 >> (most often just the message id) "just work" when called from pick. In
\r
128 >> particular it gives us access to lots of functions without having to
\r
129 >> duplicate the code.
\r
131 >> In the longer term it would be better to have some show/pick common
\r
132 >> file and migrate the common functions there.
\r
134 >> Patch 5 and 8 add in functions for creating fucntions ready to be used
\r
135 >> in keybindings. The one in patch 5 takes a show fucntion and creates a
\r
136 >> function which switches from pick to the message pane, applies the
\r
137 >> function and then switches back to pick. The one in patch 8 takes a
\r
138 >> function and creates a function which closes the message pane and the
\r
139 >> calls this function.
\r
141 >> Both of these make the keybinding section clearer. They also have the
\r
142 >> advantage that the user can use them easily to create their own
\r
143 >> keybindings which do this.
\r
145 >> This completes all the keybindings I use and I think means that pick
\r
146 >> doesn't have any glaring omissions.
\r
148 >> Finally, this will clash with the thread archive patches
\r
149 >> id:1371195472-441-1-git-send-email-markwalters1009@gmail.com
\r
155 >> Mark Walters (11):
\r
156 >> contrib: pick: override notmuch-show-get-prop
\r
157 >> contrib: pick: Link in notmuch-show-pipe-message
\r
158 >> contrib: pick: Link in attachment functions straight from
\r
160 >> contrib: pick: Link in stash map straight from notmuch-show
\r
161 >> contrib: pick: add in to-message-window function
\r
162 >> contrib: pick: add button press helper
\r
163 >> contrib: pick: pass tab through to the message pane
\r
164 >> contrib: pick: close window function
\r
165 >> contrib: pick: make help close the message pane first
\r
166 >> contrib: pick: add in binding to view raw message
\r
167 >> contrib: pick: use close-message-pane for reply etc
\r
169 >> contrib/notmuch-pick/notmuch-pick.el | 139 +++++++++++++++++-----------------
\r
170 >> 1 files changed, 70 insertions(+), 69 deletions(-)
\r
175 >> _______________________________________________
\r
176 >> notmuch mailing list
\r
177 >> notmuch@notmuchmail.org
\r
178 >> http://notmuchmail.org/mailman/listinfo/notmuch
\r