1 Return-Path: <m.walters@qmul.ac.uk>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id E3F20431FBC
\r
6 for <notmuch@notmuchmail.org>; Sun, 30 Jun 2013 01:30:11 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=1.401 tagged_above=-999 required=5
\r
12 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,
\r
13 FREEMAIL_REPLY=2.499, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3]
\r
15 Received: from olra.theworths.org ([127.0.0.1])
\r
16 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
17 with ESMTP id e5vXK5Tq4Z2w for <notmuch@notmuchmail.org>;
\r
18 Sun, 30 Jun 2013 01:30:05 -0700 (PDT)
\r
19 Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])
\r
20 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
21 (No client certificate requested)
\r
22 by olra.theworths.org (Postfix) with ESMTPS id F3544431FB6
\r
23 for <notmuch@notmuchmail.org>; Sun, 30 Jun 2013 01:30:04 -0700 (PDT)
\r
24 Received: from smtp.qmul.ac.uk ([138.37.6.40])
\r
25 by mail2.qmul.ac.uk with esmtp (Exim 4.71)
\r
26 (envelope-from <m.walters@qmul.ac.uk>)
\r
27 id 1UtD1B-0005D7-8Z; Sun, 30 Jun 2013 09:29:57 +0100
\r
28 Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)
\r
29 by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)
\r
30 (envelope-from <m.walters@qmul.ac.uk>)
\r
31 id 1UtD1B-0001Yr-0H; Sun, 30 Jun 2013 09:29:57 +0100
\r
32 From: Mark Walters <markwalters1009@gmail.com>
\r
33 To: notmuch@notmuchmail.org
\r
34 Subject: Re: [PATCH 0/2] Contrib: Pick: Remove horrible hack
\r
35 In-Reply-To: <1369551008-30697-1-git-send-email-markwalters1009@gmail.com>
\r
36 References: <1369551008-30697-1-git-send-email-markwalters1009@gmail.com>
\r
37 User-Agent: Notmuch/0.15.2+192~g8222af3 (http://notmuchmail.org) Emacs/23.4.1
\r
38 (x86_64-pc-linux-gnu)
\r
39 Date: Sun, 30 Jun 2013 09:29:56 +0100
\r
40 Message-ID: <87sj00xapn.fsf@qmul.ac.uk>
\r
42 Content-Type: text/plain; charset=us-ascii
\r
43 X-Sender-Host-Address: 93.97.24.31
\r
44 X-QM-SPAM-Info: Sender has good ham record. :)
\r
45 X-QM-Body-MD5: 8b4131088c5d751e49869592321450d5 (of first 20000 bytes)
\r
46 X-SpamAssassin-Score: 0.6
\r
47 X-SpamAssassin-SpamBar: /
\r
48 X-SpamAssassin-Report: The QM spam filters have analysed this message to
\r
50 spam. We require at least 5.0 points to mark a message as spam.
\r
51 This message scored 0.6 points. Summary of the scoring:
\r
52 * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
\r
53 provider * (markwalters1009[at]gmail.com)
\r
54 * 1.0 FREEMAIL_REPLY From and body contain different freemails
\r
55 * -0.4 AWL AWL: From: address is in the auto white-list
\r
56 X-QM-Scan-Virus: ClamAV says the message is clean
\r
57 X-BeenThere: notmuch@notmuchmail.org
\r
58 X-Mailman-Version: 2.1.13
\r
60 List-Id: "Use and development of the notmuch mail system."
\r
61 <notmuch.notmuchmail.org>
\r
62 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
63 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
64 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
65 List-Post: <mailto:notmuch@notmuchmail.org>
\r
66 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
67 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
68 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
69 X-List-Received-Date: Sun, 30 Jun 2013 08:30:12 -0000
\r
72 Would anyone be able to review (or just test) this pair of patches: they
\r
73 are smaller and simpler than the diffstat suggests: the second patch is
\r
74 just 3 extra lines of code (with some whitespace change and commments).
\r
76 This pair of patches does remove the worst piece of code in pick: a
\r
77 sleep loop waiting for the correct message to arrive.
\r
79 I should have said that it applies on top of
\r
80 id:1369550458-30562-1-git-send-email-markwalters1009@gmail.com
\r
82 (which is also very simple)
\r
91 On Sun, 26 May 2013, Mark Walters <markwalters1009@gmail.com> wrote:
\r
92 > Pick used to have one horrible hack: if the user asked it to open the
\r
93 > first matching message it had to check whether that had arrived (as
\r
94 > the search is asynchronous) and if not wait and try again. Now the
\r
95 > opening of the first matching message is called via the pick process
\r
96 > filter this hack can be removed.
\r
98 > This did reveal the followibg small bug. Pick shows the subject line
\r
99 > in the output but if it is the same as the previous line (ignoring re:
\r
100 > etc) it shows ... If a single message is refreshed (eg for a tag
\r
101 > update) this was got wrong. The change above triggered this and made
\r
102 > the test fail as the unread tag was removed from the first matching
\r
103 > message when it was displayed.
\r
105 > Patch 2/2 fixes this by storing the previous subject with the search result.
\r
112 > Mark Walters (2):
\r
113 > contrib: pick: remove hack notmuch-pick-show-match-message-with-wait
\r
114 > contrib: pick: fix refresh result
\r
116 > contrib/notmuch-pick/notmuch-pick.el | 60 ++++++++++++++++-----------------
\r
117 > 1 files changed, 29 insertions(+), 31 deletions(-)
\r
projects / notmuch-archives.git / blob