1 Return-Path: <bremner@unb.ca>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 8AD15431FAF
\r
6 for <notmuch@notmuchmail.org>; Mon, 30 Apr 2012 04:39:42 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id pu18RhfCQpkk for <notmuch@notmuchmail.org>;
\r
16 Mon, 30 Apr 2012 04:39:41 -0700 (PDT)
\r
17 Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])
\r
18 (using TLSv1 with cipher AES256-SHA (256/256 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id D351B431FAE
\r
21 for <notmuch@notmuchmail.org>; Mon, 30 Apr 2012 04:39:41 -0700 (PDT)
\r
22 Received: from fctnnbsc30w-156034089108.dhcp-dynamic.fibreop.nb.bellaliant.net
\r
23 ([156.34.89.108] helo=zancas.localnet)
\r
24 by tesseract.cs.unb.ca with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32)
\r
25 (Exim 4.72) (envelope-from <bremner@unb.ca>)
\r
26 id 1SOox8-0004bH-1b; Mon, 30 Apr 2012 08:39:38 -0300
\r
27 Received: from bremner by zancas.localnet with local (Exim 4.77)
\r
28 (envelope-from <bremner@unb.ca>)
\r
29 id 1SOox2-0004VF-Jy; Mon, 30 Apr 2012 08:39:32 -0300
\r
30 From: David Bremner <david@tethera.net>
\r
31 To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
\r
32 Subject: Re: [PATCH 1/6] lib/cli: Make notmuch_database_open return a status
\r
34 In-Reply-To: <1335651473-19652-2-git-send-email-amdragon@mit.edu>
\r
35 References: <1335651473-19652-1-git-send-email-amdragon@mit.edu>
\r
36 <1335651473-19652-2-git-send-email-amdragon@mit.edu>
\r
37 User-Agent: Notmuch/0.12+152~g904a807 (http://notmuchmail.org) Emacs/23.4.1
\r
38 (x86_64-pc-linux-gnu)
\r
39 Date: Mon, 30 Apr 2012 08:39:32 -0300
\r
40 Message-ID: <87pqapphxn.fsf@zancas.localnet>
\r
42 Content-Type: text/plain; charset=us-ascii
\r
44 X-BeenThere: notmuch@notmuchmail.org
\r
45 X-Mailman-Version: 2.1.13
\r
47 List-Id: "Use and development of the notmuch mail system."
\r
48 <notmuch.notmuchmail.org>
\r
49 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
50 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
51 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
52 List-Post: <mailto:notmuch@notmuchmail.org>
\r
53 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
54 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
55 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
56 X-List-Received-Date: Mon, 30 Apr 2012 11:39:42 -0000
\r
59 I have two questions, both of which might have been settled previously.
\r
63 > + *database = notmuch;
\r
67 Should we check database is non-NULL here?
\r
69 > diff --git a/notmuch-count.c b/notmuch-count.c
\r
70 > index 9c2ad7b..2f98128 100644
\r
71 > --- a/notmuch-count.c
\r
72 > +++ b/notmuch-count.c
\r
74 > + if (notmuch_database_open (notmuch_config_get_database_path (config),
\r
75 > + NOTMUCH_DATABASE_MODE_READ_ONLY, ¬much))
\r
77 Is it OK to rely on NOTMUCH_STATUS_SUCCESS==0 ?
\r