f6/6caffe2acbf1b8129fdf953797ff55fa940956

   1 Return-Path: <amdragon@mit.edu>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id 8A555431FD0\r
   6         for <notmuch@notmuchmail.org>; Fri,  9 Sep 2011 10:33:12 -0700 (PDT)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.7\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
  12         tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
  13 Received: from olra.theworths.org ([127.0.0.1])\r
  14         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  15         with ESMTP id jNtGdFvGdXy3 for <notmuch@notmuchmail.org>;\r
  16         Fri,  9 Sep 2011 10:33:12 -0700 (PDT)\r
  17 Received: from dmz-mailsec-scanner-8.mit.edu (DMZ-MAILSEC-SCANNER-8.MIT.EDU\r
  18         [18.7.68.37])\r
  19         by olra.theworths.org (Postfix) with ESMTP id 1FD56431FB6\r
  20         for <notmuch@notmuchmail.org>; Fri,  9 Sep 2011 10:33:12 -0700 (PDT)\r
  21 X-AuditID: 12074425-b7bf1ae000000a2a-ab-4e6a4d9d5c48\r
  22 Received: from mailhub-auth-2.mit.edu ( [18.7.62.36])\r
  23         by dmz-mailsec-scanner-8.mit.edu (Symantec Messaging Gateway) with SMTP\r
  24         id 89.EC.02602.D9D4A6E4; Fri,  9 Sep 2011 13:32:13 -0400 (EDT)\r
  25 Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
  26         by mailhub-auth-2.mit.edu (8.13.8/8.9.2) with ESMTP id p89HXA4t023168; \r
  27         Fri, 9 Sep 2011 13:33:10 -0400\r
  28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
  29         (authenticated bits=0)\r
  30         (User authenticated as amdragon@ATHENA.MIT.EDU)\r
  31         by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id p89HX7JB016775\r
  32         (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
  33         Fri, 9 Sep 2011 13:33:08 -0400 (EDT)\r
  34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.72)\r
  35         (envelope-from <amdragon@mit.edu>)\r
  36         id 1R24zK-00066c-0h; Fri, 09 Sep 2011 13:35:38 -0400\r
  37 Date: Fri, 9 Sep 2011 13:35:37 -0400\r
  38 From: Austin Clements <amdragon@MIT.EDU>\r
  39 To: Thomas Schwinge <thomas@schwinge.name>\r
  40 Subject: Re: [PATCH] notmuch restore --accumulate\r
  41 Message-ID: <20110909173537.GU5688@mit.edu>\r
  42 References: <1315249637-20179-1-git-send-email-thomas@schwinge.name>\r
  43         <87liu2kcq6.fsf@servo.factory.finestructure.net>\r
  44         <20110909090633.GA3178@localdomain>\r
  45         <87fwk63v86.fsf@kepler.schwinge.homeip.net>\r
  46         <CAH-f9WutmDs2=UELduO66YPPFhy1g8D4_xNhnEjOiWaJMv7m5Q@mail.gmail.com>\r
  47         <87fwk53a1i.fsf@kepler.schwinge.homeip.net>\r
  48 MIME-Version: 1.0\r
  49 Content-Type: text/plain; charset=us-ascii\r
  50 Content-Disposition: inline\r
  51 In-Reply-To: <87fwk53a1i.fsf@kepler.schwinge.homeip.net>\r
  52 User-Agent: Mutt/1.5.20 (2009-06-14)\r
  53 X-Brightmail-Tracker:\r
  54  H4sIAAAAAAAAA+NgFlrIKsWRmVeSWpSXmKPExsUixG6nojvXN8vP4FSPtMWefV4W51tesVhc\r
  55         vzmT2aLx1WdGBxaPu+vWsXvcPc3l8WzVLWaPd3unswSwRHHZpKTmZJalFunbJXBlfJg7naWg\r
  56         i73i6a1+lgbGs6xdjJwcEgImEm/alzBD2GISF+6tZ+ti5OIQEtjHKPF2+mNGkISQwHpGiYa9\r
  57         BRD2CSaJzw90IewljBKfH3uC2CwCKhJbfh8AG8QmoCGxbf9ysF4RAS2JOau/gg1lFmhhlOhe\r
  58         u5MFJCEsYCgxd9lKdhCbV0Bb4umkt8wQmw8wSTR1nmCBSAhKnJz5BMxmBpp0499Lpi5GDiBb\r
  59         WmL5Pw6QMKeAhUTvj79MILYo0BHX9rezTWAUmoWkexaS7lkI3QsYmVcxyqbkVunmJmbmFKcm\r
  60         6xYnJ+blpRbpWujlZpbopaaUbmIEh76L6g7GCYeUDjEKcDAq8fCuMM3yE2JNLCuuzD3EKMnB\r
  61         pCTKq+oFFOJLyk+pzEgszogvKs1JLT7EKMHBrCTCGycBlONNSaysSi3Kh0lJc7AoifO+3uHg\r
  62         JySQnliSmp2aWpBaBJOV4eBQkuA1B8a4kGBRanpqRVpmTglCmomDE2Q4D9DwJz4gw4sLEnOL\r
  63         M9Mh8qcYdTnOr71+nFGIJS8/L1VKnNcSZJAASFFGaR7cHFjKesUoDvSWMK8GSBUPMN3BTXoF\r
  64         tIQJaEnA9kyQJSWJCCmpBkZfnjeZLn+WqYg3/Cu688Zb5sz7dfsXnnprs2b9ncty+7fH/d9/\r
  65         5egF8dkPtp6bZift9dvTcWHHJcXWG4zhdtcipy4UfGfA819bc5/fio2fwoLXJ3R9Ms7cfP9n\r
  66         6aE3htJGu769dD7ucHnBlS5jt8+OXxSeb/vIGJN90MbDWPBQgEXz76sOwibOSizFGYmGWsxF\r
  67         xYkA6YyuPzQDAAA=\r
  68 Cc: notmuch@notmuchmail.org\r
  69 X-BeenThere: notmuch@notmuchmail.org\r
  70 X-Mailman-Version: 2.1.13\r
  71 Precedence: list\r
  72 List-Id: "Use and development of the notmuch mail system."\r
  73         <notmuch.notmuchmail.org>\r
  74 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  75         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  76 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  77 List-Post: <mailto:notmuch@notmuchmail.org>\r
  78 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  79 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  80         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  81 X-List-Received-Date: Fri, 09 Sep 2011 17:33:12 -0000\r
  82 \r
  83 Quoth Thomas Schwinge on Sep 09 at  7:22 pm:\r
  84 > Hi!\r
  85 > \r
  86 > On Fri, 9 Sep 2011 12:13:06 -0400, Austin Clements <amdragon@mit.edu> wrote:\r
  87 > > The idea behind sending the test first is that people can see that it fails\r
  88 > > and that the subsequent patch indeed fixes it.  What I find works well is to\r
  89 > > submit the test case with the test marked as broken and then the main patch,\r
  90 > > including the change to un-mark it as broken.\r
  91 > \r
  92 > Ah, that's indeed a good approach for bug fixes (and it also preserves\r
  93 > git bisect compatibility), but still: why separate patches for new\r
  94 > functionality?  (I'm not trying to be a pain here, but would like to\r
  95 > understand your rationale behind this.)\r
  96 \r
  97 *shrugs* I don't think it's too important for new functionality,\r
  98 though for review it's nice to be able to focus on just the\r
  99 implementation or just the tests, rather than having the patches\r
 100 intermingled.\r