1 Return-Path: <aperez@igalia.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 43ADF431FBC
\r
6 for <notmuch@notmuchmail.org>; Fri, 20 Nov 2009 11:01:43 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
8 Received: from olra.theworths.org ([127.0.0.1])
\r
9 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
10 with ESMTP id M3NXyWaWV1gP for <notmuch@notmuchmail.org>;
\r
11 Fri, 20 Nov 2009 11:01:42 -0800 (PST)
\r
12 Received: from smtp2.mundo-r.com (smtp3.mundo-r.com [212.51.32.191])
\r
13 by olra.theworths.org (Postfix) with ESMTP id 2A074431FAE
\r
14 for <notmuch@notmuchmail.org>; Fri, 20 Nov 2009 11:01:41 -0800 (PST)
\r
15 X-IronPort-Anti-Spam-Filtered: true
\r
16 X-IronPort-Anti-Spam-Result: AqIEAMJ1BktbdWOb/2dsb2JhbACBTtNXCoQyBA
\r
17 X-IronPort-AV: E=Sophos;i="4.47,260,1257116400";
\r
18 d="asc'?scan'208";a="556056499"
\r
19 Received: from 155.99.117.91.static.mundo-r.com (HELO fanzine.igalia.com)
\r
21 by smtp2.mundo-r.com with ESMTP; 20 Nov 2009 20:01:40 +0100
\r
22 Received: from maestria.local.igalia.com ([192.168.10.14]
\r
23 helo=mail.igalia.com) by fanzine.igalia.com with esmtps (Cipher
\r
24 TLS1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim) id 1NBYjk-0004KN-EP for
\r
25 <notmuch@notmuchmail.org>; Fri, 20 Nov 2009 20:01:40 +0100
\r
26 Received: from ip129.dynamic.igalia.com ([192.168.10.129]
\r
27 helo=hikari.localdomain) by mail.igalia.com with esmtp (Exim)
\r
29 for <notmuch@notmuchmail.org>; Fri, 20 Nov 2009 20:01:39 +0100
\r
30 Received: from hikari (localhost [127.0.0.1])
\r
31 by hikari.localdomain (Postfix) with ESMTP id F1E2D3134181
\r
32 for <notmuch@notmuchmail.org>; Fri, 20 Nov 2009 20:03:00 +0100 (CET)
\r
33 Date: Fri, 20 Nov 2009 20:03:00 +0100
\r
34 From: Adrian Perez de Castro <aperez@igalia.com>
\r
35 To: notmuch@notmuchmail.org
\r
36 Message-ID: <20091120200300.55ba8736@hikari>
\r
37 In-Reply-To: <87lji11leu.fsf@yoom.home.cworth.org>
\r
38 References: <935ead450911181000w2cddfe95qe9efd5bea9f9209d@mail.gmail.com>
\r
39 <20091119164543.25e7afe5@hikari>
\r
40 <935ead450911191823s776fda6eyb6f6949ac982bd03@mail.gmail.com>
\r
41 <87lji11leu.fsf@yoom.home.cworth.org>
\r
42 Organization: Igalia
\r
43 X-Mailer: Claws Mail 3.7.3 (GTK+ 2.18.3; x86_64-redhat-linux-gnu)
\r
44 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAAXNSR0IArs4c6QAAADBQTFRFBwcHFhYWKCgoNzc3SEhIV1dXaGhod3d3iIiIlpaWqKiouLi4x8fH2NjY5+fn/v7+rSjDkgAAAjVJREFUOE9l07tvE0EQwOHfrkV9O+eko7g701BBfECJsIigT2IpooIqaSiRUEB0REj00FBQgYSCkhry+gecUPJybJeIxLumTbilsH2PMNXufDOa3ZVW+1JkpbUmD/8+vXR3c7or4Gz93mH309Kz8/C9/RQge7VfhW/LW+PF8IkrQ7Z6OKmQr1tl+LU/yWP9mxJka9O88fZHPwf/7u0kLyCnX3I4fQhgjAgIfi+HHw5A1Y2ggIMcFKAEnRoL0M3BosI4TI2IATjuT8DvSNJoNNJgkIhxlr9TUHeSpDnfohlIrMBlU+BGmsZqfr69FMfGMw4NoG835+J62riWyjQ/uXlTQjNUIoYegMsBM0pCD8oDas7n4HQsBghXFxJTW42KDs+4XLfjsN0wOYgABqARjMKIHIaAQnmHjsI5Cvi9Cf6k03OoWBkpIP3Q7354+dEimFBKHbMP9oKjwfd9gbrxR5KDToczK4uPF8UgNomKU2GaENRi77zyDKICxKBS4xXYbONPMQMdYZTBwMiMWiUg9g6UJ3OBogzjV8E7sBVwyvfAOYdQhsABzuOxI1MGZbs98Q6Md5UOfbbR2R0eWOesrnRw5ajT6f60LrNhWIHZpBnUWv2s14ukArWWTqTes3YQxRXgFkcMu70TPYqqUBs0YwmO967OVIdTG4bY4a7WLaqgLm5vbHdH5np0Dri//fmg7y8scB4u3+zsuNlH0X+g19bby69b+TYH6isvns8VdQWgxj9tHP8AR5/hSdYqkwsAAAAASUVORK5CYII=
\r
46 Content-Type: multipart/signed; micalg=PGP-SHA1;
\r
47 boundary="Sig_/_c1Cg6wI_1TUQe7AmijdlNP";
\r
48 protocol="application/pgp-signature"
\r
49 Subject: Re: [notmuch] Segfault searching for tags
\r
50 X-BeenThere: notmuch@notmuchmail.org
\r
51 X-Mailman-Version: 2.1.12
\r
53 List-Id: "Use and development of the notmuch mail system."
\r
54 <notmuch.notmuchmail.org>
\r
55 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
56 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
57 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
58 List-Post: <mailto:notmuch@notmuchmail.org>
\r
59 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
60 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
61 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
62 X-List-Received-Date: Fri, 20 Nov 2009 19:01:43 -0000
\r
64 --Sig_/_c1Cg6wI_1TUQe7AmijdlNP
\r
65 Content-Type: text/plain; charset=US-ASCII
\r
66 Content-Transfer-Encoding: quoted-printable
\r
68 On Fri, 20 Nov 2009 12:32:41 +0100, Carl wrote:
\r
70 > On Thu, 19 Nov 2009 16:45:43 +0100, Adrian Perez de Castro <aperez@igalia=
\r
72 > > The thing is that in notmuch_message_get_in_reply_to(), line 288, a NULL
\r
73 > > instance of Xapian::TermIterator is dereferenced. In my particular case,
\r
74 > > the culpript is a cache file of Claws-Mail, as seen in the following GDB
\r
77 > Not quite NULL, (nor is it quite dereferencing---this is nasty C++
\r
78 > overloading), but yeah, the idea is the same. We need to protect all of
\r
79 > our "calls" to this overloaded operator to not call it when the iterator
\r
80 > is equal to the value returned by termlist_end ().
\r
82 Well, of course you are right, it is an overloaded operator, which
\r
83 (unfortunately, IMHO) looks like a pointer dereference. That is exactly
\r
84 one of the things that I find more confusing about C++: it has features
\r
85 like operator overloading which look cool initially, but that in the end
\r
86 imply more complexity than needed. I can understand why you decided to
\r
87 wrap Xapian with a plain C API :)
\r
89 > On Thu, 19 Nov 2009 20:23:15 -0600, Jeffrey Ollie <jeff@ocjtech.us> wrote:
\r
90 > > I straced some of the crashes, and the last file that was read before
\r
91 > > the crash was a malformed message. I've attached one of the messages.
\r
92 > > I've been using offlineimap to sync my gmail mailbox to my laptop so
\r
93 > > that I can use notmuch. offlineimap isn't the most stable program,
\r
94 > > but I'm not sure yet if offlineimap is causing the problem or if
\r
95 > > that's the way the message is in gmail.
\r
97 > Thanks for the file. I never like to push code that I haven't tested, so
\r
98 > this was very helpful.
\r
100 > Below is the patch that I just pushed which seems to do the trick.
\r
102 I can confirm that this patch avoids the segfault in my case, too. Thanks
\r
103 a lot for the quick fix.
\r
108 Adrian Perez de Castro <aperez@igalia.com>
\r
109 Igalia - Free Software Engineering
\r
111 --Sig_/_c1Cg6wI_1TUQe7AmijdlNP
\r
112 Content-Type: application/pgp-signature; name=signature.asc
\r
113 Content-Disposition: attachment; filename=signature.asc
\r
115 -----BEGIN PGP SIGNATURE-----
\r
116 Version: GnuPG v2.0.13 (GNU/Linux)
\r
118 iEYEARECAAYFAksG5+QACgkQkcVZ2+TJEjuYSACcCC0Ciwqu7MG302myWPUO9jP0
\r
119 YqUAnjnjz4N4Cbr7VAt7dkXJMzhjBeuR
\r
121 -----END PGP SIGNATURE-----
\r
123 --Sig_/_c1Cg6wI_1TUQe7AmijdlNP--
\r