1 Return-Path: <cworth@cworth.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id E57E8431FBF;
\r
6 Fri, 20 Nov 2009 16:32:46 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
8 Received: from olra.theworths.org ([127.0.0.1])
\r
9 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
10 with ESMTP id NvMDmGYCJmxD; Fri, 20 Nov 2009 16:32:46 -0800 (PST)
\r
11 Received: from cworth.org (localhost [127.0.0.1])
\r
12 by olra.theworths.org (Postfix) with ESMTP id EE09E431FAE;
\r
13 Fri, 20 Nov 2009 16:32:45 -0800 (PST)
\r
14 From: Carl Worth <cworth@cworth.org>
\r
15 To: Adrian Perez de Castro <aperez@igalia.com>, notmuch@notmuchmail.org
\r
16 In-Reply-To: <20091120200300.55ba8736@hikari>
\r
17 References: <935ead450911181000w2cddfe95qe9efd5bea9f9209d@mail.gmail.com>
\r
18 <20091119164543.25e7afe5@hikari>
\r
19 <935ead450911191823s776fda6eyb6f6949ac982bd03@mail.gmail.com>
\r
20 <87lji11leu.fsf@yoom.home.cworth.org> <20091120200300.55ba8736@hikari>
\r
21 Date: Sat, 21 Nov 2009 01:32:34 +0100
\r
22 Message-ID: <87tywo3efx.fsf@yoom.home.cworth.org>
\r
24 Content-Type: text/plain; charset=us-ascii
\r
25 Subject: Re: [notmuch] Segfault searching for tags
\r
26 X-BeenThere: notmuch@notmuchmail.org
\r
27 X-Mailman-Version: 2.1.12
\r
29 List-Id: "Use and development of the notmuch mail system."
\r
30 <notmuch.notmuchmail.org>
\r
31 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
32 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
33 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
34 List-Post: <mailto:notmuch@notmuchmail.org>
\r
35 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
36 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
37 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
38 X-List-Received-Date: Sat, 21 Nov 2009 00:32:47 -0000
\r
40 On Fri, 20 Nov 2009 20:03:00 +0100, Adrian Perez de Castro <aperez@igalia.com> wrote:
\r
41 > Well, of course you are right, it is an overloaded operator, which
\r
42 > (unfortunately, IMHO) looks like a pointer dereference. That is exactly
\r
43 > one of the things that I find more confusing about C++: it has features
\r
44 > like operator overloading which look cool initially, but that in the end
\r
45 > imply more complexity than needed. I can understand why you decided to
\r
46 > wrap Xapian with a plain C API :)
\r
50 Though I should mention that I earned my summer's salary during an
\r
51 internship once by solving a performance problem that had dodged the
\r
52 engineers on the project, (since they overlooked an overloaded array
\r
53 subscript operator on a std::string class as something that could be
\r
54 expensive---profiling made it obvious, and a temporary copy to a real
\r
55 array with a real subscript fixed the bug).
\r
57 So I can't say that operator overloading never helped me. But I know I
\r
58 left that internship determined not to use it myself.
\r
60 > I can confirm that this patch avoids the segfault in my case, too. Thanks
\r
61 > a lot for the quick fix.
\r
63 Excellent. I'm glad to hear it worked for you.
\r
65 I'm sorry that the bug was there, since this was a regression that's
\r
66 come back once or twice now. The project is overdue for a test suite
\r