1 Return-Path: <pieter@praet.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 96333431FB6
\r
6 for <notmuch@notmuchmail.org>; Wed, 16 Nov 2011 02:58:02 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id I99Y-2kTXp0B for <notmuch@notmuchmail.org>;
\r
16 Wed, 16 Nov 2011 02:58:01 -0800 (PST)
\r
17 Received: from mail-wy0-f181.google.com (mail-wy0-f181.google.com
\r
18 [74.125.82.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id ACAA3429E26
\r
21 for <notmuch@notmuchmail.org>; Wed, 16 Nov 2011 02:58:01 -0800 (PST)
\r
22 Received: by wyg19 with SMTP id 19so335416wyg.26
\r
23 for <notmuch@notmuchmail.org>; Wed, 16 Nov 2011 02:57:59 -0800 (PST)
\r
24 Received: by 10.180.81.73 with SMTP id y9mr34883441wix.37.1321441079192;
\r
25 Wed, 16 Nov 2011 02:57:59 -0800 (PST)
\r
26 Received: from localhost ([109.131.148.49])
\r
27 by mx.google.com with ESMTPS id v6sm16106432wix.1.2011.11.16.02.57.57
\r
28 (version=TLSv1/SSLv3 cipher=OTHER);
\r
29 Wed, 16 Nov 2011 02:57:57 -0800 (PST)
\r
30 From: Pieter Praet <pieter@praet.org>
\r
31 To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
\r
32 Subject: Re: [PATCH] emacs: notmuch-hello: respect notmuch-help's wishes
\r
33 In-Reply-To: <87zkg2a7pd.fsf@rocinante.cs.unb.ca>
\r
35 <87ei522v4t.fsf@A7GMS.i-did-not-set--mail-host-address--so-tickle-me>
\r
36 <87zkg2a7pd.fsf@rocinante.cs.unb.ca>
\r
37 User-Agent: Notmuch/0.9+76~g2fd88e6 (http://notmuchmail.org) Emacs/23.3.1
\r
38 (x86_64-unknown-linux-gnu)
\r
39 Date: Wed, 16 Nov 2011 11:56:59 +0100
\r
40 Message-ID: <87pqgsfi84.fsf@praet.org>
\r
42 Content-Type: text/plain; charset=us-ascii
\r
43 X-BeenThere: notmuch@notmuchmail.org
\r
44 X-Mailman-Version: 2.1.13
\r
46 List-Id: "Use and development of the notmuch mail system."
\r
47 <notmuch.notmuchmail.org>
\r
48 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
49 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
50 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
51 List-Post: <mailto:notmuch@notmuchmail.org>
\r
52 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
53 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
54 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
55 X-List-Received-Date: Wed, 16 Nov 2011 10:58:02 -0000
\r
57 On Fri, 11 Nov 2011 12:29:34 -0500, David Bremner <david@tethera.net> wrote:
\r
58 > On Sat, 16 Apr 2011 15:12:43 +0200, Pieter Praet <pieter@praet.org> wrote:
\r
59 > > Calling notmuch-help in notmuch-hello-mode results in error
\r
60 > > "apply: Wrong type argument: listp, keymap"
\r
64 > I'm a little confused here. I still get the same error after applying
\r
65 > your patch. Is there a followup patch I missed?
\r
68 Hmm, it works here...
\r
71 I've tried cooking up a proper test:
\r
74 test_begin_subtest "Help in notmuch-hello"
\r
75 test_emacs '(let ((major-mode '\''notmuch-hello-mode))
\r
79 Placeholder for actual expected output...
\r
81 test_expect_equal_file OUTPUT EXPECTED
\r
84 ... but I'm making some stupid mistake, because it doesn't output
\r
85 *anything*, not even for `notmuch-search-mode' and `notmuch-show-mode'.
\r
88 It works when running Emacs like this, though:
\r
91 emacs --no-init-file --eval '(progn
\r
92 (add-to-list '\''load-path (concat
\r
93 (getenv "HOME") "/src/dev/notmuch/emacs"))
\r
94 (require '\''notmuch)
\r
100 Anyways, it's a rather lame patch (even more so when taking my horrible
\r
101 typo into consideraton) so I wouldn't waste too much time on it if I
\r
102 were you. Duplication is evil, so this bug should be fixed in
\r
103 `notmuch-substitute-one-command-key-with-prefix' instead.
\r