1 Return-Path: <tomi.ollila@nixu.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id CD6E0431FD0
\r
6 for <notmuch@notmuchmail.org>; Thu, 24 Nov 2011 13:20:41 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id o9y7HBq77rHq for <notmuch@notmuchmail.org>;
\r
16 Thu, 24 Nov 2011 13:20:41 -0800 (PST)
\r
17 Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31])
\r
18 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id AECA6431FB6
\r
21 for <notmuch@notmuchmail.org>; Thu, 24 Nov 2011 13:20:40 -0800 (PST)
\r
22 Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31])
\r
23 by taco2.nixu.fi (8.14.3/8.14.3/Debian-5+lenny1) with ESMTP id
\r
24 pAOLKSbl009571; Thu, 24 Nov 2011 23:20:28 +0200
\r
25 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
26 To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
\r
27 Subject: Re: [PATCH] CLI: update call to notmuch_help_command for new calling
\r
29 In-Reply-To: <1322164961-18523-1-git-send-email-david@tethera.net>
\r
30 References: <1322164961-18523-1-git-send-email-david@tethera.net>
\r
31 User-Agent: Notmuch/0.10+15~gb5803e9 (http://notmuchmail.org) Emacs/23.3.1
\r
33 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
34 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
35 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
36 Date: Thu, 24 Nov 2011 23:20:28 +0200
\r
37 Message-ID: <yf6d3chfc9v.fsf@taco2.nixu.fi>
\r
39 Content-Type: text/plain; charset=us-ascii
\r
40 Cc: David Bremner <bremner@debian.org>
\r
41 X-BeenThere: notmuch@notmuchmail.org
\r
42 X-Mailman-Version: 2.1.13
\r
44 List-Id: "Use and development of the notmuch mail system."
\r
45 <notmuch.notmuchmail.org>
\r
46 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
47 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
48 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
49 List-Post: <mailto:notmuch@notmuchmail.org>
\r
50 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
51 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
52 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
53 X-List-Received-Date: Thu, 24 Nov 2011 21:20:41 -0000
\r
55 On Thu, 24 Nov 2011 16:02:41 -0400, David Bremner <david@tethera.net> wrote:
\r
56 > From: David Bremner <bremner@debian.org>
\r
58 > When I changed the calling convention to pass in all but the zero-th
\r
59 > argument to subcommands, I missed this one call, resulting in a
\r
60 > segmentation fault.
\r
62 LGTM, is analogous to other 'argc -1, &argv[1]' uses and seems to work
\r
63 on top of notmuch 0.10+21~gae7814b
\r
69 > 1 files changed, 1 insertions(+), 1 deletions(-)
\r
71 > diff --git a/notmuch.c b/notmuch.c
\r
72 > index 77973f8..d44ce9a 100644
\r
75 > @@ -621,7 +621,7 @@ main (int argc, char *argv[])
\r
76 > return notmuch (local);
\r
78 > if (STRNCMP_LITERAL (argv[1], "--help") == 0)
\r
79 > - return notmuch_help_command (NULL, 0, NULL);
\r
80 > + return notmuch_help_command (NULL, argc - 1, &argv[1]);
\r
82 > if (STRNCMP_LITERAL (argv[1], "--version") == 0) {
\r
83 > printf ("notmuch " STRINGIFY(NOTMUCH_VERSION) "\n");
\r
87 > _______________________________________________
\r
88 > notmuch mailing list
\r
89 > notmuch@notmuchmail.org
\r
90 > http://notmuchmail.org/mailman/listinfo/notmuch
\r