f0/fe899fc35335f3b63073c024ca8500d5f422d9

   1 Return-Path: <daniel@schoepe.org>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id B660C431FAE\r
   6         for <notmuch@notmuchmail.org>; Wed,  7 Mar 2012 12:04:28 -0800 (PST)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: 0.502\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=0.502 tagged_above=-999 required=5\r
  12         tests=[DKIM_ADSP_CUSTOM_MED=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1,\r
  13         FREEMAIL_FROM=0.001, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_LOW=-0.7]\r
  14         autolearn=disabled\r
  15 Received: from olra.theworths.org ([127.0.0.1])\r
  16         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  17         with ESMTP id WfCAAdAwyfAz for <notmuch@notmuchmail.org>;\r
  18         Wed,  7 Mar 2012 12:04:27 -0800 (PST)\r
  19 Received: from mail-ee0-f53.google.com (mail-ee0-f53.google.com\r
  20  [74.125.83.53])        (using TLSv1 with cipher RC4-SHA (128/128 bits))        (No client\r
  21  certificate requested) by olra.theworths.org (Postfix) with ESMTPS id\r
  22  B3472431FB6    for <notmuch@notmuchmail.org>; Wed,  7 Mar 2012 12:04:27 -0800\r
  23  (PST)\r
  24 Received: by eekb47 with SMTP id b47so3438604eek.26\r
  25         for <notmuch@notmuchmail.org>; Wed, 07 Mar 2012 12:04:26 -0800 (PST)\r
  26 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=schoepe.org; s=google;\r
  27         h=sender:from:to:subject:in-reply-to:references:user-agent:date\r
  28         :message-id:mime-version:content-type;\r
  29         bh=Z6eoupzLnLpynutyx7IZ38iJavFQqT3T4s7wjXmJKUQ=;\r
  30         b=DXpKrLLy9scKxxYPaZo7t6tKx6xihnna06USZfb9XeaiKtfOpZCgKrB2cwhJfy27VV\r
  31         ZZMhGNctHIqsK7gRcNpzkq06tekqbGHhq74fboGtD0TOY1qR5xtXmChGSeC4A2Mr5ymZ\r
  32         l7jXUDrO/a40VTGGdWNgwukqb0CoBqWZSLjRA=\r
  33 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
  34         d=google.com; s=20120113;\r
  35         h=sender:from:to:subject:in-reply-to:references:user-agent:date\r
  36         :message-id:mime-version:content-type:x-gm-message-state;\r
  37         bh=Z6eoupzLnLpynutyx7IZ38iJavFQqT3T4s7wjXmJKUQ=;\r
  38         b=MQzdINQzHdsUuEj6zsdVBhewQicWVlqkbbUMX9zI3Tf8i8sMk/vsgry74pyh/mGVad\r
  39         8T1VBQx3XaQM15IAxjeMqzLIg/Bm3KAThbj52DIfX2A/vWVIAwseAEiVNJ7t2eSAZWow\r
  40         FX2nNfep5LkzgAxNDlYGBqkA1m7fvJEWX4cpxqkC5lP0twBMpkq4YBeT+b1OFFO+k0yM\r
  41         0hfwcw/Tfa+GWONmLFM4FzSL7nt21h2DChzSVJztCEzlaL1C67Z9g+qYg28ECeX8kLhq\r
  42         1ioeJ+qkV+DKENegRW6L8aSh0Qn52woFTFPZ9l15fsPfWcoiHDvVv/WZ1MINDSqOj2M9\r
  43         kSOw==\r
  44 Received: by 10.213.13.72 with SMTP id b8mr847382eba.153.1331150666303;\r
  45         Wed, 07 Mar 2012 12:04:26 -0800 (PST)\r
  46 Received: from localhost (p4FC78F99.dip0.t-ipconnect.de. [79.199.143.153])\r
  47         by mx.google.com with ESMTPS id w9sm19720662eei.8.2012.03.07.12.04.23\r
  48         (version=TLSv1/SSLv3 cipher=OTHER);\r
  49         Wed, 07 Mar 2012 12:04:24 -0800 (PST)\r
  50 Sender: Daniel Schoepe <daniel@schoepe.org>\r
  51 From: Daniel Schoepe <daniel.schoepe@googlemail.com>\r
  52 To: Pieter Praet <pieter@praet.org>, David Bremner <david@tethera.net>,\r
  53         Dmitry Kurochkin <dmitry.kurochkin@gmail.com>, notmuch@notmuchmail.org\r
  54 Subject: Re: [PATCH v10 1/2] emacs: User-defined sections in notmuch-hello\r
  55 In-Reply-To: <87aa3s427n.fsf@praet.org>\r
  56 References: <1310079227-19120-1-git-send-email-daniel.schoepe@googlemail.com>\r
  57         <1329490088-8323-1-git-send-email-dmitry.kurochkin@gmail.com>\r
  58         <1329490088-8323-2-git-send-email-dmitry.kurochkin@gmail.com>\r
  59         <87ipio33ce.fsf@zancas.localnet> <87aa3s427n.fsf@praet.org>\r
  60 User-Agent: Notmuch/0.11.1+309~g6296425 (http://notmuchmail.org)\r
  61         Emacs/24.0.93.1 (x86_64-pc-linux-gnu)\r
  62 Date: Wed, 07 Mar 2012 21:04:17 +0100\r
  63 Message-ID: <87ipigtby6.fsf@schoepe.localhost>\r
  64 MIME-Version: 1.0\r
  65 Content-Type: multipart/signed; boundary="=-=-=";\r
  66         micalg=pgp-sha1; protocol="application/pgp-signature"\r
  67 X-Gm-Message-State:\r
  68  ALoCoQkrQDz1kmgQ4vF0Ux7xbeat1LgQczvuEx1P+qJ0oTI22UkrC1T8JX262cM21koyTfsGu/Z4\r
  69 X-BeenThere: notmuch@notmuchmail.org\r
  70 X-Mailman-Version: 2.1.13\r
  71 Precedence: list\r
  72 List-Id: "Use and development of the notmuch mail system."\r
  73         <notmuch.notmuchmail.org>\r
  74 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  75         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  76 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  77 List-Post: <mailto:notmuch@notmuchmail.org>\r
  78 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  79 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  80         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  81 X-List-Received-Date: Wed, 07 Mar 2012 20:04:28 -0000\r
  82 \r
  83 --=-=-=\r
  84 Content-Type: text/plain\r
  85 Content-Transfer-Encoding: quoted-printable\r
  86 \r
  87 On Wed, 07 Mar 2012 20:53:48 +0100, Pieter Praet <pieter@praet.org> wrote:\r
  88 > On Thu, 01 Mar 2012 08:36:33 -0400, David Bremner <david@tethera.net> wro=\r
  89 te:\r
  90 > >=20\r
  91 > > Pushed, finally. Thanks for both of your hard work on this.\r
  92 > >\r
  93 >=20\r
  94 > 625 lines changed (425 added, 200 removed), in a *single* commit ?\r
  95 >=20\r
  96 > It's a useful bit of functionality which definitely deserves to be\r
  97 > included, and I do recognize and appreciate all the hard work that\r
  98 > went into it, but... am I the only one who was a bit surprised to\r
  99 > see this patch being applied [1] as-is?\r
 100 \r
 101 I think it is hard to split this patch up into meaningful smaller\r
 102 pieces, since it mainly moves parts from notmuch-hello into separate\r
 103 functions and adds some defcustoms. So, the main opportunities for\r
 104 splitting would be to do this moving of code into functions one function\r
 105 per commit and to put the defcustoms and their quite lengthy\r
 106 documentation in a separate commit (which would leave you with an\r
 107 intermediate version that's seriously lacking in documentation).\r
 108 \r
 109 I'm not sure if those two things are that useful, but if there's\r
 110 consensus that the patch shouldn't stay in the way it is, I can give it\r
 111 a shot (although it'd be a lot of tedious work).\r
 112 \r
 113 Cheers,\r
 114 Daniel\r
 115 \r
 116 --=-=-=\r
 117 Content-Type: application/pgp-signature\r
 118 \r
 119 -----BEGIN PGP SIGNATURE-----\r
 120 Version: GnuPG v1.4.12 (GNU/Linux)\r
 121 \r
 122 iQIcBAEBAgAGBQJPV79BAAoJEIaTAtce+Z+Jm8YQAJDID9EyQL4lfLo6iwGh6qNu\r
 123 6ZdimOZ9evbH5aejIV+cqQcRI8gTgidNqWiL3lZG660vPni8pL7Tk8pCboGab13I\r
 124 ezllVagCYYhq2N78WOv1m7xzOrvObHcyH0T5lVVxVrRzymmaLFp09ZYSvU2vwjju\r
 125 k/CpDUwxF3i5l7L664qsnRft2bXoP1HwbZPoSPfQhEYSDZKJ6/nIlwaIBF1C3oUq\r
 126 0Xknemg9XlNBdJQv/OblTLuFMOxRQOuemfVzWVNCT3qJiNhhjhy/MEAE9zyDBAGE\r
 127 RQrEdpehXLyoASTaPMEpqN7tIz8wtHyGRmqQv8epdspzuxBW0reSUHaVg0K4rpTX\r
 128 gG+dd+Tc+Fi45bKC+2QEiWm4+lb7gNSRoIBV8+f9QiCjKrzxp7U/443x0yD9d2SS\r
 129 zn1HGOTBpOQYojfy+19YUtqqcoJDE3FSGPk1jMWt93cM+sM402iVN9O6igmZXG9u\r
 130 Cgg6XlM+mCjrT2qGfxQ5Cv/+itaGDltFDhVY17sLgBJUqD8VR1DkJrjuHiqR8Rh1\r
 131 E+8mrPr0LgUT6C2lk0FhZs4UGc+UUJMNhe8lTW8AASM06Mjx/Uf6PBnZEwQcygRM\r
 132 k7wGAtz35R8q2fhFomV7wmLErMT8vAEV5ZsARQfHNQwQphudSIGsElhZMyxgZsXP\r
 133 ADrTY9Uto9ftAggS5gcC\r
 134 =ZtOc\r
 135 -----END PGP SIGNATURE-----\r
 136 --=-=-=--\r