1 Return-Path: <novalazy@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 1F585429E3B
\r
6 for <notmuch@notmuchmail.org>; Sat, 19 Jan 2013 16:51:14 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id cffW6XnSRCO4 for <notmuch@notmuchmail.org>;
\r
17 Sat, 19 Jan 2013 16:51:13 -0800 (PST)
\r
18 Received: from mail-pb0-f53.google.com (mail-pb0-f53.google.com
\r
19 [209.85.160.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 3B457431FB6
\r
22 for <notmuch@notmuchmail.org>; Sat, 19 Jan 2013 16:51:08 -0800 (PST)
\r
23 Received: by mail-pb0-f53.google.com with SMTP id un1so2034701pbc.26
\r
24 for <notmuch@notmuchmail.org>; Sat, 19 Jan 2013 16:51:07 -0800 (PST)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
\r
26 h=x-received:from:to:cc:subject:date:message-id:x-mailer:in-reply-to
\r
27 :references; bh=H3BnQLcp7qM6T9dqOdr88oaEu/h65qGdjaYrdCtUWYk=;
\r
28 b=xBs7Ond/237gH9KVUlFxs/Md9nwWpF8d8TvhCUjS5mqF5U2vH45yLfCwA1gQJucFna
\r
29 qnmZpEmHqXx+TG+iryvoeVx/ZvvXqkVW8R4iZ5obFdVHg0b7wymw1IOGouJ4wC9cYQ3Y
\r
30 /pg6RLSvDT3VafvUQ5MoMFFjZBz9vxv+RgprBbMRJpVH6T9LCXO2gAkgvwXpU0cB54iF
\r
31 POHAUNu/8AKxKjd9/Q2NQxM/YBpAvV6kbC1XPNLJ5jOH4ry5p0529GptsGwWbDkvCJWy
\r
32 y/AhxR/5J4OEtlHBxAMNkOVQkexX0LlRey/xdhnZv52144Lpg3LUzYK6tv4hNiGvKIM7
\r
34 X-Received: by 10.68.242.134 with SMTP id wq6mr37229489pbc.146.1358643067269;
\r
35 Sat, 19 Jan 2013 16:51:07 -0800 (PST)
\r
36 Received: from localhost (215.42.233.220.static.exetel.com.au.
\r
38 by mx.google.com with ESMTPS id ir4sm5800545pbc.41.2013.01.19.16.51.05
\r
39 (version=TLSv1.2 cipher=RC4-SHA bits=128/128);
\r
40 Sat, 19 Jan 2013 16:51:06 -0800 (PST)
\r
41 From: Peter Wang <novalazy@gmail.com>
\r
42 To: notmuch@notmuchmail.org
\r
43 Subject: [PATCH v3 07/20] tag-util: do not reset list in
\r
44 parse_tag_command_line
\r
45 Date: Sun, 20 Jan 2013 11:49:51 +1100
\r
46 Message-Id: <1358643004-14522-8-git-send-email-novalazy@gmail.com>
\r
47 X-Mailer: git-send-email 1.7.12.1
\r
48 In-Reply-To: <1358643004-14522-1-git-send-email-novalazy@gmail.com>
\r
49 References: <1358643004-14522-1-git-send-email-novalazy@gmail.com>
\r
50 X-BeenThere: notmuch@notmuchmail.org
\r
51 X-Mailman-Version: 2.1.13
\r
53 List-Id: "Use and development of the notmuch mail system."
\r
54 <notmuch.notmuchmail.org>
\r
55 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
56 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
57 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
58 List-Post: <mailto:notmuch@notmuchmail.org>
\r
59 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
60 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
61 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
62 X-List-Received-Date: Sun, 20 Jan 2013 00:51:15 -0000
\r
64 No current callers of parse_tag_command_line require that it clear its
\r
65 tag list argument. The notmuch 'insert' command will be better served
\r
66 if the function modifies a pre-populated list (of new.tags) instead of
\r
67 clobbering it outright.
\r
71 2 files changed, 2 insertions(+), 2 deletions(-)
\r
73 diff --git a/tag-util.c b/tag-util.c
\r
74 index 701d329..3f9da05 100644
\r
77 @@ -165,8 +165,6 @@ parse_tag_command_line (void *ctx, int argc, char **argv,
\r
81 - tag_op_list_reset (tag_ops);
\r
83 for (i = 0; i < argc; i++) {
\r
84 if (strcmp (argv[i], "--") == 0) {
\r
86 diff --git a/tag-util.h b/tag-util.h
\r
87 index 246de85..4628f16 100644
\r
90 @@ -81,6 +81,8 @@ parse_tag_line (void *ctx, char *line,
\r
91 * Output Parameters:
\r
92 * ops contains a list of tag operations
\r
93 * query_str the search terms.
\r
95 + * The ops argument is not cleared.
\r