1 Return-Path: <dmitry.kurochkin@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 02586431E82
\r
6 for <notmuch@notmuchmail.org>; Wed, 15 Feb 2012 11:28:51 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id 6zqbPSZgnwtZ for <notmuch@notmuchmail.org>;
\r
17 Wed, 15 Feb 2012 11:28:46 -0800 (PST)
\r
18 Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com
\r
19 [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 37FBA431E62
\r
22 for <notmuch@notmuchmail.org>; Wed, 15 Feb 2012 11:28:46 -0800 (PST)
\r
23 Received: by bkcit16 with SMTP id it16so1404927bkc.26
\r
24 for <notmuch@notmuchmail.org>; Wed, 15 Feb 2012 11:28:44 -0800 (PST)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
\r
26 h=from:to:subject:in-reply-to:references:user-agent:date:message-id
\r
27 :mime-version:content-type;
\r
28 bh=uiRhPGALUfVeSBcPZrQhRCN8YjgKsnzO0Newk3NUU4o=;
\r
29 b=NsB2xxyeCsBmI2LrToArcJ2yXvcmrym0C7UbUHjbZsgWalHtarWmxnhh9cc/rHKOtH
\r
30 6ywLKy3nINnO6libx3iAIF3wwNehGLsOcU8Z0ooXT8MffYE9GcJSd5s1N9G847QhVxyL
\r
31 JmN4I7SZfIVp7npZ7pbfDavRlbtju2fJUADyA=
\r
32 Received: by 10.204.10.80 with SMTP id o16mr11966953bko.50.1329334120190;
\r
33 Wed, 15 Feb 2012 11:28:40 -0800 (PST)
\r
34 Received: from localhost ([91.144.186.21])
\r
35 by mx.google.com with ESMTPS id x22sm8400017bkw.11.2012.02.15.11.28.38
\r
36 (version=TLSv1/SSLv3 cipher=OTHER);
\r
37 Wed, 15 Feb 2012 11:28:39 -0800 (PST)
\r
38 From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
\r
39 To: Michal Sojka <sojka@os.inf.tu-dresden.de>, notmuch@notmuchmail.org
\r
40 Subject: Re: [PATCH v2] emacs: Fix display of highlighted line in
\r
42 In-Reply-To: <1329239387-6300-1-git-send-email-sojka@os.inf.tu-dresden.de>
\r
43 References: <87mx8lpd5o.fsf@nikula.org>
\r
44 <1329239387-6300-1-git-send-email-sojka@os.inf.tu-dresden.de>
\r
45 User-Agent: Notmuch/0.11.1+188~ga5674c2 (http://notmuchmail.org) Emacs/23.3.1
\r
46 (x86_64-pc-linux-gnu)
\r
47 Date: Wed, 15 Feb 2012 23:27:18 +0400
\r
48 Message-ID: <87wr7ngand.fsf@gmail.com>
\r
50 Content-Type: text/plain; charset=us-ascii
\r
51 X-BeenThere: notmuch@notmuchmail.org
\r
52 X-Mailman-Version: 2.1.13
\r
54 List-Id: "Use and development of the notmuch mail system."
\r
55 <notmuch.notmuchmail.org>
\r
56 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
57 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
58 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
59 List-Post: <mailto:notmuch@notmuchmail.org>
\r
60 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
61 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
62 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
63 X-List-Received-Date: Wed, 15 Feb 2012 19:28:51 -0000
\r
67 On Tue, 14 Feb 2012 18:09:47 +0100, Michal Sojka <sojka@os.inf.tu-dresden.de> wrote:
\r
68 > When notmuch-search-line-faces is used to set background color in search
\r
69 > results, the highlight of the current line is not always displayed
\r
70 > correctly. This patch fixes that by increasing the priority property of
\r
71 > the highlight overlay.
\r
74 How about changing `notmuch-search-color-line' to use text properties
\r
75 instead of overlays? Then hl-line overlay would take priority over it
\r
76 without these changes.
\r
78 See [1] by David Edmondson on why text properties are better in
\r
79 general. I plan to use text properties here to simplify updating the
\r
80 face when tags are changed.
\r
85 [1] id:"1328604377-20121-2-git-send-email-dme@dme.org"
\r
87 > emacs/notmuch.el | 15 +++++++++++----
\r
88 > 1 files changed, 11 insertions(+), 4 deletions(-)
\r
90 > diff --git a/emacs/notmuch.el b/emacs/notmuch.el
\r
91 > index 5b4f1c5..f851c6f 100644
\r
92 > --- a/emacs/notmuch.el
\r
93 > +++ b/emacs/notmuch.el
\r
94 > @@ -249,10 +249,17 @@ For a mouse binding, return nil."
\r
95 > (set-buffer-modified-p nil)
\r
96 > (view-buffer (current-buffer) 'kill-buffer-if-not-modified))))
\r
98 > -(defcustom notmuch-search-hook '(hl-line-mode)
\r
99 > +(require 'hl-line)
\r
101 > +(defun notmuch-hl-line-mode ()
\r
102 > + (prog1 (hl-line-mode)
\r
103 > + (when hl-line-overlay
\r
104 > + (overlay-put hl-line-overlay 'priority 1))))
\r
106 > +(defcustom notmuch-search-hook '(notmuch-hl-line-mode)
\r
107 > "List of functions to call when notmuch displays the search results."
\r
109 > - :options '(hl-line-mode)
\r
110 > + :options '(notmuch-hl-line-mode)
\r
111 > :group 'notmuch-search
\r
112 > :group 'notmuch-hooks)
\r
114 > @@ -567,7 +574,7 @@ a list of strings of the form \"+TAG\" or \"-TAG\".
\r
115 > the messages that are about to be tagged"
\r
118 > - :options '(hl-line-mode)
\r
119 > + :options '(notmuch-hl-line-mode)
\r
120 > :group 'notmuch-hooks)
\r
122 > (defcustom notmuch-after-tag-hook nil
\r
123 > @@ -578,7 +585,7 @@ a list of strings of the form \"+TAG\" or \"-TAG\".
\r
124 > 'query' will be a string containing the search query that determines
\r
125 > the messages that were tagged"
\r
127 > - :options '(hl-line-mode)
\r
128 > + :options '(notmuch-hl-line-mode)
\r
129 > :group 'notmuch-hooks)
\r
131 > (defun notmuch-search-set-tags (tags)
\r
135 > _______________________________________________
\r
136 > notmuch mailing list
\r
137 > notmuch@notmuchmail.org
\r
138 > http://notmuchmail.org/mailman/listinfo/notmuch
\r