1 Return-Path: <jrollins@finestructure.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 23421429E3B
\r
6 for <notmuch@notmuchmail.org>; Sun, 29 Jan 2012 12:07:05 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id 2Pxw8bvMBQhj for <notmuch@notmuchmail.org>;
\r
16 Sun, 29 Jan 2012 12:07:04 -0800 (PST)
\r
17 Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu
\r
19 by olra.theworths.org (Postfix) with ESMTP id 7B988429E34
\r
20 for <notmuch@notmuchmail.org>; Sun, 29 Jan 2012 12:07:04 -0800 (PST)
\r
21 Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1])
\r
22 by earth-doxen-postvirus (Postfix) with ESMTP id 24B4F66E0125;
\r
23 Sun, 29 Jan 2012 12:07:04 -0800 (PST)
\r
24 X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new
\r
25 Received: from finestructure.net (cpe-76-174-137-84.socal.res.rr.com
\r
26 [76.174.137.84]) (Authenticated sender: jrollins)
\r
27 by earth-doxen-submit (Postfix) with ESMTP id 4BD1866E011F;
\r
28 Sun, 29 Jan 2012 12:07:01 -0800 (PST)
\r
29 Received: by finestructure.net (Postfix, from userid 1000)
\r
30 id E2A8D35A; Sun, 29 Jan 2012 12:07:00 -0800 (PST)
\r
31 From: Jameson Graef Rollins <jrollins@finestructure.net>
\r
32 To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org
\r
33 Subject: Re: [PATCH 0/3] reworked crypto toggle, plus a couple of other
\r
35 In-Reply-To: <1327486729-18052-1-git-send-email-dme@dme.org>
\r
36 References: <1327486729-18052-1-git-send-email-dme@dme.org>
\r
37 User-Agent: Notmuch/0.11+131~g7337d96 (http://notmuchmail.org) Emacs/23.3.1
\r
38 (x86_64-pc-linux-gnu)
\r
39 Date: Sun, 29 Jan 2012 12:06:57 -0800
\r
40 Message-ID: <87ehuiz31a.fsf@servo.finestructure.net>
\r
42 Content-Type: multipart/signed; boundary="=-=-=";
\r
43 micalg=pgp-sha256; protocol="application/pgp-signature"
\r
44 X-BeenThere: notmuch@notmuchmail.org
\r
45 X-Mailman-Version: 2.1.13
\r
47 List-Id: "Use and development of the notmuch mail system."
\r
48 <notmuch.notmuchmail.org>
\r
49 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
50 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
51 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
52 List-Post: <mailto:notmuch@notmuchmail.org>
\r
53 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
54 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
55 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
56 X-List-Received-Date: Sun, 29 Jan 2012 20:07:05 -0000
\r
60 On Wed, 25 Jan 2012 10:18:46 +0000, David Edmondson <dme@dme.org> wrote:
\r
61 > The crypto toggle previously worked using an argument to
\r
62 > `notmuch-show' and various other functions and relied on killing and
\r
63 > re-creating the notmuch-show-mode buffer. Various other
\r
64 > pseudo-buffer-local variables were present based on an ad-hoc scheme.
\r
66 > Replace the ad-hoc scheme with real buffer-local variables and then
\r
67 > update `notmuch-show-refresh-view' to erase and re-paint rather than
\r
68 > kill and re-create. Update the crypto switch accordingly.
\r
70 Hey, David. Thank you so much for this! I was really hoping someone
\r
71 would eventually pick this up, and your solution is great! This new
\r
72 behavior is *much* nicer. I really like it.
\r
74 I haven't done a full code review, though, just tested it out. I may
\r
75 not be able to get to it for a while, so please don't hold this patch up
\r
78 > Add two other toggles:
\r
79 > - whether non-matching messages are available,
\r
80 > - the indentation of message contents.
\r
81 > Both of these default to the current behaviour.
\r
83 These new features enabled by this are very cool! I love them both. I
\r
84 bet there are other interesting toggle features that could be enabled by
\r
87 > My inclination is to remove `notmuch-crypto-process-mime' altogether
\r
88 > (declared it an obsolete variable) and allow users to set a default
\r
89 > for `notmuch-show-process-crypto' directly, but that is not done in
\r
90 > this patchset while awaiting feedback.
\r
92 I'm not sure I understand this. `notmuch-show-process-crypto' *is* what
\r
93 sets the default for the `notmuch-show-process-crypto' buffer-local
\r
94 variable. How would you change the current behavior or settings (beyond
\r
95 just a variable rename)?
\r
97 > `notmuch-crypto-process-mime' is used only in notmuch-show.el, so the
\r
98 > setting really belongs there with an appropriate name.
\r
100 I intentionally put this in a separate section in case there were
\r
101 eventually other needs for this setting beyond just show mode. I
\r
102 personally think we should just leave it where it is, particularly since
\r
103 it's been there for a while.
\r
108 Content-Type: application/pgp-signature
\r
110 -----BEGIN PGP SIGNATURE-----
\r
111 Version: GnuPG v1.4.11 (GNU/Linux)
\r
113 iQIcBAEBCAAGBQJPJabhAAoJEO00zqvie6q8+TQQAIqrSKxjk+j6XQVfw7ZKg6eo
\r
114 UHLy5BCh3I3NLwwSIf5lZR5OSUBOQQZ9qZ1dP8j4IwTWr88uq2OKR15HDqXr3453
\r
115 /OCu9HooirzBQN1THjOTusLsPz1gVlO3aEocNGEbFLHk5Ms9C3EcHdjrL4lqtv2s
\r
116 mSUBHKfUXSsnZSwqVqsUjRkgluKYZOP7o+aM3OEiSNt4lMIsBNsQdxv55vDcfhqS
\r
117 TsWXpH1ZsD8T6kNFteRA6MjVjYbEgFqstPx3x6GJ6rJroTYSI2+7O25FanFLG9to
\r
118 3/A7r/53f5R5WJOPvGCEnw3Uv4Df5wP5kJpDWXKzzk9gJAK6s8lxBoSSheQZwdIJ
\r
119 RqMy9cImoFotOsDYmKCXdpMUxna45IN8t+zeE7Zpo2e6WU/TZnYKPGDJTi1g04Fq
\r
120 xx2gdHbL5by451EHKrGUhAG6yc/sSfOWScbF3PgS/5+2r3qinSiMpnDvBSr7PUO1
\r
121 cRNCQOsu7WHeBwCd0vjAMrSzaWYFtjObDue/EPaBN5qC9KAvVzk06NorJcKi4GwE
\r
122 T9ZlF1SKpNhE3wq92agsM4L+KERpAXeYpxFIJdTAIICLcVMEBScnJ6eG4kmp8ROZ
\r
123 ADt1mn/Cyp2OPsjpituhAeynSCtshNreoJbpEvyvkXrU19HXv3AGDi92sz/UWVEA
\r
124 FB0eVmzZW8IwGN41g6W+
\r
126 -----END PGP SIGNATURE-----
\r