1 Return-Path: <pieter@praet.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 40468429E35
\r
6 for <notmuch@notmuchmail.org>; Sat, 14 Jan 2012 00:56:48 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id mokfZI6Zt7YO for <notmuch@notmuchmail.org>;
\r
16 Sat, 14 Jan 2012 00:56:47 -0800 (PST)
\r
17 Received: from mail-we0-f181.google.com (mail-we0-f181.google.com
\r
18 [74.125.82.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 94DE2431FB6
\r
21 for <notmuch@notmuchmail.org>; Sat, 14 Jan 2012 00:56:47 -0800 (PST)
\r
22 Received: by werh12 with SMTP id h12so5735wer.26
\r
23 for <notmuch@notmuchmail.org>; Sat, 14 Jan 2012 00:56:46 -0800 (PST)
\r
24 Received: by 10.216.131.224 with SMTP id m74mr472566wei.52.1326531406383;
\r
25 Sat, 14 Jan 2012 00:56:46 -0800 (PST)
\r
26 Received: from localhost ([109.131.75.86])
\r
27 by mx.google.com with ESMTPS id ee6sm20787449wib.4.2012.01.14.00.56.45
\r
28 (version=TLSv1/SSLv3 cipher=OTHER);
\r
29 Sat, 14 Jan 2012 00:56:45 -0800 (PST)
\r
30 From: Pieter Praet <pieter@praet.org>
\r
31 To: David Bremner <david@tethera.net>
\r
32 Subject: Re: [PATCH] test: cli: getting/setting/removing config values
\r
33 In-Reply-To: <87boq8nu9f.fsf@zancas.localnet>
\r
34 References: <87y5tckf1y.fsf@praet.org>
\r
35 <1326389401-20468-1-git-send-email-pieter@praet.org>
\r
36 <87boq8nu9f.fsf@zancas.localnet>
\r
37 User-Agent: Notmuch/0.10.2+115~gadd29f6 (http://notmuchmail.org) Emacs/23.3.1
\r
38 (x86_64-unknown-linux-gnu)
\r
39 Date: Sat, 14 Jan 2012 09:54:59 +0100
\r
40 Message-ID: <8739bir7do.fsf@praet.org>
\r
42 Content-Type: text/plain; charset=us-ascii
\r
43 Cc: Notmuch Mail <notmuch@notmuchmail.org>
\r
44 X-BeenThere: notmuch@notmuchmail.org
\r
45 X-Mailman-Version: 2.1.13
\r
47 List-Id: "Use and development of the notmuch mail system."
\r
48 <notmuch.notmuchmail.org>
\r
49 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
50 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
51 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
52 List-Post: <mailto:notmuch@notmuchmail.org>
\r
53 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
54 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
55 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
56 X-List-Received-Date: Sat, 14 Jan 2012 08:56:48 -0000
\r
58 On Thu, 12 Jan 2012 23:42:04 -0400, David Bremner <david@tethera.net> wrote:
\r
59 > On Thu, 12 Jan 2012 18:30:01 +0100, Pieter Praet <pieter@praet.org> wrote:
\r
60 > > Should have come before commit 1df71b55
\r
62 > This doesn't seem like an especially helpful commit
\r
63 > message. Editorializing is ok, I guess, but maybe keep it below the
\r
67 You're right. The message I was trying to convey (quite tersely),
\r
68 was that these tests were written in response to commit 1df71b55
\r
69 (and should probably be retroactively ran on 1df71b55~1).
\r
71 I realize now that it could potentially be wrongly interpreted as
\r
72 criticism of sorts, which of course wasn't my intention.
\r
74 Anyways, I ran the tests on both 1df71b55~1 and 1df71b55, and
\r
75 -as expected- everything checks out fine.
\r
77 Amended patch follows.
\r