1 Return-Path: <david@tethera.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id B0D4E431FAF
\r
6 for <notmuch@notmuchmail.org>; Fri, 11 Jul 2014 04:49:07 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id ujqRBAecQr4Z for <notmuch@notmuchmail.org>;
\r
16 Fri, 11 Jul 2014 04:49:02 -0700 (PDT)
\r
17 Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])
\r
18 (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id E6946431FAE
\r
21 for <notmuch@notmuchmail.org>; Fri, 11 Jul 2014 04:49:02 -0700 (PDT)
\r
22 Received: from remotemail by yantan.tethera.net with local (Exim 4.80)
\r
23 (envelope-from <david@tethera.net>)
\r
24 id 1X5ZJw-0004Ry-HP; Fri, 11 Jul 2014 08:48:56 -0300
\r
25 Received: (nullmailer pid 7290 invoked by uid 1000); Fri, 11 Jul 2014
\r
27 From: David Bremner <david@tethera.net>
\r
28 To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
\r
29 Subject: Re: [PATCH 06/11] emacs: Remove broken
\r
30 `notmuch-get-bodypart-content' API
\r
31 In-Reply-To: <1398105468-14317-7-git-send-email-amdragon@mit.edu>
\r
32 References: <1398105468-14317-1-git-send-email-amdragon@mit.edu>
\r
33 <1398105468-14317-7-git-send-email-amdragon@mit.edu>
\r
34 User-Agent: Notmuch/0.18.1+22~gbf82697 (http://notmuchmail.org) Emacs/24.3.1
\r
35 (x86_64-pc-linux-gnu)
\r
36 Date: Fri, 11 Jul 2014 08:48:52 -0300
\r
37 Message-ID: <8738e8p13v.fsf@maritornes.cs.unb.ca>
\r
39 Content-Type: text/plain
\r
40 X-BeenThere: notmuch@notmuchmail.org
\r
41 X-Mailman-Version: 2.1.13
\r
43 List-Id: "Use and development of the notmuch mail system."
\r
44 <notmuch.notmuchmail.org>
\r
45 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
46 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
47 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
48 List-Post: <mailto:notmuch@notmuchmail.org>
\r
49 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
50 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
51 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
52 X-List-Received-Date: Fri, 11 Jul 2014 11:49:07 -0000
\r
54 Austin Clements <amdragon@MIT.EDU> writes:
\r
56 > +This returns the content of the given part as a multibyte Lisp
\r
58 What does "multibyte" mean here? utf8? current encoding?
\r
60 > +string after performing content transfer decoding and any
\r
61 > +necessary charset decoding. It is an error to use this for
\r
62 > +non-text/* parts."
\r
63 > + (let ((content (plist-get part :content)))
\r
64 > + (when (not content)
\r
65 > + ;; Use show --format=sexp to fetch decoded content
\r
66 > + (let* ((args `("show" "--format=sexp" "--include-html"
\r
67 > + ,(format "--part=%s" (plist-get part :id))
\r
68 > + ,@(when process-crypto '("--decrypt"))
\r
69 > + ,(notmuch-id-to-query (plist-get msg :id))))
\r
70 > + (npart (apply #'notmuch-call-notmuch-sexp args)))
\r
71 > + (setq content (plist-get npart :content))
\r
72 > + (when (not content)
\r
73 > + (error "Internal error: No :content from %S" args))))
\r
76 I'm a bit curious at the lack of setting "coding-system-for-read" here.
\r
77 Are we assuming the user has their environment set up correctly? Not so
\r
78 much a criticism as being nervous about everything coding-system
\r
81 I didn't see anything else to object to in this patch or the previous
\r