eb/3f52322752f0f39b6cf36d4af0315fde940b58

   1 Return-Path: <tomi.ollila@nixu.com>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id 6D893429E21\r
   6         for <notmuch@notmuchmail.org>; Wed, 11 Jan 2012 07:22:46 -0800 (PST)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: 0\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
  12         autolearn=disabled\r
  13 Received: from olra.theworths.org ([127.0.0.1])\r
  14         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  15         with ESMTP id kKOZ04wqX4ka for <notmuch@notmuchmail.org>;\r
  16         Wed, 11 Jan 2012 07:22:44 -0800 (PST)\r
  17 Received: from mail-gw3.nixu.fi (mail-gw3.nixu.fi [193.209.237.7])\r
  18         (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
  19         (No client certificate requested)\r
  20         by olra.theworths.org (Postfix) with ESMTPS id 53F5C431FB6\r
  21         for <notmuch@notmuchmail.org>; Wed, 11 Jan 2012 07:22:44 -0800 (PST)\r
  22 Received: from pps.filterd (mail-gw3 [127.0.0.1])\r
  23         by mail-gw3.nixu.fi (8.14.4/8.14.4) with SMTP id q0BFMWPC014682;\r
  24         Wed, 11 Jan 2012 17:22:32 +0200\r
  25 Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31])\r
  26         by mail-gw3.nixu.fi with ESMTP id 114cs0yvka-1\r
  27         (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
  28         Wed, 11 Jan 2012 17:22:31 +0200\r
  29 Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31])\r
  30         by taco2.nixu.fi (8.14.3/8.14.3/Debian-5+lenny1) with ESMTP id\r
  31         q0BFMQcv032442; Wed, 11 Jan 2012 17:22:26 +0200\r
  32 From: Tomi Ollila <tomi.ollila@iki.fi>\r
  33 To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org\r
  34 Subject: Re: [PATCH 2/2] notmuch-reply.c: uncrustify\r
  35 In-Reply-To: <1326197228-10356-3-git-send-email-david@tethera.net>\r
  36 References: <1324135695-15487-1-git-send-email-david@tethera.net>\r
  37         <1326197228-10356-1-git-send-email-david@tethera.net>\r
  38         <1326197228-10356-3-git-send-email-david@tethera.net>\r
  39 User-Agent: Notmuch/0.10.2+176~g3f9d738 (http://notmuchmail.org) Emacs/23.3.1\r
  40         (i686-pc-linux-gnu)\r
  41 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
  42         $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
  43         !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
  44 Date: Wed, 11 Jan 2012 17:22:26 +0200\r
  45 Message-ID: <yf6lipe4631.fsf@taco2.nixu.fi>\r
  46 MIME-Version: 1.0\r
  47 Content-Type: text/plain; charset=us-ascii\r
  48 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.5.7110,\r
  49  1.0.211,       0.0.0000        definitions=2012-01-11_03:2012-01-11, 2012-01-11,\r
  50         1970-01-01 signatures=0\r
  51 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0\r
  52         ipscore=0 suspectscore=0\r
  53         phishscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0\r
  54         reason=mlx\r
  55         scancount=1 engine=6.0.2-1012030000 definitions=main-1201110124\r
  56 Cc: David Bremner <bremner@debian.org>\r
  57 X-BeenThere: notmuch@notmuchmail.org\r
  58 X-Mailman-Version: 2.1.13\r
  59 Precedence: list\r
  60 List-Id: "Use and development of the notmuch mail system."\r
  61         <notmuch.notmuchmail.org>\r
  62 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  63         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  64 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  65 List-Post: <mailto:notmuch@notmuchmail.org>\r
  66 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  67 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  68         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  69 X-List-Received-Date: Wed, 11 Jan 2012 15:22:46 -0000\r
  70 \r
  71 On Tue, 10 Jan 2012 08:07:08 -0400, David Bremner <david@tethera.net> wrote:\r
  72 > From: David Bremner <bremner@debian.org>\r
  73 > \r
  74 > This patch shows the raw result of running uncrustify on notmuch-reply.c.\r
  75 > The re-indenting of "format_reply" would probably not be desirable.\r
  76 \r
  77 Nice! It's easy to 'cherry-revert' that part. I wonder is using comments\r
  78 could be used to preserver formatting in format_reply (and is that is\r
  79 something wished to be done) i.e. something like:\r
  80 \r
  81 static const notmuch_show_format_t format_reply = {\r
  82     "",\r
  83   /* */ "", NULL,\r
  84   /* ... */ "", NULL, reply_headers_message_part, ">\n",\r
  85   /* ... */ "",\r
  86   /* ....... */ NULL,\r
  87   /* ....... */ NULL,\r
  88   /* ....... */ NULL,\r
  89   /* ....... */ reply_part_content,\r
  90   /* ....... */ NULL,\r
  91   /* ....... */ "",\r
  92   /* ... */ "",\r
  93   /* */ "", "",\r
  94 \r
  95 \r
  96 > ---\r
  97 >  notmuch-reply.c |  160 +++++++++++++++++++++++++-----------------------------\r
  98 >  1 files changed, 74 insertions(+), 86 deletions(-)\r
  99 > \r
 100 > diff --git a/notmuch-reply.c b/notmuch-reply.c\r
 101 > index 000f6da..00c9923 100644\r
 102 > --- a/notmuch-reply.c\r
 103 > +++ b/notmuch-reply.c\r
 104 > @@ -32,17 +32,17 @@ reply_part_content (GMimeObject *part);\r
 105 >  \r
 106 >  static const notmuch_show_format_t format_reply = {\r
 107 >      "",\r
 108 > -     "", NULL,\r
 109 > -         "", NULL, reply_headers_message_part, ">\n",\r
 110 > -         "",\r
 111 > -             NULL,\r
 112 > -             NULL,\r
 113 > -             NULL,\r
 114 > -             reply_part_content,\r
 115 > -             NULL,\r
 116 > -             "",\r
 117 > -         "",\r
 118 > -     "", "",\r
 119 > +    "", NULL,\r
 120 > +    "", NULL, reply_headers_message_part, ">\n",\r
 121 > +    "",\r
 122 > +    NULL,\r
 123 > +    NULL,\r
 124 > +    NULL,\r
 125 > +    reply_part_content,\r
 126 > +    NULL,\r
 127 > +    "",\r
 128 > +    "",\r
 129 > +    "", "",\r