1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 4C611431FBD
\r
6 for <notmuch@notmuchmail.org>; Wed, 31 Oct 2012 04:35:31 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id ku5pEWhvnT4h for <notmuch@notmuchmail.org>;
\r
16 Wed, 31 Oct 2012 04:35:30 -0700 (PDT)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by olra.theworths.org (Postfix) with ESMTP id ECA60431FBC
\r
19 for <notmuch@notmuchmail.org>; Wed, 31 Oct 2012 04:35:29 -0700 (PDT)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id CFB2E10007D;
\r
22 Wed, 31 Oct 2012 13:35:29 +0200 (EET)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
\r
25 Subject: Re: [PATCH v6 0/9] notmuch search date:since..until query support
\r
26 In-Reply-To: <cover.1351626272.git.jani@nikula.org>
\r
27 References: <cover.1351626272.git.jani@nikula.org>
\r
28 User-Agent: Notmuch/0.14+59~gf9031cd (http://notmuchmail.org) Emacs/24.2.1
\r
29 (x86_64-unknown-linux-gnu)
\r
30 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
31 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
32 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
33 Date: Wed, 31 Oct 2012 13:35:29 +0200
\r
34 Message-ID: <m2mwz2nabi.fsf@guru.guru-group.fi>
\r
36 Content-Type: text/plain
\r
37 X-BeenThere: notmuch@notmuchmail.org
\r
38 X-Mailman-Version: 2.1.13
\r
40 List-Id: "Use and development of the notmuch mail system."
\r
41 <notmuch.notmuchmail.org>
\r
42 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
43 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
44 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
45 List-Post: <mailto:notmuch@notmuchmail.org>
\r
46 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
47 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
48 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
49 X-List-Received-Date: Wed, 31 Oct 2012 11:35:31 -0000
\r
51 On Tue, Oct 30 2012, Jani Nikula <jani@nikula.org> wrote:
\r
53 > Hi all, v6 of [1] with plenty of small changes addressing Austin's
\r
54 > review [2], [3], [4], and [5]. See my replies to Austin for what I've
\r
55 > agreed to change, and what I've chosen to ignore and why.
\r
57 > The single biggest change is the requirement to have some delimiter(s)
\r
58 > between keywords, which allowed simplification of keyword
\r
59 > matching. Consequently match_keyword() and parse_keyword() functions in
\r
60 > patch 2/9 have changed considerably.
\r
62 > There are a few ways to examine the changes since v5. My public repo at
\r
63 > [6] has branches topic-parse-time-string-v5 (rebased to master) and
\r
64 > topic-parse-time-string-v6, and [7] should provide a fancy colorful diff
\r
65 > between the two. The same but less fancy diff is also at the end of this
\r
68 > Change by change commits to the parser and test tool can also be found
\r
69 > at [8]. The source files there are copied verbatim to patches 2/9 and
\r
81 > [1] id:cover.1350854171.git.jani@nikula.org
\r
82 > [2] id:20121022081444.GM14861@mit.edu for patch 2/9
\r
83 > [3] id:20121023042326.GP14861@mit.edu for patch 4/9
\r
84 > [4] id:20121023045255.GQ14861@mit.edu for patch 6/9
\r
85 > [5] id:20121024210841.GU14861@mit.edu for patch 8/9
\r
86 > [6] https://gitorious.org/jani/notmuch
\r
87 > [7] https://gitorious.org/jani/notmuch/commit/06c76eb4181bc88eccabc419c690046682125d7a/diffs/ef5e8d111748784433f4b80c9e5378f0c1a57319
\r
88 > [8] https://gitorious.org/parse-time-string/parse-time-string
\r
91 > build: drop the -Wswitch-enum warning
\r
92 > parse-time-string: add a date/time parser to notmuch
\r
93 > test: add new test tool parse-time for date/time parser
\r
94 > test: add smoke tests for the date/time parser module
\r
95 > build: build parse-time-string as part of the notmuch lib and static
\r
97 > lib: add date range query support
\r
98 > test: add tests for date:since..until range queries
\r
99 > man: document the date:since..until range queries
\r
100 > NEWS: date range search support
\r
103 > Makefile.local | 2 +-
\r
106 > lib/Makefile.local | 3 +-
\r
107 > lib/database-private.h | 1 +
\r
108 > lib/database.cc | 5 +
\r
109 > lib/parse-time-vrp.cc | 61 ++
\r
110 > lib/parse-time-vrp.h | 40 +
\r
111 > man/man7/notmuch-search-terms.7 | 150 +++-
\r
112 > parse-time-string/Makefile | 5 +
\r
113 > parse-time-string/Makefile.local | 12 +
\r
114 > parse-time-string/README | 9 +
\r
115 > parse-time-string/parse-time-string.c | 1503 +++++++++++++++++++++++++++++++++
\r
116 > parse-time-string/parse-time-string.h | 102 +++
\r
117 > test/Makefile.local | 7 +-
\r
118 > test/basic | 2 +-
\r
119 > test/notmuch-test | 2 +
\r
120 > test/parse-time-string | 78 ++
\r
121 > test/parse-time.c | 314 +++++++
\r
122 > test/search-date | 21 +
\r
123 > 21 files changed, 2315 insertions(+), 18 deletions(-)
\r
124 > create mode 100644 lib/parse-time-vrp.cc
\r
125 > create mode 100644 lib/parse-time-vrp.h
\r
126 > create mode 100644 parse-time-string/Makefile
\r
127 > create mode 100644 parse-time-string/Makefile.local
\r
128 > create mode 100644 parse-time-string/README
\r
129 > create mode 100644 parse-time-string/parse-time-string.c
\r
130 > create mode 100644 parse-time-string/parse-time-string.h
\r
131 > create mode 100755 test/parse-time-string
\r
132 > create mode 100644 test/parse-time.c
\r
133 > create mode 100755 test/search-date
\r