1 Return-Path: <amdragon@mit.edu>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 03E2C431FB6
\r
6 for <notmuch@notmuchmail.org>; Sun, 13 May 2012 16:15:18 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id aldJS7O-BgTW for <notmuch@notmuchmail.org>;
\r
16 Sun, 13 May 2012 16:15:17 -0700 (PDT)
\r
17 Received: from dmz-mailsec-scanner-6.mit.edu (DMZ-MAILSEC-SCANNER-6.MIT.EDU
\r
19 by olra.theworths.org (Postfix) with ESMTP id 74FF2431FAE
\r
20 for <notmuch@notmuchmail.org>; Sun, 13 May 2012 16:15:17 -0700 (PDT)
\r
21 X-AuditID: 12074423-b7fcc6d0000008a8-ba-4fb04084be8f
\r
22 Received: from mailhub-auth-1.mit.edu ( [18.9.21.35])
\r
23 by dmz-mailsec-scanner-6.mit.edu (Symantec Messaging Gateway) with SMTP
\r
24 id 11.A8.02216.48040BF4; Sun, 13 May 2012 19:15:16 -0400 (EDT)
\r
25 Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])
\r
26 by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id q4DNFFd9024220;
\r
27 Sun, 13 May 2012 19:15:15 -0400
\r
28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])
\r
29 (authenticated bits=0)
\r
30 (User authenticated as amdragon@ATHENA.MIT.EDU)
\r
31 by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q4DNFDdr028317
\r
32 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);
\r
33 Sun, 13 May 2012 19:15:13 -0400 (EDT)
\r
34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)
\r
35 (envelope-from <amdragon@mit.edu>)
\r
36 id 1STi0O-0005Va-UH; Sun, 13 May 2012 19:15:12 -0400
\r
37 Date: Sun, 13 May 2012 19:15:12 -0400
\r
38 From: Austin Clements <amdragon@MIT.EDU>
\r
39 To: Justus Winter <4winter@informatik.uni-hamburg.de>
\r
40 Subject: Re: [PATCH 2/5] go: Update for changes to
\r
41 notmuch_database_get_directory
\r
42 Message-ID: <20120513231512.GN11804@mit.edu>
\r
43 References: <1336939029-13969-1-git-send-email-amdragon@mit.edu>
\r
44 <1336939029-13969-3-git-send-email-amdragon@mit.edu>
\r
45 <20120513215135.15106.40581@thinkbox.jade-hamburg.de>
\r
47 Content-Type: text/plain; charset=us-ascii
\r
48 Content-Disposition: inline
\r
49 In-Reply-To: <20120513215135.15106.40581@thinkbox.jade-hamburg.de>
\r
50 User-Agent: Mutt/1.5.21 (2010-09-15)
\r
51 X-Brightmail-Tracker:
\r
52 H4sIAAAAAAAAA+NgFprHKsWRmVeSWpSXmKPExsUixCmqrNvisMHf4PFmG4vZrT+YLG60djNa
\r
53 NE13trh+cyazxZuV81gdWD0Of13I4jHx/Gk2j1v3X7N7PFt1i9ljy6H3zAGsUVw2Kak5mWWp
\r
54 Rfp2CVwZM+ZtYC44yF7xbhlrA2MDWxcjJ4eEgInEnyVHmSBsMYkL99YDxbk4hAT2MUrsaZ3A
\r
55 BOFsYJRo7F3IDOGcZJL4PXEmlLOEUaJ5wWNWkH4WAVWJ90c2gs1lE9CQ2LZ/OSOILSJgKrHh
\r
56 wQN2EJtZIEZizdqbQGM5OIQFgiW2XnYDMXkFdCQWrpUFqRASWM8osWyzLojNKyAocXLmExaI
\r
57 Ti2JG/9egnUyC0hLLP/HARLmFHCSOP5iHtgBogIqElNObmObwCg0C0n3LCTdsxC6FzAyr2KU
\r
58 Tcmt0s1NzMwpTk3WLU5OzMtLLdI108vNLNFLTSndxAiKBnYX5R2Mfw4qHWIU4GBU4uF9abrB
\r
59 X4g1say4MvcQoyQHk5Io7047oBBfUn5KZUZicUZ8UWlOavEhRgkOZiUR3vUP1/sL8aYkVlal
\r
60 FuXDpKQ5WJTEeTW03vkJCaQnlqRmp6YWpBbBZGU4OJQkeLfaAw0VLEpNT61Iy8wpQUgzcXCC
\r
61 DOcBGq4DUsNbXJCYW5yZDpE/xagoJc67GiQhAJLIKM2D64Ulq1eM4kCvCPP2gVTxABMdXPcr
\r
62 oMFMQIP5BdaBDC5JREhJNTDGhJ/3LG0Rt9GVXpvyy3rn6wsSG96buxqGffBf4Dtvm4e64fUP
\r
63 uZ6sQlv1d6+O2JN5TpztfPSqFm6Z9E2/apidTDhm7vdsiwnYv0NOruCm0VnGaJc0mbX7Fq1e
\r
64 EOT34sj7vmhL8TWGzxeu6LWdIF6UcPC0+OmFkdLVB9zTZasaC4RvLxXymanEUpyRaKjFXFSc
\r
66 Cc: tomi.ollila@iki.fi, notmuch@notmuchmail.org
\r
67 X-BeenThere: notmuch@notmuchmail.org
\r
68 X-Mailman-Version: 2.1.13
\r
70 List-Id: "Use and development of the notmuch mail system."
\r
71 <notmuch.notmuchmail.org>
\r
72 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
73 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
74 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
75 List-Post: <mailto:notmuch@notmuchmail.org>
\r
76 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
77 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
78 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
79 X-List-Received-Date: Sun, 13 May 2012 23:15:18 -0000
\r
81 Quoth Justus Winter on May 13 at 11:51 pm:
\r
84 > thanks for taking care of this.
\r
86 > Quoting Austin Clements (2012-05-13 21:57:06)
\r
88 > > bindings/go/src/notmuch/notmuch.go | 13 +++++++------
\r
89 > > bindings/python/notmuch/database.py | 4 ++--
\r
91 > A change to the python bindings slipped into this one.
\r
93 Sure enough. I'll send a v2 that moves that hunk to the python patch.
\r
95 > Other than that this looks good.
\r
97 > I just saw that I marked another function as problematic,
\r
98 > notmuch_database_find_message_by_filename ends up calling
\r
99 > _notmuch_directory_create that aborts if the database is not
\r
100 > writable. But this might have to wait and might not even requira an
\r
103 Right. notmuch_database_find_message_by_filename already has a status
\r
104 return, so its API is fine. (Actually, I was starting to fix its
\r
105 implementation when I realized notmuch_database_get_directory was
\r