1 Return-Path: <jani@nikula.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 144B5431FAF
\r
6 for <notmuch@notmuchmail.org>; Thu, 24 Jan 2013 00:01:33 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id MtqO0brGzmbM for <notmuch@notmuchmail.org>;
\r
16 Thu, 24 Jan 2013 00:01:30 -0800 (PST)
\r
17 Received: from mail-bk0-f46.google.com (mail-bk0-f46.google.com
\r
18 [209.85.214.46]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 964E1431FAE
\r
21 for <notmuch@notmuchmail.org>; Thu, 24 Jan 2013 00:01:30 -0800 (PST)
\r
22 Received: by mail-bk0-f46.google.com with SMTP id q16so5009331bkw.33
\r
23 for <notmuch@notmuchmail.org>; Thu, 24 Jan 2013 00:01:29 -0800 (PST)
\r
24 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
\r
25 d=google.com; s=20120113;
\r
26 h=x-received:from:to:cc:subject:in-reply-to:references:user-agent
\r
27 :date:message-id:mime-version:content-type:x-gm-message-state;
\r
28 bh=EqwnQFvzLDurulgknS6SWGxRVKt/JN4fZksim2NQDHc=;
\r
29 b=OEaLfI/4pHUEf75wQmOR9jlSwQpf3jtfSNKItCkJRbBABiuIOIxKih740H8ZySNA4c
\r
30 kM0Ugldge0/AdoELqjZEMjzNAnVO00S3LufK4/qLHrV7pS1Z7P9+16frTi+QHJBfJR+K
\r
31 qZSoJjzMuA74vBkrlB26y0c5sR84JGodaIjUK/LsafRmGxpmtGwuTvIbSmV6ztK18JhV
\r
32 vPuXWiRARwFlO8MWB5tCX+3wsK24T8kJoIaui8q+y50PGJSiGI5EEJk8WtquaCMGvRSm
\r
33 cbhG+3ajcgROFrb/nDPZygL5HVLz3S2LOV/UKagCTNKLIN/lrJgIThkeMcMEQt++4rDX
\r
35 X-Received: by 10.204.145.217 with SMTP id e25mr473578bkv.123.1359014487574;
\r
36 Thu, 24 Jan 2013 00:01:27 -0800 (PST)
\r
37 Received: from localhost ([2001:4b98:dc0:43:216:3eff:fe1b:25f3])
\r
38 by mx.google.com with ESMTPS id c10sm15920340bkw.1.2013.01.24.00.01.25
\r
39 (version=TLSv1.1 cipher=RC4-SHA bits=128/128);
\r
40 Thu, 24 Jan 2013 00:01:26 -0800 (PST)
\r
41 From: Jani Nikula <jani@nikula.org>
\r
42 To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
\r
43 Subject: Re: [PATCH V3 1/1] test/test-lib.sh: use vt100 as dtach terminal if
\r
44 TERM dumb or unset/empty
\r
45 In-Reply-To: <1359013142-3329-1-git-send-email-tomi.ollila@iki.fi>
\r
46 References: <1359011360-15591-1-git-send-email-tomi.ollila@iki.fi>
\r
47 <1359013142-3329-1-git-send-email-tomi.ollila@iki.fi>
\r
48 User-Agent: Notmuch/0.14+259~gdee88db (http://notmuchmail.org) Emacs/23.2.1
\r
49 (x86_64-pc-linux-gnu)
\r
50 Date: Thu, 24 Jan 2013 09:01:19 +0100
\r
51 Message-ID: <87zjzzj9gw.fsf@nikula.org>
\r
53 Content-Type: text/plain; charset=us-ascii
\r
55 ALoCoQlIjcrJi5FTKUz3o+UpUTAmbcL2w9R9UMzSAYcRGAEJo+uqt5UNRQgwH40DPiG2BDYP7rSW
\r
56 Cc: tomi.ollila@iki.fi
\r
57 X-BeenThere: notmuch@notmuchmail.org
\r
58 X-Mailman-Version: 2.1.13
\r
60 List-Id: "Use and development of the notmuch mail system."
\r
61 <notmuch.notmuchmail.org>
\r
62 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
63 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
64 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
65 List-Post: <mailto:notmuch@notmuchmail.org>
\r
66 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
67 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
68 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
69 X-List-Received-Date: Thu, 24 Jan 2013 08:01:33 -0000
\r
74 On Thu, 24 Jan 2013, Tomi Ollila <tomi.ollila@iki.fi> wrote:
\r
75 > The TERM environment variable is set to 'dumb' when running tests, but
\r
76 > the original value of it is stored for echoing colors and running emacs
\r
77 > (somewhat interactively) in detached session. Emacs requires some
\r
78 > terminal control sequences to be available for interactive operation.
\r
79 > In case original TERM is (also) 'dumb' (or unset/empty) emacs cannot
\r
80 > run interactively. To fix this problem dtach (and emacs as it's child
\r
81 > process) is run with TERM=vt100 in case original TERM was unset, empty
\r
82 > or 'dumb'. This way there is a chance to run emacs tests with different
\r
83 > user terminals and potentially find problems there.
\r
86 > Obsoletes id:1359011360-15591-1-git-send-email-tomi.ollila@iki.fi
\r
88 > To be accurate (instead of potentially confusing), the commit
\r
89 > message and comments have been edited to mention 'unset or empty'
\r
90 > instead of 'nonexistent'. No functional changes (to neither v1 or v2
\r
93 > test/test-lib.sh | 9 +++++++--
\r
94 > 1 file changed, 7 insertions(+), 2 deletions(-)
\r
96 > diff --git a/test/test-lib.sh b/test/test-lib.sh
\r
97 > index 6ce3b31..1567178 100644
\r
98 > --- a/test/test-lib.sh
\r
99 > +++ b/test/test-lib.sh
\r
100 > @@ -41,6 +41,10 @@ esac
\r
101 > # Keep the original TERM for say_color and test_emacs
\r
102 > ORIGINAL_TERM=$TERM
\r
104 > +# dtach(1) provides more capable terminal environment to anything
\r
105 > +# that requires more than dumb terminal...
\r
106 > +[ x"${TERM:-dumb}" = xdumb ] && DTACH_TERM=vt100 || DTACH_TERM=$TERM
\r
108 > # For repeatability, reset the environment to known value.
\r
111 > @@ -996,9 +1000,10 @@ test_emacs () {
\r
113 > server_name="notmuch-test-suite-$$"
\r
114 > # start a detached session with an emacs server
\r
115 > - # user's TERM is given to dtach which assumes a minimally
\r
116 > + # user's TERM (or 'vt100' in case user's TERM is unset, empty
\r
117 > + # or 'dumb') is given to dtach which assumes a minimally
\r
118 > # VT100-compatible terminal -- and emacs inherits that
\r
119 > - TERM=$ORIGINAL_TERM dtach -n "$TEST_TMPDIR/emacs-dtach-socket.$$" \
\r
120 > + TERM=$DTACH_TERM dtach -n "$TEST_TMPDIR/emacs-dtach-socket.$$" \
\r
121 > sh -c "stty rows 24 cols 80; exec '$TMP_DIRECTORY/run_emacs' \
\r
122 > --no-window-system \
\r
123 > $load_emacs_tests \
\r
127 > _______________________________________________
\r
128 > notmuch mailing list
\r
129 > notmuch@notmuchmail.org
\r
130 > http://notmuchmail.org/mailman/listinfo/notmuch
\r