1 Return-Path: <cworth@cworth.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 4181F431FD0
\r
6 for <notmuch@notmuchmail.org>; Tue, 7 Dec 2010 15:33:20 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.99 tagged_above=-999 required=5
\r
12 tests=[ALL_TRUSTED=-1, T_MIME_NO_TEXT=0.01] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id 8b-c0L0pWqaJ; Tue, 7 Dec 2010 15:33:18 -0800 (PST)
\r
16 Received: from yoom.home.cworth.org (localhost [127.0.0.1])
\r
17 by olra.theworths.org (Postfix) with ESMTP id A87B0431FB5;
\r
18 Tue, 7 Dec 2010 15:33:18 -0800 (PST)
\r
19 Received: by yoom.home.cworth.org (Postfix, from userid 1000)
\r
20 id 4FA932540E7; Tue, 7 Dec 2010 15:33:18 -0800 (PST)
\r
21 From: Carl Worth <cworth@cworth.org>
\r
22 To: Michal Sojka <sojkam1@fel.cvut.cz>, notmuch@notmuchmail.org
\r
23 Subject: Re: [PATCH 3/5] test: Break on test script (or other) error
\r
24 In-Reply-To: <1289771672-9204-3-git-send-email-sojkam1@fel.cvut.cz>
\r
25 References: <87hbfjr2sr.fsf@steelpick.2x.cz>
\r
26 <1289771672-9204-3-git-send-email-sojkam1@fel.cvut.cz>
\r
27 User-Agent: Notmuch/0.5 (http://notmuchmail.org) Emacs/23.2.1
\r
29 Date: Tue, 07 Dec 2010 15:33:18 -0800
\r
30 Message-ID: <878w015fb5.fsf@yoom.home.cworth.org>
\r
32 Content-Type: multipart/signed; boundary="=-=-=";
\r
33 micalg=pgp-sha1; protocol="application/pgp-signature"
\r
34 X-BeenThere: notmuch@notmuchmail.org
\r
35 X-Mailman-Version: 2.1.13
\r
37 List-Id: "Use and development of the notmuch mail system."
\r
38 <notmuch.notmuchmail.org>
\r
39 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
40 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
41 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
42 List-Post: <mailto:notmuch@notmuchmail.org>
\r
43 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
44 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
45 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
46 X-List-Received-Date: Tue, 07 Dec 2010 23:33:20 -0000
\r
49 Content-Transfer-Encoding: quoted-printable
\r
51 On Sun, 14 Nov 2010 22:54:30 +0100, Michal Sojka <sojkam1@fel.cvut.cz> wrot=
\r
53 > Break notmuch-test whenever a test script returns non-zero status.
\r
54 > This happens either when some test from the script fails or when there
\r
55 > is an error in the script.
\r
57 > This is especially useful in the latter case since the error may not
\r
58 > appear in the final aggregated results.
\r
62 I'm reverting this patch now, with the following commit message:
\r
64 Revert "test: Break on test script (or other) error"
\r
66 This reverts commit f22a7ec1e28d1264cf9d67d78796b8ab22e09a35.
\r
68 Interrupting the test suite due to an actual bug in a test script
\r
69 would be just fine, but interrupting the run of the entire test suite
\r
70 at the first test failure is unacceptable.
\r
72 As I say there, if we could detect an actual bug in the test script, and
\r
73 only interrupt then, then that would be great, (perhaps using some value
\r
74 other than 1 for the test-failure indication in test_done?).
\r
76 As it is, though, I'm implementing a fix for a BROKEN test case in one
\r
77 script, and that's causing a failure in an earlier test script. And the
\r
78 interruption is causing me pain since the script I *really* want to run
\r
79 isn't even getting run.
\r
81 Let me know if you've got some good ideas for a better fix here.
\r
86 carl.d.worth@intel.com
\r
89 Content-Type: application/pgp-signature
\r
91 -----BEGIN PGP SIGNATURE-----
\r
92 Version: GnuPG v1.4.10 (GNU/Linux)
\r
94 iD8DBQFM/sQ+6JDdNq8qSWgRAgOQAJ48GsE/6tC3/Wl2yp7oFY9/MNekBwCfeDnz
\r
95 3PYS+jbcCTs6vW0NtIfDxEM=
\r
97 -----END PGP SIGNATURE-----
\r