1 Return-Path: <pieter@praet.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id D9DCE429E5B
\r
6 for <notmuch@notmuchmail.org>; Wed, 1 Feb 2012 05:48:24 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id uov+nht-Kroi for <notmuch@notmuchmail.org>;
\r
16 Wed, 1 Feb 2012 05:48:22 -0800 (PST)
\r
17 Received: from mail-ww0-f45.google.com (mail-ww0-f45.google.com
\r
18 [74.125.82.45]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client
\r
19 certificate requested) by olra.theworths.org (Postfix) with ESMTPS id
\r
20 2A8AB431FAF for <notmuch@notmuchmail.org>; Wed, 1 Feb 2012 05:48:22 -0800
\r
22 Received: by wgbdt12 with SMTP id dt12so1141819wgb.2
\r
23 for <notmuch@notmuchmail.org>; Wed, 01 Feb 2012 05:48:21 -0800 (PST)
\r
24 Received: by 10.180.93.132 with SMTP id cu4mr11097687wib.9.1328104100875;
\r
25 Wed, 01 Feb 2012 05:48:20 -0800 (PST)
\r
26 Received: from localhost ([109.131.39.11])
\r
27 by mx.google.com with ESMTPS id t6sm44901431wid.1.2012.02.01.05.48.19
\r
28 (version=TLSv1/SSLv3 cipher=OTHER);
\r
29 Wed, 01 Feb 2012 05:48:20 -0800 (PST)
\r
30 From: Pieter Praet <pieter@praet.org>
\r
31 To: David Edmondson <dme@dme.org>, David Bremner <david@tethera.net>,
\r
32 Jani Nikula <jani@nikula.org>
\r
33 Subject: Re: [PATCH] emacs: globally replace non-branching "(if COND (progn
\r
34 ..." with "(when ..."
\r
35 In-Reply-To: <cunliopilwj.fsf@hotblack-desiato.hh.sledj.net>
\r
36 References: <87k44uprvy.fsf@praet.org>
\r
37 <1326532638-22068-1-git-send-email-pieter@praet.org>
\r
38 <87y5ssxam7.fsf@zancas.localnet>
\r
39 <CAB+hUn-GmONr24nfxBkt59TzHHyZiD1wioYXoPh9wy-rZR-m2g@mail.gmail.com>
\r
40 <87ty3fycje.fsf@zancas.localnet>
\r
41 <cunliopilwj.fsf@hotblack-desiato.hh.sledj.net>
\r
42 User-Agent: Notmuch/0.11+132~ga81001f (http://notmuchmail.org) Emacs/23.3.1
\r
43 (x86_64-unknown-linux-gnu)
\r
44 Date: Wed, 01 Feb 2012 14:46:19 +0100
\r
45 Message-ID: <874nva7jkk.fsf@praet.org>
\r
47 Content-Type: text/plain; charset=us-ascii
\r
48 Cc: Notmuch Mail <notmuch@notmuchmail.org>
\r
49 X-BeenThere: notmuch@notmuchmail.org
\r
50 X-Mailman-Version: 2.1.13
\r
52 List-Id: "Use and development of the notmuch mail system."
\r
53 <notmuch.notmuchmail.org>
\r
54 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
55 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
56 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
57 List-Post: <mailto:notmuch@notmuchmail.org>
\r
58 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
59 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
60 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
61 X-List-Received-Date: Wed, 01 Feb 2012 13:48:25 -0000
\r
63 On Mon, 30 Jan 2012 09:23:40 +0000, David Edmondson <dme@dme.org> wrote:
\r
64 > On Sat, 28 Jan 2012 13:14:45 -0400, David Bremner <david@tethera.net> wrote:
\r
65 > > On Sat, 28 Jan 2012 14:55:22 +0200, Jani Nikula <jani@nikula.org> wrote:
\r
66 > > > On Jan 28, 2012 2:41 PM, "David Bremner" <david@tethera.net> wrote:
\r
68 > > > Sometimes someone (Dmitry?) sent patches that separated a small functional
\r
69 > > > change, and the big non-functional indentation change it caused,
\r
70 > > > separately. Would you prefer (or tolerate ;) that style?
\r
72 > > Hmm, that might be nicer, I'm not 100% sure.
\r
74 > > I wouldn't say it's mandatory for a patch like this (and I'd say other
\r
75 > > peoples views on what's easy to review are at least as important as mine
\r
78 > Each patch should be valid in the repository without any following
\r
79 > patches (preceding are obviously okay). Incorrect indentation would
\r
80 > disqualify a patch from being 'valid', so it shouldn't be accepted.
\r
84 Indentation corrections should always be part of the same patch as
\r
85 the change(s) that invalidated the indentation in the first place.
\r
87 Spotting the *actual* (non-indentation) changes is a non-issue
\r
88 when using `diff-refine-hunk' (or a wrapper thereof [1]).
\r
91 > _______________________________________________
\r
92 > notmuch mailing list
\r
93 > notmuch@notmuchmail.org
\r
94 > http://notmuchmail.org/mailman/listinfo/notmuch
\r
102 [1] id:"8739ax7jts.fsf@praet.org"
\r