1 Return-Path: <david@tethera.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by arlo.cworth.org (Postfix) with ESMTP id E910F6DE01F7
\r
6 for <notmuch@notmuchmail.org>; Fri, 18 Sep 2015 05:04:40 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at cworth.org
\r
11 X-Spam-Status: No, score=0.114 tagged_above=-999 required=5 tests=[AWL=0.114]
\r
13 Received: from arlo.cworth.org ([127.0.0.1])
\r
14 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id OV6ppnVJwvaF for <notmuch@notmuchmail.org>;
\r
16 Fri, 18 Sep 2015 05:04:39 -0700 (PDT)
\r
17 Received: from gitolite.debian.net (gitolite.debian.net [87.98.215.224])
\r
18 by arlo.cworth.org (Postfix) with ESMTPS id E95E96DE00DE
\r
19 for <notmuch@notmuchmail.org>; Fri, 18 Sep 2015 05:04:38 -0700 (PDT)
\r
20 Received: from remotemail by gitolite.debian.net with local (Exim 4.80)
\r
21 (envelope-from <david@tethera.net>)
\r
22 id 1ZcuOC-0001FU-V0; Fri, 18 Sep 2015 12:03:40 +0000
\r
23 Received: (nullmailer pid 9821 invoked by uid 1000); Fri, 18 Sep 2015
\r
25 From: David Bremner <david@tethera.net>
\r
26 To: Johannes Schauer <josch@debian.org>, notmuch@notmuchmail.org
\r
27 Subject: Re: [bug] notmuch requires Content-Disposition mime header value to
\r
29 In-Reply-To: <20150917083956.1941.35098@localhost>
\r
30 References: <20150917070056.1941.94846@localhost>
\r
31 <20150917083612.1941.22480@localhost> <20150917083956.1941.35098@localhost>
\r
32 User-Agent: Notmuch/0.20.2+73~gd432116 (http://notmuchmail.org) Emacs/24.5.1
\r
33 (x86_64-pc-linux-gnu)
\r
34 Date: Fri, 18 Sep 2015 09:03:20 -0300
\r
35 Message-ID: <87pp1grl2v.fsf@maritornes.cs.unb.ca>
\r
37 Content-Type: text/plain
\r
38 X-BeenThere: notmuch@notmuchmail.org
\r
39 X-Mailman-Version: 2.1.18
\r
41 List-Id: "Use and development of the notmuch mail system."
\r
42 <notmuch.notmuchmail.org>
\r
43 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
44 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
45 List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
\r
46 List-Post: <mailto:notmuch@notmuchmail.org>
\r
47 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
48 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
49 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
50 X-List-Received-Date: Fri, 18 Sep 2015 12:04:41 -0000
\r
52 Johannes Schauer <josch@debian.org> writes:
\r
55 > Funnily though there seem to be some weird newline differences that I cannot
\r
56 > explain, so I left them for somebody else to fix.
\r
59 Looking at the files (.EXPECTED and .OUTPUT) in test/tmp.T190-multipart,
\r
60 there's more than whitespace changes. Some things that used to marked
\r
61 "attachment" in the output are now marked "part".
\r
63 > diff --git a/test/T190-multipart.sh b/test/T190-multipart.sh
\r
64 > index 7c4c9f7..f16cc90 100755
\r
65 > --- a/test/T190-multipart.sh
\r
66 > +++ b/test/T190-multipart.sh
\r
67 > @@ -48,7 +48,7 @@ cat embedded_message >> ${MAIL_DIR}/multipart
\r
68 > cat <<EOF >> ${MAIL_DIR}/multipart
\r
71 > -Content-Disposition: attachment; filename=attachment
\r
72 > +Content-Disposition: ATTACHMENT; FILENAME=attachment
\r
74 > This is a text attachment.
\r
76 > @@ -487,7 +487,7 @@ This is an embedded message, with a multipart/alternative part.
\r
80 > -Content-Disposition: attachment; filename=attachment
\r
81 > +Content-Disposition: ATTACHMENT; FILENAME=attachment
\r
83 > This is a text attachment.
\r
86 I'd recommend making your own new test, rather than modifying existing
\r
87 ones to test multiple things. I'd also recommend using json / sexp
\r
88 output for your tests, since the ad-hoc text format is kindof
\r