1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 445F1431FD4
\r
6 for <notmuch@notmuchmail.org>; Sun, 17 Nov 2013 11:42:52 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id RGcQgnavCfSy for <notmuch@notmuchmail.org>;
\r
16 Sun, 17 Nov 2013 11:42:47 -0800 (PST)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 97A5A431FAF
\r
19 for <notmuch@notmuchmail.org>; Sun, 17 Nov 2013 11:42:47 -0800 (PST)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id 03245100030;
\r
22 Sun, 17 Nov 2013 21:42:41 +0200 (EET)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: Jameson Graef Rollins <jrollins@finestructure.net>,
\r
25 Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
\r
26 Subject: Re: [PATCH] emacs: do not put quoted reply in primary selection
\r
27 In-Reply-To: <87siuu95uy.fsf@servo.finestructure.net>
\r
28 References: <1384689849-9388-1-git-send-email-markwalters1009@gmail.com>
\r
29 <87siuu95uy.fsf@servo.finestructure.net>
\r
30 User-Agent: Notmuch/0.16+175~g19e97d6 (http://notmuchmail.org) Emacs/24.3.1
\r
31 (x86_64-unknown-linux-gnu)
\r
32 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
33 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
34 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
35 Date: Sun, 17 Nov 2013 21:42:40 +0200
\r
36 Message-ID: <m2eh6e7r2n.fsf@guru.guru-group.fi>
\r
38 Content-Type: text/plain
\r
39 X-BeenThere: notmuch@notmuchmail.org
\r
40 X-Mailman-Version: 2.1.13
\r
42 List-Id: "Use and development of the notmuch mail system."
\r
43 <notmuch.notmuchmail.org>
\r
44 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
45 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
46 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
47 List-Post: <mailto:notmuch@notmuchmail.org>
\r
48 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
49 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
50 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
51 X-List-Received-Date: Sun, 17 Nov 2013 19:42:52 -0000
\r
53 On Sun, Nov 17 2013, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
\r
55 > On Sun, Nov 17 2013, Mark Walters <markwalters1009@gmail.com> wrote:
\r
56 >> In current emacs (24.3) select-active-regions is set to t by
\r
57 >> default. The reply insertion code sets the region to the quoted
\r
58 >> message to make it easy to delete (kill-region or C-w). These two
\r
59 >> things combine to put the quoted message in the primary selection.
\r
61 >> This is not what the user wanted and is a privacy risk (accidental
\r
62 >> pasting of the quoted message). We can avoid some of the problems
\r
63 >> by let-binding select-active-regions to nil. This fixes if the
\r
64 >> primary selection was previously in a non-emacs window but not if
\r
65 >> it was in an emacs window. To avoid the problem in the latter case
\r
66 >> we deactivate mark.
\r
68 >> One key test (which fails under many simpler "fixes") is: open emacs
\r
69 >> 24.3 with notmuch, open 2 windows (viewing different notmuch buffers),
\r
70 >> highlight some text in one, and then reply to a message in the
\r
71 >> other. In many of my earlier attempts to fix this big this test fails.
\r
73 > I'm very happy to report that I reply to this message with an unpolluted
\r
74 > paste buffer! Kudos Mark!
\r
76 >> Anyway, this is the best I can manage!
\r
78 > Too modest for such an achievement.
\r
82 This works for me too (and tests pass).
\r
84 I don't see how this could break thinks, So I think this is important
\r
85 enough th be included in 0.17
\r