1 Return-Path: <amdragon@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id CA1EF429E25
\r
6 for <notmuch@notmuchmail.org>; Sun, 30 Oct 2011 17:04:51 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.699 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001,
\r
13 RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id hez9z6x1chUV for <notmuch@notmuchmail.org>;
\r
17 Sun, 30 Oct 2011 17:04:51 -0700 (PDT)
\r
18 Received: from mail-gy0-f181.google.com (mail-gy0-f181.google.com
\r
19 [209.85.160.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 42551431FB6
\r
22 for <notmuch@notmuchmail.org>; Sun, 30 Oct 2011 17:04:51 -0700 (PDT)
\r
23 Received: by gye5 with SMTP id 5so7420848gye.26
\r
24 for <notmuch@notmuchmail.org>; Sun, 30 Oct 2011 17:04:49 -0700 (PDT)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
\r
26 h=mime-version:sender:in-reply-to:references:date
\r
27 :x-google-sender-auth:message-id:subject:from:to:cc:content-type
\r
28 :content-transfer-encoding;
\r
29 bh=8yomm/r+SBbB1tw+N0xiO3GBCdzz8Zs8bUeU1ZhA4O8=;
\r
30 b=GQVroj3EhS9drUCjvAqNqX0FW+1mPd9tSJHrfguAkR/W9weW7tLhgVq6wkhG75Np0T
\r
31 3XcsLct7IU94GEI97vH1Xg9z6n7+bbppYaFFrxGrIMT/NU0ZvfjPoc6K80vU01ROj8pB
\r
32 4/1fkCF0aDWrgFtE6JzG/tKKj9k05U2Pesavc=
\r
34 Received: by 10.68.30.129 with SMTP id s1mr19364065pbh.4.1320019489320; Sun,
\r
35 30 Oct 2011 17:04:49 -0700 (PDT)
\r
36 Sender: amdragon@gmail.com
\r
37 Received: by 10.143.166.17 with HTTP; Sun, 30 Oct 2011 17:04:49 -0700 (PDT)
\r
38 In-Reply-To: <1319383133-11006-1-git-send-email-david@tethera.net>
\r
39 References: <1319383133-11006-1-git-send-email-david@tethera.net>
\r
40 Date: Sun, 30 Oct 2011 20:04:49 -0400
\r
41 X-Google-Sender-Auth: c3hXiQaEXmXCNM32Z8lrtnuhySE
\r
43 <CAH-f9WvMG6KUUb2ymB2yLzB_8Nw_vNmWL1jYCW3GXk87L=qbcg@mail.gmail.com>
\r
44 Subject: Re: [PATCH] xutil.c: remove duplicate copies, create new library
\r
45 libutil.a to contain xutil.
\r
46 From: Austin Clements <amdragon@mit.edu>
\r
47 To: David Bremner <david@tethera.net>
\r
48 Content-Type: text/plain; charset=ISO-8859-1
\r
49 Content-Transfer-Encoding: quoted-printable
\r
50 Cc: notmuch@notmuchmail.org, David Bremner <bremner@debian.org>
\r
51 X-BeenThere: notmuch@notmuchmail.org
\r
52 X-Mailman-Version: 2.1.13
\r
54 List-Id: "Use and development of the notmuch mail system."
\r
55 <notmuch.notmuchmail.org>
\r
56 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
57 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
58 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
59 List-Post: <mailto:notmuch@notmuchmail.org>
\r
60 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
61 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
62 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
63 X-List-Received-Date: Mon, 31 Oct 2011 00:04:51 -0000
\r
65 LGTM. Code deduplication is always a good thing.
\r
67 "Internal interfaces for notmuch." doesn't seem like the best summary
\r
68 for util/error_util.h
\r
70 On Sun, Oct 23, 2011 at 11:18 AM, David Bremner <david@tethera.net> wrote:
\r
71 > From: David Bremner <bremner@debian.org>
\r
73 > We keep the lib/xutil.c version. As a consequence, also factor out
\r
74 > _internal_error and associated macros. =A0It might be overkill to make a
\r
75 > new file error_util.c for this, but _internal_error does not really
\r
76 > belong in database.cc.
\r