1 Return-Path: <dmitry.kurochkin@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id B91CF429E2A
\r
6 for <notmuch@notmuchmail.org>; Wed, 15 Jun 2011 07:24:45 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id QiSphQkcrgsU for <notmuch@notmuchmail.org>;
\r
17 Wed, 15 Jun 2011 07:24:45 -0700 (PDT)
\r
18 Received: from mail-fx0-f53.google.com (mail-fx0-f53.google.com
\r
19 [209.85.161.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id E1518429E26
\r
22 for <notmuch@notmuchmail.org>; Wed, 15 Jun 2011 07:24:44 -0700 (PDT)
\r
23 Received: by fxm8 with SMTP id 8so473561fxm.26
\r
24 for <notmuch@notmuchmail.org>; Wed, 15 Jun 2011 07:24:43 -0700 (PDT)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
\r
26 h=domainkey-signature:from:to:subject:in-reply-to:references
\r
27 :user-agent:date:message-id:mime-version:content-type;
\r
28 bh=wPjpw5Too71dlKQ+IKKSYOFu6W0dtRBD9u5U8b/yYz8=;
\r
29 b=NejOHVkTONpnV/Gekltd/d6AcSBGX0mWpKgSaNv1jO1VwZoITeX2MEP2IIFJpplz4Y
\r
30 Oi5KjtEiWqmERzQfcUtrq9HEjIaE4ZFYXlcpHEAEZdnytAOZ+ttKrSHpjUNb/c34He/f
\r
31 Yy31H3hhIm2BgF4AxhIRfJj1Fu9bAnPGUneSs=
\r
32 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
\r
33 h=from:to:subject:in-reply-to:references:user-agent:date:message-id
\r
34 :mime-version:content-type;
\r
35 b=j2Z4Zy9YcMT3SqybFihfxRI1OHrWboQCo8SVUYhCINQDGHpHc9UFGSJr/0avk5QUJc
\r
36 j8B+5Zwh+V6ZGynEmWC4wnGbe7xFioKXAOnAcRLo8TJYcP8/aAmVQ7Bq0JxytZOnCcBX
\r
37 rasiq7PhZUa2YTUkQLdyUZh3zc/MwOVsWM2J8=
\r
38 Received: by 10.223.76.129 with SMTP id c1mr664989fak.107.1308147883424;
\r
39 Wed, 15 Jun 2011 07:24:43 -0700 (PDT)
\r
40 Received: from localhost ([91.144.186.21])
\r
41 by mx.google.com with ESMTPS id n13sm247785fab.46.2011.06.15.07.24.41
\r
42 (version=TLSv1/SSLv3 cipher=OTHER);
\r
43 Wed, 15 Jun 2011 07:24:42 -0700 (PDT)
\r
44 From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
\r
45 To: Carl Worth <cworth@cworth.org>, notmuch@notmuchmail.org
\r
46 Subject: Re: [PATCH 3/5] Fix hiding a message while some citations are shown
\r
47 in notmuch-show view.
\r
48 In-Reply-To: <87sjrbkx3j.fsf@yoom.home.cworth.org>
\r
49 References: <1306361416-5019-1-git-send-email-dmitry.kurochkin@gmail.com>
\r
50 <1306361416-5019-4-git-send-email-dmitry.kurochkin@gmail.com>
\r
51 <87oc2qa07g.fsf@yoom.home.cworth.org> <87k4depfyj.fsf@gmail.com>
\r
52 <87lixu9z5b.fsf@yoom.home.cworth.org> <87hb8ipeb0.fsf@gmail.com>
\r
53 <87ipsy9sue.fsf@yoom.home.cworth.org> <87d3j5pxk5.fsf@gmail.com>
\r
54 <87k4ddcfnx.fsf@yoom.home.cworth.org> <877h9dp29t.fsf@gmail.com>
\r
55 <87sjrbkx3j.fsf@yoom.home.cworth.org>
\r
56 User-Agent: Notmuch/0.5-237-gf6d8cdb (http://notmuchmail.org) Emacs/23.3.1
\r
57 (x86_64-pc-linux-gnu)
\r
58 Date: Wed, 15 Jun 2011 18:25:14 +0400
\r
59 Message-ID: <8739jbqiid.fsf@gmail.com>
\r
61 Content-Type: text/plain; charset=us-ascii
\r
62 X-BeenThere: notmuch@notmuchmail.org
\r
63 X-Mailman-Version: 2.1.13
\r
65 List-Id: "Use and development of the notmuch mail system."
\r
66 <notmuch.notmuchmail.org>
\r
67 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
68 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
69 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
70 List-Post: <mailto:notmuch@notmuchmail.org>
\r
71 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
72 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
73 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
74 X-List-Received-Date: Wed, 15 Jun 2011 14:24:46 -0000
\r
76 On Wed, 15 Jun 2011 07:06:40 -0700, Carl Worth <cworth@cworth.org> wrote:
\r
77 > On Fri, 27 May 2011 01:42:22 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
\r
78 > > I have just send two more patches to this thread. One with new tests.
\r
79 > > Another with a workaround for the bug. The workaround should not break
\r
80 > > anything since it affects only notmuch-show mode.
\r
84 > I love committing tests that demonstrate broken code before committing
\r
85 > fixes. As it happened here, I committed these two new patches thinking I
\r
86 > had previously committed the earlier patches in the series. Fortunately,
\r
87 > the failure of the test pointed out that I was missing the actual fix.
\r
90 I know you prefer tests to go before patches and I agree with that. But
\r
91 most of the time I do tests after coding. I do not know an easy way to
\r
92 reorder patches in git. (Also I do not know how to amend an old patch,
\r
93 wish more darcs features in git.) Hopefully it is not a big trouble for
\r
94 you to reorder the patches when applying.
\r
96 > I also really like the workaround to avoid regressing functionality
\r
97 > because of an emacs bug.
\r
102 > Well done, Dmitry. I've now pushed out everything in this series.
\r
113 > carl.d.worth@intel.com
\r