e0/d00594fca4278a5a0688ea553f8f34f8471d5a

   1 Return-Path: <mpn@google.com>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id E15F3431FBC\r
   6         for <notmuch@notmuchmail.org>; Mon,  3 Dec 2012 13:33:04 -0800 (PST)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.7\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
  12         tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_LOW=-0.7]\r
  13         autolearn=disabled\r
  14 Received: from olra.theworths.org ([127.0.0.1])\r
  15         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  16         with ESMTP id VIIEj45VByO4 for <notmuch@notmuchmail.org>;\r
  17         Mon,  3 Dec 2012 13:33:04 -0800 (PST)\r
  18 Received: from mail-ea0-f181.google.com (mail-ea0-f181.google.com\r
  19         [209.85.215.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
  20         (No client certificate requested)\r
  21         by olra.theworths.org (Postfix) with ESMTPS id D95BB431FAE\r
  22         for <notmuch@notmuchmail.org>; Mon,  3 Dec 2012 13:33:03 -0800 (PST)\r
  23 Received: by mail-ea0-f181.google.com with SMTP id k14so1656425eaa.26\r
  24         for <notmuch@notmuchmail.org>; Mon, 03 Dec 2012 13:33:02 -0800 (PST)\r
  25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\r
  26  s=20120113;    h=sender:from:to:subject:in-reply-to:organization:references\r
  27         :user-agent:x-face:face:x-pgp:x-pgp-fp:date:message-id:mime-version\r
  28         :content-type; bh=E/m+L38yt+5ZWOw83mJIApGRiZlIU1XA+cMYD1LSXZ0=;\r
  29         b=ckFLOCYEvYRo3cXcKfkfR+z225HI7b2O9iFe/XXp1Gnhxm53V4jkiY4mBA7Q2ZfcKz\r
  30         /vUuURmsBXSELW2E6YoPLDPffXKPkZMH78rVR7A1Q8oLKgnVl+xmp6j2hTMS8i1lg65/\r
  31         pxYeMISFkQgBXFd+nUtHHtdfxr+z4JXYfWDJgMqUIjFu/Dx+YbkcsaVtjKp/a0G85pL3\r
  32         4RKp/P6oZ+8e0gIFZwoSt0rL+DHSYvPQ02J2p3TAcF1DCaz8LUHDf7T0Yf8LKoJTkVWC\r
  33         GiQUo/tpDv1WhjdCPZCoeV7oh5OgEmNTLcA/4dcl8Ou4gq1PJbJd+wSDRd86AxZu3TSF    U43w==\r
  34 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
  35         d=google.com; s=20120113;\r
  36         h=sender:from:to:subject:in-reply-to:organization:references\r
  37         :user-agent:x-face:face:x-pgp:x-pgp-fp:date:message-id:mime-version\r
  38         :content-type:x-gm-message-state;\r
  39         bh=E/m+L38yt+5ZWOw83mJIApGRiZlIU1XA+cMYD1LSXZ0=;\r
  40         b=gWNRj2i59F0Wug7YlfR43w+jT2GSX9vrV4apinfwDFDq76gHgbqk1cuehg4tS7ml78\r
  41         s4WqSmJwiKWTwM9X+K5cwClyVZ7txDl5u6/6Wo7M7TEHtNPgi45YtMBi/MhvwdL9Jx+v\r
  42         JMr6C4sDi+3KsD1/NL7Z6P1sJw2XJdomxxc7mtyGSnJo1Sm92PMyTlNnILK8IZvVcb8S\r
  43         JYrZzwI1We8dUcRw5ev9B1TYA/M/DfTqUUP8ahjy14A9TY+hsifmXsKP9H/GrFlp9Q47\r
  44         Z2IeKHnW9ZR5aIDZLVxaORmG02bqqyFO4JePffUfyp2tGJP4fhO1MUDZTzRSrs0EXp4t\r
  45         DEjA==\r
  46 Received: by 10.14.213.134 with SMTP id a6mr40544758eep.45.1354570382594;\r
  47         Mon, 03 Dec 2012 13:33:02 -0800 (PST)\r
  48 Received: from mpn-glaptop ([2620:0:105f:5:e550:22e2:cbaa:1724])\r
  49         by mx.google.com with ESMTPS id d3sm7692246eeo.13.2012.12.03.13.33.00\r
  50         (version=TLSv1/SSLv3 cipher=OTHER);\r
  51         Mon, 03 Dec 2012 13:33:01 -0800 (PST)\r
  52 Sender: Michal Nazarewicz <mpn@google.com>\r
  53 From: Michal Nazarewicz <mina86@mina86.com>\r
  54 To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org\r
  55 Subject: Re: [PATCH 1/2] cli: fix notmuch top level argument parsing\r
  56 In-Reply-To:\r
  57  <c4f2a1048763950dd14e13c99a4e7eb333be8c9d.1354568072.git.jani@nikula.org>\r
  58 Organization: http://mina86.com/\r
  59 References:\r
  60  <c4f2a1048763950dd14e13c99a4e7eb333be8c9d.1354568072.git.jani@nikula.org>\r
  61 User-Agent: Notmuch/ (http://notmuchmail.org) Emacs/24.2.50.1\r
  62         (x86_64-unknown-linux-gnu)\r
  63 X-Face: PbkBB1w#)bOqd`iCe"Ds{e+!C7`pkC9a|f)Qo^BMQvy\q5x3?vDQJeN(DS?|-^$uMti[3D*#^_Ts"pU$jBQLq~Ud6iNwAw_r_o_4]|JO?]}P_}Nc&"p#D(ZgUb4uCNPe7~a[DbPG0T~!&c.y$Ur,=N4RT>]dNpd;        KFrfMCylc}gc??'U2j,!8%xdD\r
  64 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWbfGlUPDDHgE57V0jUupKjgIObY0PLrom9mH4dFRK4gmjPs41MxjOgAAACQElEQVQ4jW3TMWvbQBQHcBk1xE6WyALX1069oZBMlq+ouUwpEQQ6uRjttkWP4CmBgGM0BQLBdPFZYPsyFUo6uEtKDQ7oy/U96XR2Ux8ehH/89Z6enqxBcS7Lg81jmSuujrfCZcLI/TYYvbGj+jbgFpHJ/bqQAUISj8iLyu4LuFHJTosxsucO4jSDNE0Hq3hwK/ceQ5sx97b8LcUDsILfk+ovHkOIsMbBfg43VuQ5Ln9YAGCkUdKJoXR9EclFBhixy3EGVz1K6eEkhxCAkeMMnqoAhAKwhoUJkDrCqvbecaYINlFKSRS1i12VKH1XpUd4qxL876EkMcDvHj3s5RBajHHMlA5iK32e0C7VgG0RlzFPvoYHZLRmAC0BmNcBruhkE0KsMsbEc62ZwUJDxWUdMsMhVqovoT96i/DnX/ASvz/6hbCabELLk/6FF/8PNpPCGqcZTGFcBhhAaZZDbQPaAB3+KrWWy2XgbYDNIinkdWAFcCpraDE/knwe5DBqGmgzESl1p2E4MWAz0VUPgYYzmfWb9yS4vCvgsxJriNTHoIBz5YteBvg+VGISQWUqhMiByPIPpygeDBE6elD973xWwKkEiHZAHKjhuPsFnBuArrzxtakRcISv+XMIPl4aGBUJm8Emk7qBYU8IlgNEIpiJhk/No24jHwkKTFHDWfPniR4iw5vJaw2nzSjfq2zffcE/GDjRC2dn0J0XwPAbDL84TvaFCJEU4Oml9pRyEUhR3Cl2t01AoEjRbs0sYugp14/4X5n4pU4EHHnMAAAAAElFTkSuQmCC\r
  65 X-PGP: 50751FF4\r
  66 X-PGP-FP: AC1F 5F5C D418 88F8 CC84 5858 2060 4012 5075 1FF4\r
  67 Date: Mon, 03 Dec 2012 22:32:52 +0100\r
  68 Message-ID: <xa1tpq2qstx7.fsf@mina86.com>\r
  69 MIME-Version: 1.0\r
  70 Content-Type: multipart/mixed; boundary="=-=-="\r
  71 X-Gm-Message-State: ALoCoQkbqW6r2Sexhrt8hTeKwoUEwuvNs9HKcbQ1HZXOBUqV6whehrSaeEm07UsX1l7/14PX6mp6cHSeNo/Xzci8fj3G9YMFXSJKhmQndDgcbKc93J9Ohxf3bjcyfWn+QuAw0Ui+4UVrX3y5jQ+QX5I7sNJCmXCfL2P55aCvvIgha19NOVzGrrVvBcEyu4TUESUUfseQRT6NqiaMzzfXADSnRCK8hOfV5A==\r
  72 X-BeenThere: notmuch@notmuchmail.org\r
  73 X-Mailman-Version: 2.1.13\r
  74 Precedence: list\r
  75 List-Id: "Use and development of the notmuch mail system."\r
  76         <notmuch.notmuchmail.org>\r
  77 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  78         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  79 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  80 List-Post: <mailto:notmuch@notmuchmail.org>\r
  81 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  82 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  83         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  84 X-List-Received-Date: Mon, 03 Dec 2012 21:33:05 -0000\r
  85 \r
  86 --=-=-=\r
  87 Content-Type: text/plain; charset=utf-8\r
  88 Content-Transfer-Encoding: quoted-printable\r
  89 \r
  90 On Mon, Dec 03 2012, Jani Nikula wrote:\r
  91 > Use strcmp instead of STRNCMP_LITERAL, which matches the prefix\r
  92 > instead of the whole argument.\r
  93 \r
  94 Perhaps add and use this instead:\r
  95 \r
  96 #define STRCMP_LITERAL(var, literal) \\r
  97     strncmp ((var), (literal), sizeof (literal))\r
  98 \r
  99 Than again, it's argument parsing so hardly a performance critical path,\r
 100 so maybe readability is more important.\r
 101 \r
 102 > ---\r
 103 >  notmuch.c |    4 ++--\r
 104 >  1 file changed, 2 insertions(+), 2 deletions(-)\r
 105 >\r
 106 > diff --git a/notmuch.c b/notmuch.c\r
 107 > index 477a09c..4ff66e3 100644\r
 108 > --- a/notmuch.c\r
 109 > +++ b/notmuch.c\r
 110 > @@ -245,10 +245,10 @@ main (int argc, char *argv[])\r
 111 >      if (argc =3D=3D 1)\r
 112 >       return notmuch (local);\r
 113 >=20=20\r
 114 > -    if (STRNCMP_LITERAL (argv[1], "--help") =3D=3D 0)\r
 115 > +    if (strcmp (argv[1], "--help") =3D=3D 0)\r
 116 >       return notmuch_help_command (NULL, argc - 1, &argv[1]);\r
 117 >=20=20\r
 118 > -    if (STRNCMP_LITERAL (argv[1], "--version") =3D=3D 0) {\r
 119 > +    if (strcmp (argv[1], "--version") =3D=3D 0) {\r
 120 >       printf ("notmuch " STRINGIFY(NOTMUCH_VERSION) "\n");\r
 121 >       return 0;\r
 122 >      }\r
 123 \r
 124 --=20\r
 125 Best regards,                                         _     _\r
 126 .o. | Liege of Serenely Enlightened Majesty of      o' \,=3D./ `o\r
 127 ..o | Computer Science,  Micha=C5=82 =E2=80=9Cmina86=E2=80=9D Nazarewicz   =\r
 128  (o o)\r
 129 ooo +----<email/xmpp: mpn@google.com>--------------ooO--(_)--Ooo--\r
 130 --=-=-=\r
 131 Content-Type: multipart/signed; boundary="==-=-=";\r
 132         micalg=pgp-sha1; protocol="application/pgp-signature"\r
 133 \r
 134 --==-=-=\r
 135 Content-Type: text/plain\r
 136 \r
 137 \r
 138 --==-=-=\r
 139 Content-Type: application/pgp-signature\r
 140 \r
 141 -----BEGIN PGP SIGNATURE-----\r
 142 Version: GnuPG v1.4.11 (GNU/Linux)\r
 143 \r
 144 iQIcBAEBAgAGBQJQvRqEAAoJECBgQBJQdR/06wUP/1DlPwlaQNU9tHKrHvv/+Z4S\r
 145 4ctpMBI61COGRost+qf06Gm0PaFgbhIAaZVKschVE+IDESAROsakS1Ona3oNx1tZ\r
 146 1MQ9H7l/JBAx8r+6rvKPNxU+h270k9kkt6qZ9VunAwPxAsvYOyFnI1uEZSKIk6io\r
 147 fh5XLmUkfaTs5DplawYZoL2fczL1OVIaC4LclixKW4m4EYPbUduwewvPVR6OrOt+\r
 148 UWBgx+JGQozzEOE5tI6nNkz3stIp58pe1Wl+zKmuaUf4ZdqWbLym94K4VeLyA+cC\r
 149 CuDB37D8zhSrYcvD/d3Yh4MgvDPqMCq323mFtdmO5kE+J9NX159IelyYk3qaVIJ3\r
 150 f4QlTkTQIogsQXI/iX3CcVhtyd9mOTOrinmHqdw1RwFQ98JXmB/JemjbdboacLr7\r
 151 JrO+rX/FuZQHPJRe921xLiZ3sEHzlxinAZeGu3gNfzmDxa1QCnRs+gVKReF00wcz\r
 152 yZzIA9FZFCxR2p9hTfsHFPmoCyD3F61UsuLLK2RUBNbqwZGNBp5/qDpMCLs9NsgM\r
 153 HQ1ObiPdrDdsP9ImBzohW1PUYGt5xOB4giXgRECJyU3PZyZzSAttEd56YxJ+35L1\r
 154 kRgu3F5JicFuuDDD762khRnKmAIytLyEKCGEERf/355WdSO2Y3qUaTH2eobrIAMC\r
 155 AJOPXyUIKtk2BJyyEH7F\r
 156 =9Hj4\r
 157 -----END PGP SIGNATURE-----\r
 158 --==-=-=--\r
 159 \r
 160 --=-=-=--\r