e0/9f6d101f87ddfbe117dea002caa71d1425f9f3

   1 Return-Path: <amdragon@mit.edu>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id C96EE431FC0\r
   6         for <notmuch@notmuchmail.org>; Tue, 30 Jul 2013 19:25:44 -0700 (PDT)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.7\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
  12         tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
  13 Received: from olra.theworths.org ([127.0.0.1])\r
  14         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  15         with ESMTP id 7JM0hC0URg2T for <notmuch@notmuchmail.org>;\r
  16         Tue, 30 Jul 2013 19:25:37 -0700 (PDT)\r
  17 Received: from dmz-mailsec-scanner-8.mit.edu (dmz-mailsec-scanner-8.mit.edu\r
  18         [18.7.68.37])\r
  19         by olra.theworths.org (Postfix) with ESMTP id 32CCE431FBF\r
  20         for <notmuch@notmuchmail.org>; Tue, 30 Jul 2013 19:25:37 -0700 (PDT)\r
  21 X-AuditID: 12074425-b7f0c8e000000953-32-51f8759f3a1b\r
  22 Received: from mailhub-auth-3.mit.edu ( [18.9.21.43])\r
  23         by dmz-mailsec-scanner-8.mit.edu (Symantec Messaging Gateway) with SMTP\r
  24         id 2E.CB.02387.F9578F15; Tue, 30 Jul 2013 22:25:35 -0400 (EDT)\r
  25 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11])\r
  26         by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id r6V2PYCu031338; \r
  27         Tue, 30 Jul 2013 22:25:35 -0400\r
  28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
  29         (authenticated bits=0)\r
  30         (User authenticated as amdragon@ATHENA.MIT.EDU)\r
  31         by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id r6V2PUWG009720\r
  32         (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT);\r
  33         Tue, 30 Jul 2013 22:25:33 -0400\r
  34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80)\r
  35         (envelope-from <amdragon@mit.edu>)\r
  36         id 1V4M6T-0006p4-FS; Tue, 30 Jul 2013 22:25:29 -0400\r
  37 Date: Tue, 30 Jul 2013 22:25:29 -0400\r
  38 From: Austin Clements <amdragon@MIT.EDU>\r
  39 To: Mark Walters <markwalters1009@gmail.com>\r
  40 Subject: Re: [PATCH] emacs: bugfix attachment content-type as mime-type\r
  41         handling\r
  42 Message-ID: <20130731022529.GU2214@mit.edu>\r
  43 References: <87li4om623.fsf@qmul.ac.uk>\r
  44         <1375200900-5650-1-git-send-email-markwalters1009@gmail.com>\r
  45 MIME-Version: 1.0\r
  46 Content-Type: text/plain; charset=us-ascii\r
  47 Content-Disposition: inline\r
  48 In-Reply-To: <1375200900-5650-1-git-send-email-markwalters1009@gmail.com>\r
  49 User-Agent: Mutt/1.5.21 (2010-09-15)\r
  50 X-Brightmail-Tracker:\r
  51  H4sIAAAAAAAAA+NgFupnleLIzCtJLcpLzFFi42IR4hTV1p1f+iPQ4M02WYvVc3ksrt+cyezA\r
  52         5LFz1l12j2erbjEHMEVx2aSk5mSWpRbp2yVwZRzq6mIpuMJesX3TBMYGxulsXYycHBICJhL7\r
  53         13axQthiEhfurQeKc3EICexjlDhxYh0zhLORUeL5mg5GCOc0k8S61q1QmSWMEqvub2AB6WcR\r
  54         UJV4c6MXzGYT0JDYtn85I4gtIqAjcfvQAnYQm1lAWuLb72YmEFtYIEji+4TjzCA2r4C2xJwn\r
  55         vWA3CQmkSexbv5YJIi4ocXLmExaIXi2JG/9eAsU5wOYs/8cBEuYU8JQ48u03WImogIrElJPb\r
  56         2CYwCs1C0j0LSfcshO4FjMyrGGVTcqt0cxMzc4pTk3WLkxPz8lKLdC30cjNL9FJTSjcxgsKa\r
  57         3UV1B+OEQ0qHGAU4GJV4eB0ufA8UYk0sK67MPcQoycGkJMrLW/IjUIgvKT+lMiOxOCO+qDQn\r
  58         tfgQowQHs5IIr3wQUI43JbGyKrUoHyYlzcGiJM77/OnZQCGB9MSS1OzU1ILUIpisDAeHkgSv\r
  59         ODB+hQSLUtNTK9Iyc0oQ0kwcnCDDeYCGvwdZzFtckJhbnJkOkT/FqMsx+eyW94xCLHn5ealS\r
  60         4ry/QYoEQIoySvPg5sDS0StGcaC3hHmVQdbxAFMZ3KRXQEuYgJbsVvkGsqQkESEl1cAo/Gbf\r
  61         Kn6t2rBp3JcYT1fpG/Ok3fjCvFviW/u0M7ETg2cxTrgs8q5yN7+/XdDxDQr8T5j+Hu9Z+uXj\r
  62         2rZjJQ7Hbj2Xlt3ObbeXU3SpdrL61dBmhXPHcnWZbJKWKwhrl/1ZPlG9eVN+a8C+2S1fd3w6\r
  63         yzHNtXBK2JxHMTeLpzsX3BP5vVX33lNrJZbijERDLeai4kQAEUx6BCIDAAA=\r
  64 Cc: notmuch@notmuchmail.org\r
  65 X-BeenThere: notmuch@notmuchmail.org\r
  66 X-Mailman-Version: 2.1.13\r
  67 Precedence: list\r
  68 List-Id: "Use and development of the notmuch mail system."\r
  69         <notmuch.notmuchmail.org>\r
  70 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  71         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  72 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  73 List-Post: <mailto:notmuch@notmuchmail.org>\r
  74 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  75 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  76         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  77 X-List-Received-Date: Wed, 31 Jul 2013 02:25:44 -0000\r
  78 \r
  79 Quoth Mark Walters on Jul 30 at  5:15 pm:\r
  80 > Notmuch puts attachments in as declared content-type except when the\r
  81 > content-type is application/octet-stream it tries to guess the type\r
  82 > from the filename/extension. This means that viewing a pdf (for\r
  83 > example) which is sent as application/octet-strem invokes the pdf\r
  84 > viewer rather than just offering to save the part.\r
  85 > \r
  86 > Recent changes to the attachment handling (commit 1546387d) changed\r
  87 > (broke) this. This patch stores the calculated mime-type with the part\r
  88 > and changes the attachment part handlers can use it instead.\r
  89 > ---\r
  90 > This seems to fix the bug for me. I am not sure I like the naming\r
  91 > (mime-type/content-type). Maybe it would be better to be explicit with\r
  92 > something like calculated-content-type but probably that should be a\r
  93 > more wholesale renaming.\r
  94 \r
  95 Code LGTM, though I agree the naming could be better.  It would be\r
  96 nice to have a test for this so we don't regress again in the future.\r