1 Return-Path: <novalazy@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id E1694431FC3
\r
6 for <notmuch@notmuchmail.org>; Fri, 21 Jun 2013 22:47:10 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id suR9YvYFREIl for <notmuch@notmuchmail.org>;
\r
17 Fri, 21 Jun 2013 22:47:05 -0700 (PDT)
\r
18 Received: from mail-pa0-f42.google.com (mail-pa0-f42.google.com
\r
19 [209.85.220.42]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 013BE431FAE
\r
22 for <notmuch@notmuchmail.org>; Fri, 21 Jun 2013 22:47:04 -0700 (PDT)
\r
23 Received: by mail-pa0-f42.google.com with SMTP id rl6so8790420pac.15
\r
24 for <notmuch@notmuchmail.org>; Fri, 21 Jun 2013 22:47:04 -0700 (PDT)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
\r
26 h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references;
\r
27 bh=uGhCFmhR6GDSZO0Amme3lygoSxHmkPKNyhUcG7bsz4g=;
\r
28 b=jNFyz8iFTbrBo5Vv9a4C56R3w3MgbDq+XwNLQ8lVGvkvVtk/IMjLruoUQ/xL8M7upy
\r
29 fH9cHO6YoGmjiVtiiZynZZXPxHg64zUDtLdc4ZYS5Fg2/8BiwY/px0aQECwG221NC4x5
\r
30 DRIDjpIoAdrLbVgapxm0ZlzWW8EeUA2PlBu47UGIBzx+2KuPw4BedOYT7NwQEVf/Ht0t
\r
31 R2fBrM0VcAbHEl/3sbW+w+DKgpBmBbgNuugHvzljQ0B+nkojM3Y/uOl2NFsvPoxSFRdV
\r
32 oQcaUWdfmjcZpLmXNYRx3IBCp30A17fCZCOpkG4hIwQh7YXHCTgp+knwCyaMTxXz19YE
\r
34 X-Received: by 10.68.113.194 with SMTP id ja2mr15032747pbb.65.1371880024274;
\r
35 Fri, 21 Jun 2013 22:47:04 -0700 (PDT)
\r
36 Received: from localhost (215.42.233.220.static.exetel.com.au.
\r
38 by mx.google.com with ESMTPSA id tq8sm7868783pbc.30.2013.06.21.22.47.02
\r
39 for <multiple recipients>
\r
40 (version=TLSv1.2 cipher=RC4-SHA bits=128/128);
\r
41 Fri, 21 Jun 2013 22:47:03 -0700 (PDT)
\r
42 From: Peter Wang <novalazy@gmail.com>
\r
43 To: notmuch@notmuchmail.org
\r
44 Subject: [PATCH v6 02/12] tag-util: do not reset list in
\r
45 parse_tag_command_line
\r
46 Date: Sat, 22 Jun 2013 15:46:38 +1000
\r
47 Message-Id: <1371880008-18312-3-git-send-email-novalazy@gmail.com>
\r
48 X-Mailer: git-send-email 1.7.12.1
\r
49 In-Reply-To: <1371880008-18312-1-git-send-email-novalazy@gmail.com>
\r
50 References: <1371880008-18312-1-git-send-email-novalazy@gmail.com>
\r
51 X-BeenThere: notmuch@notmuchmail.org
\r
52 X-Mailman-Version: 2.1.13
\r
54 List-Id: "Use and development of the notmuch mail system."
\r
55 <notmuch.notmuchmail.org>
\r
56 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
57 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
58 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
59 List-Post: <mailto:notmuch@notmuchmail.org>
\r
60 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
61 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
62 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
63 X-List-Received-Date: Sat, 22 Jun 2013 05:47:11 -0000
\r
65 No current callers of parse_tag_command_line require that it clear its
\r
66 tag list argument. The notmuch 'insert' command will be better served
\r
67 if the function modifies a pre-populated list (of new.tags) instead of
\r
68 clobbering it outright.
\r
72 2 files changed, 2 insertions(+), 2 deletions(-)
\r
74 diff --git a/tag-util.c b/tag-util.c
\r
75 index 92e08a1..3bde409 100644
\r
78 @@ -165,8 +165,6 @@ parse_tag_command_line (void *ctx, int argc, char **argv,
\r
82 - tag_op_list_reset (tag_ops);
\r
84 for (i = 0; i < argc; i++) {
\r
85 if (strcmp (argv[i], "--") == 0) {
\r
87 diff --git a/tag-util.h b/tag-util.h
\r
88 index 246de85..4628f16 100644
\r
91 @@ -81,6 +81,8 @@ parse_tag_line (void *ctx, char *line,
\r
92 * Output Parameters:
\r
93 * ops contains a list of tag operations
\r
94 * query_str the search terms.
\r
96 + * The ops argument is not cleared.
\r