de/928574d0f228924388d1fc57f647c584a23a50

   1 Return-Path: <tomi.ollila@iki.fi>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id 233EE431FC0\r
   6         for <notmuch@notmuchmail.org>; Tue,  9 Apr 2013 05:12:37 -0700 (PDT)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: 0\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
  12         autolearn=disabled\r
  13 Received: from olra.theworths.org ([127.0.0.1])\r
  14         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  15         with ESMTP id 0-TgwqJ48eYg for <notmuch@notmuchmail.org>;\r
  16         Tue,  9 Apr 2013 05:12:36 -0700 (PDT)\r
  17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
  18         by olra.theworths.org (Postfix) with ESMTP id 6068E431FBD\r
  19         for <notmuch@notmuchmail.org>; Tue,  9 Apr 2013 05:12:36 -0700 (PDT)\r
  20 Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
  21         by guru.guru-group.fi (Postfix) with ESMTP id 4B76C100093;\r
  22         Tue,  9 Apr 2013 15:12:34 +0300 (EEST)\r
  23 From: Tomi Ollila <tomi.ollila@iki.fi>\r
  24 To: David Bremner <david@tethera.net>, Jed Brown <jed@59A2.org>,\r
  25         Jani Nikula <jani@nikula.org>, Karl Fogel <kfogel@red-bean.com>,\r
  26         Daniel Bergey <bergey@alum.mit.edu>\r
  27 Subject: Re: [PATCH] emacs: add missing paren to fix defun in\r
  28         notmuch-address.el.\r
  29 In-Reply-To: <87vc7vgbym.fsf@zancas.localnet>\r
  30 References: <87wqsfik5l.fsf@floss.red-bean.com>\r
  31         <87mwtah2hd.fsf@zancas.localnet>\r
  32         <877gkeau42.fsf@floss.red-bean.com>\r
  33         <m2ppy5v3mc.fsf@guru.guru-group.fi> <8738v1jtzc.fsf@nikula.org>\r
  34         <87k3odgutd.fsf@zancas.localnet> <87ip3wbj7g.fsf@mcs.anl.gov>\r
  35         <m2hajgxli5.fsf@guru.guru-group.fi>\r
  36         <87vc7vgbym.fsf@zancas.localnet>\r
  37 User-Agent: Notmuch/0.15.2+75~gd7fa7c4 (http://notmuchmail.org) Emacs/24.3.1\r
  38         (x86_64-unknown-linux-gnu)\r
  39 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
  40         $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
  41         !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
  42 Date: Tue, 09 Apr 2013 15:12:34 +0300\r
  43 Message-ID: <m2ehejykb1.fsf@guru.guru-group.fi>\r
  44 MIME-Version: 1.0\r
  45 Content-Type: text/plain\r
  46 Cc: notmuch@notmuchmail.org\r
  47 X-BeenThere: notmuch@notmuchmail.org\r
  48 X-Mailman-Version: 2.1.13\r
  49 Precedence: list\r
  50 List-Id: "Use and development of the notmuch mail system."\r
  51         <notmuch.notmuchmail.org>\r
  52 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  53         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  54 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  55 List-Post: <mailto:notmuch@notmuchmail.org>\r
  56 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  57 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  58         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  59 X-List-Received-Date: Tue, 09 Apr 2013 12:12:37 -0000\r
  60 \r
  61 On Tue, Apr 09 2013, David Bremner wrote:\r
  62 \r
  63 > Tomi Ollila <tomi.ollila@iki.fi> writes:\r
  64 >\r
  65 >> On Tue, Apr 09 2013, Jed Brown wrote:\r
  66 >>\r
  67 >>> David Bremner <david@tethera.net> writes:\r
  68 >>>\r
  69 >>>> Squashed sounds good to me too. Sorry I'm too lazy/busy at the moment to\r
  70 >>>> do it myself.\r
  71 >>>\r
  72 >>> I tested the attached and it's working as expected.  Sent as an\r
  73 >>> attachment to preserve author information.\r
  74 >>\r
  75 >> LGTM (this time tested, too). Also compared diffs by hand, change as announced.\r
  76 >> comments in id:m26207wgyt.fsf@guru.guru-group.fi (amend!) apply. \r
  77 >\r
  78 > There seems to be a few warnings:\r
  79 >\r
  80 > In notmuch-bbdb/snarf-from:\r
  81 > notmuch-address.el:116:26:Warning: reference to free variable\r
  82 >     `bbdb-get-addresses-headers'\r
  83 >\r
  84 > In notmuch-bbdb/snarf-to:\r
  85 > notmuch-address.el:122:29:Warning: reference to free variable\r
  86 >     `bbdb-get-addresses-headers'\r
  87 >\r
  88 > In end of data:\r
  89 > notmuch-address.el:143:1:Warning: the following functions are not known to be\r
  90 >     defined: bbdb-get-addresses, bbdb-update-records, notmuch-show-get-header\r
  91 >\r
  92 > Do we need a few defvars?\r
  93 \r
  94 For the above set, something like:\r
  95 \r
  96 (defvar bbdb-get-addresses-headers)\r
  97 \r
  98 (declare-function notmuch-show-get-header "notmuch-show" (header &optional props))\r
  99 \r
 100 (declare-function bbdb-get-addresses "bbdb-com" \r
 101   (only-first-address\r
 102    uninteresting-senders\r
 103    get-header-content-function\r
 104    &rest get-header-content-function-args))\r
 105 \r
 106 (declare-function bbdb-update-records "bbdb-com" (addrs auto-create-p offer-to-create))\r
 107 \r
 108 > d\r
 109 \r
 110 Tomi\r