1 Return-Path: <dmitry.kurochkin@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 86712417332
\r
6 for <notmuch@notmuchmail.org>; Fri, 24 Feb 2012 02:44:19 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id 1J9hYhagncjt for <notmuch@notmuchmail.org>;
\r
17 Fri, 24 Feb 2012 02:44:19 -0800 (PST)
\r
18 Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com
\r
19 [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id AD997417330
\r
22 for <notmuch@notmuchmail.org>; Fri, 24 Feb 2012 02:44:18 -0800 (PST)
\r
23 Received: by bkcit16 with SMTP id it16so2023133bkc.26
\r
24 for <notmuch@notmuchmail.org>; Fri, 24 Feb 2012 02:44:17 -0800 (PST)
\r
25 Received-SPF: pass (google.com: domain of dmitry.kurochkin@gmail.com
\r
26 designates 10.205.127.130 as permitted sender)
\r
27 client-ip=10.205.127.130;
\r
28 Authentication-Results: mr.google.com; spf=pass (google.com: domain of
\r
29 dmitry.kurochkin@gmail.com designates 10.205.127.130 as
\r
30 permitted sender) smtp.mail=dmitry.kurochkin@gmail.com;
\r
31 dkim=pass header.i=dmitry.kurochkin@gmail.com
\r
32 Received: from mr.google.com ([10.205.127.130])
\r
33 by 10.205.127.130 with SMTP id ha2mr849783bkc.28.1330080257256
\r
34 (num_hops = 1); Fri, 24 Feb 2012 02:44:17 -0800 (PST)
\r
35 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
\r
36 h=from:to:cc:subject:in-reply-to:references:user-agent:date
\r
37 :message-id:mime-version:content-type;
\r
38 bh=N53Q/VC1UW4XoBG7ClauPBsxrcjQZNRdP9Y/HHxAQMk=;
\r
39 b=PZihcSANEcMbkUjBTVLdpuw6g9sK/jkqla0hIgf1qXEP548FEsBDB22ZvtwC5GFsxu
\r
40 v0fenKCVtUi1da3TckrCmrSwv85BiYxmLUYAG+wzMBmBVim31OyYbvV5W19PLNBRICrX
\r
41 +faVdNcqlMxaQGbglUeiGEYBZeP/GIKddLCoA=
\r
42 Received: by 10.205.127.130 with SMTP id ha2mr707195bkc.28.1330080257191;
\r
43 Fri, 24 Feb 2012 02:44:17 -0800 (PST)
\r
44 Received: from localhost ([91.144.186.21])
\r
45 by mx.google.com with ESMTPS id i2sm7867207bkd.10.2012.02.24.02.44.16
\r
46 (version=TLSv1/SSLv3 cipher=OTHER);
\r
47 Fri, 24 Feb 2012 02:44:16 -0800 (PST)
\r
48 From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
\r
49 To: Pieter Praet <pieter@praet.org>, David Bremner <david@tethera.net>
\r
50 Subject: Re: [PATCH 5/6] emacs: simplify `notmuch-show-get-messages-ids{,
\r
52 In-Reply-To: <1330038554-10347-5-git-send-email-pieter@praet.org>
\r
53 References: <878vjtqhcg.fsf@praet.org>
\r
54 <1330038554-10347-5-git-send-email-pieter@praet.org>
\r
55 User-Agent: Notmuch/0.11.1+188~ga5674c2 (http://notmuchmail.org) Emacs/23.3.1
\r
56 (x86_64-pc-linux-gnu)
\r
57 Date: Fri, 24 Feb 2012 14:42:53 +0400
\r
58 Message-ID: <87d394jyvm.fsf@gmail.com>
\r
60 Content-Type: text/plain; charset=us-ascii
\r
61 Cc: Notmuch Mail <notmuch@notmuchmail.org>
\r
62 X-BeenThere: notmuch@notmuchmail.org
\r
63 X-Mailman-Version: 2.1.13
\r
65 List-Id: "Use and development of the notmuch mail system."
\r
66 <notmuch.notmuchmail.org>
\r
67 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
68 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
69 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
70 List-Post: <mailto:notmuch@notmuchmail.org>
\r
71 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
72 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
73 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
74 X-List-Received-Date: Fri, 24 Feb 2012 10:44:19 -0000
\r
76 On Fri, 24 Feb 2012 00:09:13 +0100, Pieter Praet <pieter@praet.org> wrote:
\r
77 > * emacs/notmuch-show.el
\r
79 > (notmuch-show-get-messages-ids):
\r
80 > If provided with optional arg SEPARATOR, return a string consisting
\r
81 > of all Message-Id's, separated by SEPARATOR. Also improve original
\r
82 > docstring wrt default return value.
\r
84 > (notmuch-show-get-messages-ids-search):
\r
85 > Removed, as its functionality is now in `notmuch-show-get-messages-ids'.
\r
87 > (notmuch-show-tag-all):
\r
88 > Call `notmuch-show-get-messages-ids' with SEPARATOR arg instead of
\r
89 > `notmuch-show-get-messages-ids-search'.
\r
92 There is another similar case in notmuch.el:
\r
93 `notmuch-show-get-messages-ids' and
\r
94 `notmuch-show-get-messages-ids-search'. There may be more.
\r
96 Please change them as well.
\r
101 > emacs/notmuch-show.el | 18 +++++++++---------
\r
102 > 1 files changed, 9 insertions(+), 9 deletions(-)
\r
104 > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
\r
105 > index 5fc0e43..4b37c77 100644
\r
106 > --- a/emacs/notmuch-show.el
\r
107 > +++ b/emacs/notmuch-show.el
\r
108 > @@ -1334,17 +1334,17 @@ (defun notmuch-show-get-message-id ()
\r
109 > "Return the message id of the current message."
\r
110 > (concat "id:\"" (notmuch-show-get-prop :id) "\""))
\r
112 > -(defun notmuch-show-get-messages-ids ()
\r
113 > - "Return all message ids of messages in the current thread."
\r
114 > +(defun notmuch-show-get-messages-ids (&optional separator)
\r
115 > + "Return a list of Message-Id's of all messages in the current buffer.
\r
117 > +If provided with optional argument SEPARATOR, return a string
\r
118 > +instead, consisting of all Message-Id's separated by SEPARATOR."
\r
119 > (let ((message-ids))
\r
120 > (notmuch-show-mapc t
\r
121 > (lambda () (push (notmuch-show-get-message-id) message-ids)))
\r
124 > -(defun notmuch-show-get-messages-ids-search ()
\r
125 > - "Return a search string for all message ids of messages in the
\r
126 > -current thread."
\r
127 > - (mapconcat 'identity (notmuch-show-get-messages-ids) " or "))
\r
129 > + (mapconcat 'identity message-ids separator)
\r
132 > ;; dme: Would it make sense to use a macro for many of these?
\r
134 > @@ -1633,7 +1633,7 @@ (defun notmuch-show-tag-all (&rest tag-changes)
\r
136 > TAG-CHANGES is a list of tag operations for `notmuch-tag'."
\r
137 > (interactive (notmuch-read-tag-changes nil notmuch-show-thread-id))
\r
138 > - (apply 'notmuch-tag (notmuch-show-get-messages-ids-search) tag-changes)
\r
139 > + (apply 'notmuch-tag (notmuch-show-get-messages-ids " or ") tag-changes)
\r
140 > (notmuch-show-mapc t
\r
142 > (let* ((current-tags (notmuch-show-get-tags))
\r