dd/e4e38a7595eeb5dd6dedf1425638896b23558c

   1 Return-Path: <jrollins@finestructure.net>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id 92F29429E35\r
   6         for <notmuch@notmuchmail.org>; Mon, 28 Nov 2011 06:24:31 -0800 (PST)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -2.29\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5\r
  12         tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled\r
  13 Received: from olra.theworths.org ([127.0.0.1])\r
  14         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  15         with ESMTP id gjzvQGFvJy83 for <notmuch@notmuchmail.org>;\r
  16         Mon, 28 Nov 2011 06:24:30 -0800 (PST)\r
  17 Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu\r
  18         [131.215.239.19])\r
  19         by olra.theworths.org (Postfix) with ESMTP id D5367429E2F\r
  20         for <notmuch@notmuchmail.org>; Mon, 28 Nov 2011 06:24:23 -0800 (PST)\r
  21 Received: from fire-doxen.imss.caltech.edu (localhost [127.0.0.1])\r
  22         by fire-doxen-postvirus (Postfix) with ESMTP id 465D42E50DD1;\r
  23         Mon, 28 Nov 2011 06:24:23 -0800 (PST)\r
  24 X-Spam-Scanned: at Caltech-IMSS on fire-doxen by amavisd-new\r
  25 Received: from finestructure.net (dyn-pupin-171-227.dyn.columbia.edu\r
  26         [128.59.171.227]) (Authenticated sender: jrollins)\r
  27         by fire-doxen-submit (Postfix) with ESMTP id 68A372E5069F;\r
  28         Mon, 28 Nov 2011 06:24:20 -0800 (PST)\r
  29 Received: by finestructure.net (Postfix, from userid 1000)\r
  30         id 5B1E3B8F; Mon, 28 Nov 2011 06:24:19 -0800 (PST)\r
  31 From: Jameson Graef Rollins <jrollins@finestructure.net>\r
  32 To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>, notmuch@notmuchmail.org\r
  33 Subject: Re: [PATCH 1/2] emacs: remove some code duplication in notmuch-show\r
  34 In-Reply-To: <1322259811-10834-1-git-send-email-dmitry.kurochkin@gmail.com>\r
  35 References: <1322259811-10834-1-git-send-email-dmitry.kurochkin@gmail.com>\r
  36 User-Agent: Notmuch/0.10~rc1+25~g719d650 (http://notmuchmail.org) Emacs/23.3.1\r
  37         (x86_64-pc-linux-gnu)\r
  38 Date: Mon, 28 Nov 2011 06:24:19 -0800\r
  39 Message-ID: <87lir0xr3g.fsf@servo.finestructure.net>\r
  40 MIME-Version: 1.0\r
  41 Content-Type: multipart/signed; boundary="=-=-=";\r
  42         micalg=pgp-sha256; protocol="application/pgp-signature"\r
  43 X-BeenThere: notmuch@notmuchmail.org\r
  44 X-Mailman-Version: 2.1.13\r
  45 Precedence: list\r
  46 List-Id: "Use and development of the notmuch mail system."\r
  47         <notmuch.notmuchmail.org>\r
  48 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  49         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  50 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  51 List-Post: <mailto:notmuch@notmuchmail.org>\r
  52 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  53 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  54         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  55 X-List-Received-Date: Mon, 28 Nov 2011 14:24:32 -0000\r
  56 \r
  57 --=-=-=\r
  58 \r
  59 On Sat, 26 Nov 2011 02:23:30 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:\r
  60 > -(defun notmuch-show-get-header (header)\r
  61 > +(defun notmuch-show-get-header (header &optional props)\r
  62 >    "Return the named header of the current message, if any."\r
  63 > -  (plist-get (notmuch-show-get-prop :headers) header))\r
  64 > +  (plist-get (notmuch-show-get-prop :headers props) header))\r
  65 \r
  66 Hey, Dmitry.  It looks like the new plist-get call is assuming props is\r
  67 defined, but it looks like it's only optional in the argument list.\r
  68 Wouldn't the function fail if the props argument is not supplied?\r
  69 \r
  70 jamie.\r
  71 \r
  72 --=-=-=\r
  73 Content-Type: application/pgp-signature\r
  74 \r
  75 -----BEGIN PGP SIGNATURE-----\r
  76 Version: GnuPG v1.4.11 (GNU/Linux)\r
  77 \r
  78 iQIcBAEBCAAGBQJO05mTAAoJEO00zqvie6q8Ya8P/0cZORADkMMeM0KFqlKZ0JSm\r
  79 mRA3sb7wXs2GzsC0bGs6iErLHBt+yNe11dAk9lL9OssWkP/C1VQdOzGYqfiKmUqR\r
  80 EP88ScwCIbn277sQaFObbRBzaW+5JP9JlDKEe6Rx6OT1jn3XTrsg8qvWQ6N5Xy9g\r
  81 Ms73SuR1xD3gISt/dsXLCiKmHTNr3va53eSubedY5p0WHpHM8Lcf2Zo6jE09H2UW\r
  82 9RSfJ4rGptoXVyUbFAcpMyLko3lKhhwnfqlk5KaFQSpV+tLm4pwI+MuTPz+IZOt+\r
  83 QxF35KPJlya4ji2AndAekdp054+O9ajJ0DpJTfrhhmtqnyBHGLmm3Jvz8BgEmN57\r
  84 0gUv81NMK+1kOBSnMagwnRQfqmMlmzQPBXnQH45fJVlUzuAEBujPzNPn70FXBz2g\r
  85 3BJA99jn/2VVcf4ZEwJ5UxUTBXopNKQv7LU0hfB23bEe3TWtNR4dMCekdh/uwYak\r
  86 tsGobOanHer74xHEwAvDKtcYx2JCfdwPFYfyZ3u5+TrNDIXy6UiYvnmtfDBsHrML\r
  87 gNIk54t0Sl7b6dZasueQYrBWfb3N6YSyKdNtAuw028CTyXKGDc4AYvW0bOzSJbm9\r
  88 W5OnaSTBsHPMGAJvNh5zR9rKu94eoBrI6n/xon/r6fPI75Chlx72+KnTrXPvnKts\r
  89 9SGyMuCrGNoSrtaG8BxY\r
  90 =ysjn\r
  91 -----END PGP SIGNATURE-----\r
  92 --=-=-=--\r