dd/d407bd45686e0f9999c5c8071d9d106592c7e9

   1 Return-Path: <amdragon@mit.edu>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id 75270431FAF\r
   6         for <notmuch@notmuchmail.org>; Thu, 30 Aug 2012 20:52:32 -0700 (PDT)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.7\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
  12         tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
  13 Received: from olra.theworths.org ([127.0.0.1])\r
  14         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  15         with ESMTP id 0YGkm2tfrE6p for <notmuch@notmuchmail.org>;\r
  16         Thu, 30 Aug 2012 20:52:30 -0700 (PDT)\r
  17 Received: from dmz-mailsec-scanner-8.mit.edu (DMZ-MAILSEC-SCANNER-8.MIT.EDU\r
  18         [18.7.68.37])\r
  19         by olra.theworths.org (Postfix) with ESMTP id 973D2431FAE\r
  20         for <notmuch@notmuchmail.org>; Thu, 30 Aug 2012 20:52:30 -0700 (PDT)\r
  21 X-AuditID: 12074425-b7f9b6d0000008c4-1e-504034fe0d2d\r
  22 Received: from mailhub-auth-2.mit.edu ( [18.7.62.36])\r
  23         by dmz-mailsec-scanner-8.mit.edu (Symantec Messaging Gateway) with SMTP\r
  24         id 6C.34.02244.EF430405; Thu, 30 Aug 2012 23:52:30 -0400 (EDT)\r
  25 Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
  26         by mailhub-auth-2.mit.edu (8.13.8/8.9.2) with ESMTP id q7V3qTlM019929; \r
  27         Thu, 30 Aug 2012 23:52:29 -0400\r
  28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
  29         (authenticated bits=0)\r
  30         (User authenticated as amdragon@ATHENA.MIT.EDU)\r
  31         by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q7V3qRqr002909\r
  32         (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
  33         Thu, 30 Aug 2012 23:52:28 -0400 (EDT)\r
  34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
  35         (envelope-from <amdragon@mit.edu>)\r
  36         id 1T7IHT-00086O-FR; Thu, 30 Aug 2012 23:52:27 -0400\r
  37 Date: Thu, 30 Aug 2012 23:52:27 -0400\r
  38 From: Austin Clements <amdragon@MIT.EDU>\r
  39 To: david@tethera.net\r
  40 Subject: Re: [PATCH] test: use (format "%S") to print nil in emacs test.\r
  41 Message-ID: <20120831035227.GH11179@mit.edu>\r
  42 References: <1346375399-449-1-git-send-email-david@tethera.net>\r
  43 MIME-Version: 1.0\r
  44 Content-Type: text/plain; charset=us-ascii\r
  45 Content-Disposition: inline\r
  46 In-Reply-To: <1346375399-449-1-git-send-email-david@tethera.net>\r
  47 User-Agent: Mutt/1.5.21 (2010-09-15)\r
  48 X-Brightmail-Tracker:\r
  49  H4sIAAAAAAAAA+NgFprBKsWRmVeSWpSXmKPExsUixG6novvPxCHAYEsHt8XGZT+ZLW60djNa\r
  50         XL85k9mB2eNX21xmj2erbjF7bDn0njmAOYrLJiU1J7MstUjfLoEr4+LeH8wFC3grZv++xdLA\r
  51         +J2ri5GDQ0LARGLH8vouRk4gU0ziwr31bF2MXBxCAvsYJdb+/wPlbGCU+PZ5JQtIlZDASSaJ\r
  52         LVuLIRJLGCX+37nJDpJgEVCV6DvaB1bEJqAhsW3/ckYQW0RAVOL0pkmsIDazgL3EotmTwOqF\r
  53         BTwkOq+fB4vzCuhINHfNYIJYYC9x9sFlNoi4oMTJmU9YIHq1JG78e8kEcjWzgLTE8n8cIGFO\r
  54         AQeJ7bMg1ooKqEhMObmNbQKj0Cwk3bOQdM9C6F7AyLyKUTYlt0o3NzEzpzg1Wbc4OTEvL7VI\r
  55         10IvN7NELzWldBMjONBdVHcwTjikdIhRgINRiYe3co19gBBrYllxZe4hRkkOJiVRXm9jhwAh\r
  56         vqT8lMqMxOKM+KLSnNTiQ4wSHMxKIryzPgOV86YkVlalFuXDpKQ5WJTEeW+k3PQXEkhPLEnN\r
  57         Tk0tSC2CycpwcChJ8JoAI1pIsCg1PbUiLTOnBCHNxMEJMpwHaPhxkMW8xQWJucWZ6RD5U4y6\r
  58         HP9PnrzLKMSSl5+XKiXOKw0ySACkKKM0D24OLEG9YhQHekuY9yHIKB5gcoOb9ApoCRPQEjkN\r
  59         kA+KSxIRUlINjBlrd/G56Taw6z3Rnl0ZzWXsJMlsHpTrn2kafEWgSmd9+BJz0/t7Dt7Le2rP\r
  60         vn7XlL9XuipMri2Ve59eMu37m4Y3ylHfDLdmTjojuuxSkp/N3zVVMcW6hUq3PYz5d9+RuMaQ\r
  61         KJd+79HyqcYTPuQo5a6oub79QtQv7gu3C9bGfvhXqHhONNVDR4mlOCPRUIu5qDgRAEjT9vcr        AwAA\r
  62 Cc: notmuch@notmuchmail.org, David Bremner <bremner@debian.org>\r
  63 X-BeenThere: notmuch@notmuchmail.org\r
  64 X-Mailman-Version: 2.1.13\r
  65 Precedence: list\r
  66 List-Id: "Use and development of the notmuch mail system."\r
  67         <notmuch.notmuchmail.org>\r
  68 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  69         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  70 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  71 List-Post: <mailto:notmuch@notmuchmail.org>\r
  72 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  73 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  74         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  75 X-List-Received-Date: Fri, 31 Aug 2012 03:52:32 -0000\r
  76 \r
  77 LGTM.  Alternatively, the test could be\r
  78   (null (notmuch-wash....))\r
  79 with the correct answer being 't'.  That would avoid the awkward\r
  80 detour through a string, but either way is good as long as this test\r
  81 passes.\r
  82 \r
  83 Quoth david@tethera.net on Aug 30 at 10:09 pm:\r
  84 > From: David Bremner <bremner@debian.org>\r
  85 > \r
  86 > The behaviour of "emacsclient --eval nil" changed from emacs23 to\r
  87 > emacs24, and in emacs24 it prints 'nil' rather than an empty string.\r
  88 > \r
  89 > (format "%S" foo) produces a sexpr form of foo, and is consistent\r
  90 > between the two versions.\r
  91 > ---\r
  92 > \r
  93 > This fixes another test failure on emacs24. \r
  94 > \r
  95 > I guess maybe all test_emacs output could be canonicalized this way,\r
  96 > but I suspect that would be pretty disruptive.\r
  97 > \r
  98 >  test/emacs-subject-to-filename |    6 +++---\r
  99 >  1 file changed, 3 insertions(+), 3 deletions(-)\r
 100 > \r
 101 > diff --git a/test/emacs-subject-to-filename b/test/emacs-subject-to-filename\r
 102 > index 176e685..a0ffdfe 100755\r
 103 > --- a/test/emacs-subject-to-filename\r
 104 > +++ b/test/emacs-subject-to-filename\r
 105 > @@ -8,10 +8,10 @@ test_emacs '(ignore)'\r
 106 >  \r
 107 >  # test notmuch-wash-subject-to-patch-sequence-number (subject)\r
 108 >  test_begin_subtest "no patch sequence number"\r
 109 > -output=$(test_emacs '(notmuch-wash-subject-to-patch-sequence-number\r
 110 > -      "[PATCH] A normal patch subject without numbers")'\r
 111 > +output=$(test_emacs '(format "%S" (notmuch-wash-subject-to-patch-sequence-number\r
 112 > +      "[PATCH] A normal patch subject without numbers"))'\r
 113 >  )\r
 114 > -test_expect_equal "$output" ""\r
 115 > +test_expect_equal "$output" '"nil"'\r
 116 >  \r
 117 >  test_begin_subtest "patch sequence number #1"\r
 118 >  output=$(test_emacs '(notmuch-wash-subject-to-patch-sequence-number\r