1 Return-Path: <cworth@cworth.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id DDAE2429E25
\r
6 for <notmuch@notmuchmail.org>; Wed, 25 May 2011 15:17:14 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0.01 tagged_above=-999 required=5
\r
12 tests=[T_MIME_NO_TEXT=0.01] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id HHcp5KFzQMtD for <notmuch@notmuchmail.org>;
\r
16 Wed, 25 May 2011 15:17:14 -0700 (PDT)
\r
17 Received: from arlo.cworth.org (arlo.cworth.org [50.43.72.2])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 51036431FB6
\r
19 for <notmuch@notmuchmail.org>; Wed, 25 May 2011 15:17:14 -0700 (PDT)
\r
20 Received: from yoom.home.cworth.org (localhost [127.0.0.1])
\r
21 by arlo.cworth.org (Postfix) with ESMTP id C321629A052;
\r
22 Wed, 25 May 2011 15:17:12 -0700 (PDT)
\r
23 Received: by yoom.home.cworth.org (Postfix, from userid 1000)
\r
24 id AEBE425417E; Wed, 25 May 2011 15:17:12 -0700 (PDT)
\r
25 From: Carl Worth <cworth@cworth.org>
\r
26 To: Thomas Jost <schnouki@schnouki.net>,
\r
27 Stewart Smith <stewart@flamingspork.com>, notmuch <notmuch@notmuchmail.org>
\r
28 Subject: Re: [PATCH] emacs: Allow user to choose "From" address when composing
\r
30 In-Reply-To: <87lixu7w71.fsf@thor.loria.fr>
\r
31 References: <87vcxb0za4.fsf@flamingspork.com>
\r
32 <87wrhfvk6a.fsf@yoom.home.cworth.org>
\r
33 <87lixvvjty.fsf@yoom.home.cworth.org>
\r
34 <87lixu7w71.fsf@thor.loria.fr>
\r
35 User-Agent: Notmuch/0.5 (http://notmuchmail.org) Emacs/23.3.1
\r
37 Date: Wed, 25 May 2011 15:17:05 -0700
\r
38 Message-ID: <87r57ma0im.fsf@yoom.home.cworth.org>
\r
40 Content-Type: multipart/signed; boundary="=-=-=";
\r
41 micalg=pgp-sha1; protocol="application/pgp-signature"
\r
42 X-BeenThere: notmuch@notmuchmail.org
\r
43 X-Mailman-Version: 2.1.13
\r
45 List-Id: "Use and development of the notmuch mail system."
\r
46 <notmuch.notmuchmail.org>
\r
47 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
48 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
49 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
50 List-Post: <mailto:notmuch@notmuchmail.org>
\r
51 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
52 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
53 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
54 X-List-Received-Date: Wed, 25 May 2011 22:17:15 -0000
\r
57 Content-Transfer-Encoding: quoted-printable
\r
59 On Wed, 25 May 2011 15:21:06 +0200, Thomas Jost <schnouki@schnouki.net> wro=
\r
61 > Thanks, IMHO that's better than my previous solution. And it makes my
\r
62 > .emacs smaller, woohoo! :)
\r
64 Thanks for the review.
\r
66 > One little issue though: you did not update notmuch-show-mode-map in
\r
67 > notmuch-show.el. I'll reply with a patch that fixes that (or you can
\r
68 > just integrate it in your commit when pushing it).
\r
72 > I'll also send a few additional patches that make it possible to choose
\r
73 > the "From" address when forwarding a message and when replying to a
\r
76 The only real concern I have with the series is that it grabs 'R' for
\r
77 reply-with-custom-from where I've been planning to implement 'R' as
\r
78 reply-to-sender-only, (a long-missing and often-requested feature).
\r
80 When I first started implementing the custom-from feature I planned to
\r
81 use a prefix argument to get the behavior (such as "C-u m" rather than
\r
82 "M" for compose-new-mail-with-custom-from). You might even see I've got
\r
83 some code written along those lines.
\r
85 When I went to test it though, it didn't work. That was probably some
\r
86 silly mistake on my part, (we do already have working code that changes
\r
87 behavior with a prefix argument in the case of "M-RET" for example).
\r
89 If you want to update the series to move away from capital-letter
\r
90 keybindings in favor of a prefix argument, I'll be glad to accept it.
\r
92 Otherwise, I might get around to doing that myself at some point.
\r
99 carl.d.worth@intel.com
\r
102 Content-Type: application/pgp-signature
\r
104 -----BEGIN PGP SIGNATURE-----
\r
105 Version: GnuPG v1.4.11 (GNU/Linux)
\r
107 iEYEARECAAYFAk3df+EACgkQ6JDdNq8qSWhPJgCgk5FFqAGUWNtli9wTDWqWErtb
\r
108 ehIAn33Zj0SjgW91NBGMYhDOMK857sAr
\r
110 -----END PGP SIGNATURE-----
\r