1 Return-Path: <cworth@cworth.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 36A87431FD0
\r
6 for <notmuch@notmuchmail.org>; Fri, 27 May 2011 18:29:48 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0.01 tagged_above=-999 required=5
\r
12 tests=[T_MIME_NO_TEXT=0.01] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id pR1ucMGZGMfC for <notmuch@notmuchmail.org>;
\r
16 Fri, 27 May 2011 18:29:47 -0700 (PDT)
\r
17 Received: from arlo.cworth.org (arlo.cworth.org [50.43.72.2])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 2F953431FB6
\r
19 for <notmuch@notmuchmail.org>; Fri, 27 May 2011 18:29:47 -0700 (PDT)
\r
20 Received: from yoom.home.cworth.org (localhost [127.0.0.1])
\r
21 by arlo.cworth.org (Postfix) with ESMTP id BDBF629A503;
\r
22 Fri, 27 May 2011 18:29:44 -0700 (PDT)
\r
23 Received: by yoom.home.cworth.org (Postfix, from userid 1000)
\r
24 id 57ADB25417F; Fri, 27 May 2011 17:53:54 -0700 (PDT)
\r
25 From: Carl Worth <cworth@cworth.org>
\r
26 To: Jameson Graef Rollins <jrollins@finestructure.net>,
\r
27 notmuch@notmuchmail.org
\r
28 Subject: Re: normalizing part numbering across PGP/MIME processing
\r
29 In-Reply-To: <1306492059-7706-1-git-send-email-jrollins@finestructure.net>
\r
30 References: <1306371680-19441-1-git-send-email-jrollins@finestructure.net>
\r
31 <1306492059-7706-1-git-send-email-jrollins@finestructure.net>
\r
32 User-Agent: Notmuch/0.5 (http://notmuchmail.org) Emacs/23.3.1
\r
34 Date: Fri, 27 May 2011 17:53:44 -0700
\r
35 Message-ID: <87lixr1w87.fsf@yoom.home.cworth.org>
\r
37 Content-Type: multipart/signed; boundary="=-=-=";
\r
38 micalg=pgp-sha1; protocol="application/pgp-signature"
\r
39 X-BeenThere: notmuch@notmuchmail.org
\r
40 X-Mailman-Version: 2.1.13
\r
42 List-Id: "Use and development of the notmuch mail system."
\r
43 <notmuch.notmuchmail.org>
\r
44 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
45 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
46 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
47 List-Post: <mailto:notmuch@notmuchmail.org>
\r
48 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
49 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
50 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
51 X-List-Received-Date: Sat, 28 May 2011 01:29:48 -0000
\r
54 Content-Transfer-Encoding: quoted-printable
\r
56 On Fri, 27 May 2011 03:27:35 -0700, Jameson Graef Rollins <jrollins@finestr=
\r
58 > Ok. So I very much hope this patch series satisfies those who were
\r
59 > bothered by the part renumbering that was happening when PGP/MIME
\r
60 > parts were processed. For signed messages we no longer modify the
\r
61 > parts at all, so numbering always remains constant, and for encrypted
\r
62 > messages the numbering will only change if the encrypted message is
\r
65 That sounds much better to me. I think the remaining issues I have with
\r
66 the patch series are very minor and can be applied after the fact. I'd
\r
67 push the series right now except that I happen to have no network access
\r
68 at the moment. [I'm queueing up this message for delivery, so if I'm on
\r
69 top of things when I'm back in range, I'll push right away.]
\r
71 So, well done, Jameson! You've been extremely patient as I sat on this
\r
72 patch series for *so* long, and then made you rebuild it so many
\r
73 times. I hope you think the rebuilds were at least worth it for the much
\r
74 cleaner final state, (I know that the useless waiting wasn't worth it).
\r
76 I promise you don't need to rebuild this branch anymore, nor keep asking
\r
77 me to merge it. Go enjoy a good US-holiday weekend. You've earned it!
\r
79 That said, here are the (minor) issues I have with the series:
\r
81 * More tests should be switched to the new text_expect_equal_file
\r
83 This isn't a problem with the series---but will be a nice
\r
84 fix. I think the current "notmuch search --output=3Dtags *" is
\r
85 broken due to a missing final newline---or at least has been
\r
86 broken that way recently. So it will be nice to have this
\r
87 support for testing a final newline.
\r
89 * The series duplicates some existing code into a new
\r
90 emacs_deliver_message
\r
92 The previously-existing code should be removed and replaced with
\r
93 a call to the new function.
\r
95 * Should we set the crypto option to verify/decrypt by default?
\r
97 That would certainly be convenient for me at least.
\r
99 For people who don't want this, they can set the variable to
\r
100 nil. But then they'll still have the following issue:
\r
102 * I'm not a fan of the M-RET option for decrypting a message
\r
104 If someone is going to have encrypted messages not decrypted by
\r
105 default, then they can currently decrypt by opening the message
\r
106 with M-RET. But I think in common use, the user is likely to
\r
107 only realize too late that they want to decrypt the message.
\r
109 So what I'd love to see is a keybinding for decrypting a message
\r
110 from the view of the message itself. (One natural place would be
\r
111 by activating the button of the encrypted part---but a
\r
112 keybinding to review with decryption would be fine too---likely
\r
113 easier to code and easier to use.)
\r
115 * I can't actually get decryption to work for me. :-(
\r
117 When I run "notmuch show --decrypt" on a message encrypted with
\r
118 my public key I get a segfault within libgmime, specifically in
\r
119 the g_mime_session_request_passwd function.
\r
121 My first guess is that this is due to the fact that gpg-agent
\r
122 can't be run on my system (Debian unstable):
\r
125 gpg-agent: symbol lookup error: /usr/lib/libassuan.so.0: undefined symbol:=
\r
128 I've got a Debian bug report queued up for this.
\r
130 I also tried running the same "notmuch show" command without
\r
131 gpg-agent installed. How is libgmime supposed to actually
\r
132 request a password in a case like this?
\r
134 Anyway, I know that not everyone has this same problem with the
\r
135 series, so I'm not blocking it for this.
\r
140 carl.d.worth@intel.com
\r
143 Content-Type: application/pgp-signature
\r
145 -----BEGIN PGP SIGNATURE-----
\r
146 Version: GnuPG v1.4.11 (GNU/Linux)
\r
148 iEYEARECAAYFAk3gR5gACgkQ6JDdNq8qSWhRcQCbBOHt7AbCVjgF88o5lpFSR5f6
\r
149 zZAAoJjpwUyp/OwAyKy/vhvyGFTBNZGB
\r
151 -----END PGP SIGNATURE-----
\r