1 Return-Path: <m.walters@qmul.ac.uk>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 2A955429E21
\r
6 for <notmuch@notmuchmail.org>; Tue, 22 Oct 2013 14:44:12 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=1.401 tagged_above=-999 required=5
\r
12 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,
\r
13 FREEMAIL_REPLY=2.499, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3]
\r
15 Received: from olra.theworths.org ([127.0.0.1])
\r
16 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
17 with ESMTP id hmrjTVJ+H8Zo for <notmuch@notmuchmail.org>;
\r
18 Tue, 22 Oct 2013 14:44:06 -0700 (PDT)
\r
19 Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])
\r
20 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
21 (No client certificate requested)
\r
22 by olra.theworths.org (Postfix) with ESMTPS id 012A6431FDE
\r
23 for <notmuch@notmuchmail.org>; Tue, 22 Oct 2013 14:44:05 -0700 (PDT)
\r
24 Received: from smtp.qmul.ac.uk ([138.37.6.40])
\r
25 by mail2.qmul.ac.uk with esmtp (Exim 4.71)
\r
26 (envelope-from <m.walters@qmul.ac.uk>)
\r
27 id 1VYjk3-0006l5-4a; Tue, 22 Oct 2013 22:43:57 +0100
\r
28 Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)
\r
29 by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)
\r
30 (envelope-from <m.walters@qmul.ac.uk>)
\r
31 id 1VYjk2-0005zE-Pa; Tue, 22 Oct 2013 22:43:54 +0100
\r
32 From: Mark Walters <markwalters1009@gmail.com>
\r
33 To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
\r
34 Subject: Re: [PATCH 0/8] Improve tag change completion
\r
35 In-Reply-To: <1382471457-26056-1-git-send-email-amdragon@mit.edu>
\r
36 References: <1382471457-26056-1-git-send-email-amdragon@mit.edu>
\r
37 User-Agent: Notmuch/0.16 (http://notmuchmail.org) Emacs/23.4.1
\r
38 (x86_64-pc-linux-gnu)
\r
39 Date: Tue, 22 Oct 2013 22:43:53 +0100
\r
40 Message-ID: <87mwm1x9pi.fsf@qmul.ac.uk>
\r
42 Content-Type: text/plain; charset=us-ascii
\r
43 X-Sender-Host-Address: 93.97.24.31
\r
44 X-QM-SPAM-Info: Sender has good ham record. :)
\r
45 X-QM-Body-MD5: e0c77d7dadca19c97f6dc04e6a0b8e19 (of first 20000 bytes)
\r
46 X-SpamAssassin-Score: 0.6
\r
47 X-SpamAssassin-SpamBar: /
\r
48 X-SpamAssassin-Report: The QM spam filters have analysed this message to
\r
50 spam. We require at least 5.0 points to mark a message as spam.
\r
51 This message scored 0.6 points. Summary of the scoring:
\r
52 * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
\r
53 provider * (markwalters1009[at]gmail.com)
\r
54 * 1.0 FREEMAIL_REPLY From and body contain different freemails
\r
55 * -0.4 AWL AWL: From: address is in the auto white-list
\r
56 X-QM-Scan-Virus: ClamAV says the message is clean
\r
57 X-BeenThere: notmuch@notmuchmail.org
\r
58 X-Mailman-Version: 2.1.13
\r
60 List-Id: "Use and development of the notmuch mail system."
\r
61 <notmuch.notmuchmail.org>
\r
62 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
63 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
64 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
65 List-Post: <mailto:notmuch@notmuchmail.org>
\r
66 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
67 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
68 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
69 X-List-Received-Date: Tue, 22 Oct 2013 21:44:12 -0000
\r
72 This looks good to me +1. It makes the code clearer and nicer to read as
\r
73 well as giving a better user experience, and it is makes fixing the long
\r
74 standing tagging races simpler.
\r
76 I have a couple of docstring comments:
\r
78 In patch 2 perhaps notmuch-tag-completions could have a docstring.
\r
80 In Patch 4 I think the docstring for notmuch-search-tag is outdated: it
\r
81 is "Change tags for the currently selected thread or region." but
\r
82 beg and end can now be specified by the caller.
\r
84 and one actual comment:
\r
86 in patch 3 (for show) delete-dups is called before the list is passed to
\r
87 notmuch-read-tag-changes whereas it is not for search or pick.
\r
88 Obviously this is not actually a problem but it might be worth being
\r
91 But that was all I found. All tests pass and everything I try behaves
\r
92 exactly as expected.
\r
99 On Tue, 22 Oct 2013, Austin Clements <amdragon@MIT.EDU> wrote:
\r
100 > This series improves tag change completion in various ways for
\r
101 > commands like +, -, and *.
\r
103 > From a user perspective, this provides command-specific prompts like
\r
104 > "Tag message" and "Tag all" instead of the generic "Tag" prompt, and
\r
105 > bases tag removal completions on the tags that are in the buffer,
\r
106 > rather than the current tags in the database, providing a more
\r
107 > predicable experience.
\r
109 > From an implementation perspective, this new tag removal completion
\r
110 > behavior improves efficiency and eliminates a road block to fixing the
\r
111 > tagging race bug (which otherwise results in massive queries just to
\r
112 > compute removal completions). The new code is also more "Elispy" and
\r
113 > predictable because all tag change prompting now occurs at the
\r
114 > interactive entry points, rather than buried under several layers of
\r
115 > non-interactive calls.
\r
117 > This is a spiritual successor to
\r
118 > id:1354263691-19715-1-git-send-email-markwalters1009@gmail.com, though
\r
119 > it takes a very different approach. This is also a prerequisite to
\r
120 > the tag race fix in
\r
121 > id:1381185201-25197-1-git-send-email-amdragon@mit.edu and I plan to
\r
122 > send an updated version of that series when this one is accepted.
\r
124 > Patches 1, 5, and 6 could be pushed on their own. They fix bugs or
\r
125 > sort of bugs that get in the way of the rest of the series.
\r
127 > _______________________________________________
\r
128 > notmuch mailing list
\r
129 > notmuch@notmuchmail.org
\r
130 > http://notmuchmail.org/mailman/listinfo/notmuch
\r